+1 on the flatpak side, as I reviewed the other end.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Oct 9 2017
Oct 9 2017
Let's get it in altogether and when we remove the QPA this code will go with it.
apol added a comment to D8223: Export the really used platform in env variable QT_QPA_FLATPAK_PLATFORM.
I don't have an issue with it. +1
nm-qt shouldn't be needed anymore
Enable sound for kanagram and khangman
These headers shouldn't be needed anymore
Submitted to github by bhushan
apol committed R857:92eea0079324: Include some required dependencies in the Android SDK docker image (authored by apol).
Include some required dependencies in the Android SDK docker image
Fix syntax issue on Android CI Dockerfile
Add missing python packages
Pull the CI image from dockerhub
First approach to Android CI
A screenshot would be great, in fact.
Why does it need to be in a different column? Am I missing something?
apol committed R38:7915494ccc4f: Add the docker file for the CI, based on the SDK (authored by apol).
Add the docker file for the CI, based on the SDK
Try a slightly different approach
Oct 8 2017
Oct 8 2017
apol added a comment to D8211: KDevelop/Documentation : implementation of a QTextBrowser-based viewer.
TBH... why bother.
You have the risk that it's not properly rendered and adds more code to maintain...
Mostly tests though ^^'.
Thanks!
Correct. It's related to this one: https://phabricator.kde.org/T5847
Add missing coma
apol committed R325:a6038992555d: Include the Android manifest in the KAlgebra repository (authored by apol).
Include the Android manifest in the KAlgebra repository
apol committed R325:8dbf707fd444: Don't build the desktop variant if we are building for Android (authored by apol).
Don't build the desktop variant if we are building for Android
Akonadi@Kontact needs networkmanager-qt
Add more stuff after Albert's testing
Oct 7 2017
Oct 7 2017
apol committed R256:6164fa923ff3: Allow to download stuff from internet in edu apps that use knewstuff (authored by apol).
Allow to download stuff from internet in edu apps that use knewstuff
apol updated the task description for T6895: Making KDE software the #1 choice for research and academia.
apol updated the task description for T6895: Making KDE software the #1 choice for research and academia.
apol committed R224:214950b3bbb4: Make sure there's not a path within the filename (authored by apol).
Make sure there's not a path within the filename
We have had this patch in the past I think.
remove unrelated change I introduced
Reduce stress over the application delegate
Improve convergent logic
Oct 5 2017
Oct 5 2017
Simplify the logic around the search field
apol committed R134:d73019515d78: Simplify clear search logic, centralize within the TextField (authored by apol).
Simplify clear search logic, centralize within the TextField
Oct 4 2017
Oct 4 2017
Exclusively rely on the Kirigami.Units
apol committed R134:f4dd16fe20a6: Remove our own Heading item, just use kirigami's (authored by apol).
Remove our own Heading item, just use kirigami's
Use QQC2 Label as kirigami does
apol added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.
In D8088#152151, @zhigalin wrote:In D8088#151644, @apol wrote:I think it's good to show the dialog if there's just the one device. This way you see what's happening, at least that was my thinking.
I did it because I used KDEConnect to open tel:+390123456 links on the web to dial these numbers and that window appeared to be quite bothering...
apol committed R474:a06065e1aa91: Make sure the devices selector isn't hidden under the video item (authored by apol).
Make sure the devices selector isn't hidden under the video item
Make cmake-server output forwarding a qCDebug
Oops
Oct 2 2017
Oct 2 2017
Oops
So maybe it's just not ours?
apol committed R19:56a3e5e10614: Remove wifi-setup, it assumes the wifi id is wlan0 (authored by apol).
Remove wifi-setup, it assumes the wifi id is wlan0
I just tried it, orca is working. Dropped kdelibs4support while looking into the code to make sure it's working.
Kirigami 1.0 isn't supported anyway, so it's indeed needed.
apol added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.
I think it's good to show the dialog if there's just the one device. This way you see what's happening, at least that was my thinking.
In D8075#150909, @fvogt wrote:In D8075#150908, @cfeck wrote:... But, the docs (both 5.10 and dev) doesn't say the constructor is explicit ... hm
Might be worth a bug report.
Sep 29 2017
Sep 29 2017
Before disabling it altogether on Android, I'd prefer to look into why it's not working. Give me a week, please?
Sep 28 2017
Sep 28 2017
LGTM
Sep 27 2017
Sep 27 2017
apol committed R256:45d5858d6981: Make an application out of the kirigamigallery (authored by apol).
Make an application out of the kirigamigallery
apol committed R169:8e692314428d: Generate the appstream metadata of the gallery app (authored by apol).
Generate the appstream metadata of the gallery app
apol committed R169:ef156a238298: Look for QtGraphicalEffects, so packagers don't forget it (authored by apol).
Look for QtGraphicalEffects, so packagers don't forget it
apol committed R169:190c6dd15054: Don't include the control over the bottom decoration (authored by apol).
Don't include the control over the bottom decoration
It certainly makes a difference. Please make sure you're not testing against the one in the distro.
Right path
+1 lgtm
I'm unsure about this one. Could it become a security liability?
Having 1 of the systems compromised on the network will escalate on every device very easily with this...
Sep 25 2017
Sep 25 2017
apol committed R134:2c5f7ac09bd5: Make sure the application name doesn't overflow (authored by apol).
Make sure the application name doesn't overflow
Sep 24 2017
Sep 24 2017
I don't really see how this needs review. :)
Sep 23 2017
Sep 23 2017
apol requested changes to D7950: Document how to determine which optional dependencies are used (e.g. QtWebKit instead of QtWebEngine.
This is not necessary: see here.
Sep 21 2017
Sep 21 2017
Which part of the system doesn't work if there are symlinks?
This is the wrong fix, let me look into fixing it in Kirigami.
Thanks! this bothered me in the past :)
It's very similar to the patch I pushed: 667891df61d4f90e20692d59b9bfc7c1ba8bd6b1
Where's the attempt? Maybe I can look into it.