Differential D8058

don't redefine output dirs on android
AbandonedPublic
Actions

Authored by apol on Sep 29 2017, 2:29 PM.

Details

Reviewers
dfaure
mart
Group Reviewers
Frameworks
Summary

on Android the output directories need to stay default
or it breaks packaging with make create-apk-target

Test Plan

now apps apk get generated again

Diff Detail

Repository
R240 Extra CMake Modules
Branch
androidbin
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Sep 29 2017, 2:29 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptSep 29 2017, 2:29 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
apol added a comment.Sep 29 2017, 3:36 PM

Before disabling it altogether on Android, I'd prefer to look into why it's not working. Give me a week, please?

If you still want it in, maybe a solution would be to have instead something like:

option(CENTRALIZED_BINARIES "puts all binaries on bindir/lib and bindir/bin" ON)
mart added a comment.Oct 2 2017, 9:27 AM
In D8058#150551, @apol wrote:

Before disabling it altogether on Android, I'd prefer to look into why it's not working. Give me a week, please?

sure :)

apol commandeered this revision.Mar 27 2018, 11:11 PM
apol edited reviewers, added: mart; removed: apol.

Fix already got merged.

apol abandoned this revision.Mar 27 2018, 11:11 PM

Revision Contents
Changeset List

PathPackages
Mkde-modules/KDECMakeSettings.cmake (10 lines)

Diff 20093

View Options

kde-modules/KDECMakeSettings.cmake

Loading...