Differential D8222

Pass missing arguments to cmake
ClosedPublic
Actions

Authored by apol on Oct 9 2017, 3:36 PM.

Details

Reviewers
bcooksley
Group Reviewers
Sysadmin
Summary

Now there's an ECM version coming from the SDK image, this way we don't
have the ECM bootstrapping problem.
Also we need to set some prefixes to look into.

Test Plan

I don't know how to test. Also I suspect that the if condition
is wrong because its effects can't be seen in the issued cmake here:
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/1/console

Diff Detail

Repository
R857 CI System Tooling
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Oct 9 2017, 3:36 PM
bcooksley added a comment.Oct 9 2017, 6:46 PM

I agree the if condition is likely not working (which is weird because it should be - those variables are set on normal login)

I'll dig into this further and see if I can fix that.

bcooksley accepted this revision.Oct 11 2017, 9:16 AM

This can be closed now I think as a variant of this was committed?

This revision is now accepted and ready to land.Oct 11 2017, 9:16 AM
apol closed this revision.Oct 11 2017, 2:33 PM

Revision Contents
Changeset List

PathPackages
Mhelpers/helperslib/BuildSystem.py (3 lines)

Diff 20521

View Options

helpers/helperslib/BuildSystem.py

Loading...