Differential D7913

Don't include the control over the bottom decoration
ClosedPublic
Actions

Authored by apol on Sep 21 2017, 1:12 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:190c6dd15054: Don't include the control over the bottom decoration
Summary

BUG: 384913

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Sep 21 2017, 1:12 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptSep 21 2017, 1:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 27 2017, 2:33 PM
This revision is now accepted and ready to land.Sep 27 2017, 2:33 PM
ngraham requested changes to this revision.Sep 27 2017, 2:45 PM
ngraham added a subscriber: ngraham.

I tested this and it didn't actually fix 384913. There was no change when I recompiled Discover against a patched Kirigami.

This revision now requires changes to proceed.Sep 27 2017, 2:45 PM
apol added a comment.Sep 27 2017, 3:19 PM

It certainly makes a difference. Please make sure you're not testing against the one in the distro.

Before:

After:

Closed by commit R169:190c6dd15054: Don't include the control over the bottom decoration (authored by apol). · Explain WhySep 27 2017, 3:20 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Sep 27 2017, 3:22 PM

Oh okay. Wonder what I did wrong. Will investigate.

Revision Contents
Changeset List

PathPackages
Msrc/controls/ItemViewHeader.qml (9 lines)

Diff 19995

View Options

src/controls/ItemViewHeader.qml

Loading...