zhigalin (Alexander Zhigalin)
Engineering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 18 2015, 12:31 PM (161 w, 3 d)
Availability
Available

Recent Activity

Fri, Nov 16

zhigalin added a comment to D16758: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring large files..

+1, This seems to be the motivation because my transfers fail if the connection is not 100% perfect.

Fri, Nov 16, 11:19 AM · KDE Connect

Jul 31 2018

zhigalin added a comment to D13580: Add support for Generators..

I rebased this against master and found it has the same problem as D13547, i.e. it introduces 10 first/follow conflicts :/
Not sure it's worth trying to solve it here either.

Jul 31 2018, 9:22 AM · KDevelop

Jul 29 2018

zhigalin accepted D13580: Add support for Generators..

Hello.
Sorry for the late reply, I haven't noticed when this review was created

This adds support for generators and generator delegation

Jul 29 2018, 1:09 AM · KDevelop

Jun 14 2018

zhigalin updated the task description for T6804: PHP 7.2 features.
Jun 14 2018, 8:21 AM · KDevelop

May 28 2018

zhigalin accepted D11785: Add kcolorschemechooser support and related setting menu entry.

Indeed, maybe this class should be part of the KConfigWidgets framework? See https://api.kde.org/frameworks/kconfigwidgets/html/annotated.html for current list of classes - it already contains the color scheme stuff and is a tier3 framework (so many dependencies allowed).

@zhigalin Any comments from your side?

May 28 2018, 5:46 PM · Kate

May 18 2018

zhigalin committed R67:42a8eeb75de6: Don't force a maximum length for hostname in the settings (authored by zhigalin).
Don't force a maximum length for hostname in the settings
May 18 2018, 6:08 AM

Mar 17 2018

zhigalin added a comment to D7992: Add systemvolume plugin.

Don't know if this will help but I use two combined plasmoids to achieve this nice effect:


The firs one controls the default sink while the second one change it's volume.

Mar 17 2018, 10:39 AM · KDE Connect

Jan 30 2018

zhigalin committed R67:f215abcf7461: Fixed launch url composition from launch configuration server, path and… (authored by Santiago Capel Torres <santi@holamundo.me>).
Fixed launch url composition from launch configuration server, path and…
Jan 30 2018, 12:15 PM
zhigalin closed D8569: Fixed launch url composition from launch configuration server, path and arguments.
Jan 30 2018, 12:15 PM

Jan 28 2018

zhigalin updated the task description for T6804: PHP 7.2 features.
Jan 28 2018, 2:35 PM · KDevelop

Nov 8 2017

zhigalin accepted D8569: Fixed launch url composition from launch configuration server, path and arguments.

@santilin
I would like to merge it, including schema defaulting to http:// as I have proposed,
any objections?

Nov 8 2017, 7:40 AM

Nov 5 2017

zhigalin added a comment to D8569: Fixed launch url composition from launch configuration server, path and arguments.

@santilin It seems you did a duplicate here, please close D8555

Nov 5 2017, 9:44 AM

Nov 3 2017

zhigalin added inline comments to D8569: Fixed launch url composition from launch configuration server, path and arguments.
Nov 3 2017, 3:14 PM

Oct 9 2017

zhigalin committed R32:83062368f0d4: Added support for STRINGS property in CMake cache editor (authored by gracicot).
Added support for STRINGS property in CMake cache editor
Oct 9 2017, 6:32 PM
zhigalin closed D8215: Added support for STRINGS property in CMake cache editor.
Oct 9 2017, 6:32 PM
zhigalin added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.

@bcooksley Any news?
I didn't noticed that because I was on the KDevelop mailing list and I was receiving replies from it but it seems that I have never received any mail from phabricator...

Oct 9 2017, 6:09 PM

Oct 4 2017

zhigalin abandoned D8088: Do not display URLHandler device selection dialog if there is only one device connected.

@apol You're right, wasn't thinking that way...

Oct 4 2017, 4:42 PM
zhigalin added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.

I've taken an initial look at that and can confirm the issue, although not why it is occurring and have reached out to the Phabricator developers.

Oct 4 2017, 10:20 AM
zhigalin added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.

@bcooksley when I visit email settings page https://phabricator.kde.org/settings/user/zhigalin/page/email/ I see only this error:

Oct 4 2017, 9:25 AM
zhigalin added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.

The creator of a review is an implicit subscriber from my understanding of how Phabricator works here.

Oct 4 2017, 9:22 AM
zhigalin updated subscribers of D8088: Do not display URLHandler device selection dialog if there is only one device connected.

@bcooksley Why I am not automatically subscribed to a review I have created?

Oct 4 2017, 7:53 AM
zhigalin added a comment to D8088: Do not display URLHandler device selection dialog if there is only one device connected.
In D8088#151644, @apol wrote:

I think it's good to show the dialog if there's just the one device. This way you see what's happening, at least that was my thinking.

Oct 4 2017, 6:40 AM

Oct 1 2017

zhigalin created D8088: Do not display URLHandler device selection dialog if there is only one device connected.
Oct 1 2017, 2:16 PM

Sep 30 2017

zhigalin committed R32:c14a89d872db: Add paste external script (authored by zhigalin).
Add paste external script
Sep 30 2017, 9:29 AM
zhigalin closed D7863: Add paste external script.
Sep 30 2017, 9:29 AM
zhigalin updated the diff for D7863: Add paste external script.

Remove scripts on windows

Sep 30 2017, 7:33 AM
zhigalin planned changes to D7863: Add paste external script.
In D7863#147030, @kfunk wrote:

b) Limits this feature to hastebin.com

Why hastebin?
Two reasons:

  1. Don't require a client, a single shell command is enough
  2. It's open source! So It isn't really limited to hastebin.com, anyone could set up his own hastebin instance...
Sep 30 2017, 7:19 AM

Sep 29 2017

zhigalin committed R67:3004af4f0f1a: Server defaults to localhost (authored by zhigalin).
Server defaults to localhost
Sep 29 2017, 12:11 PM
zhigalin committed R67:ba647b8c400b: Slight UI improvement (authored by zhigalin).
Slight UI improvement
Sep 29 2017, 11:39 AM
zhigalin committed R67:ce54f416de1d: Fix crash (authored by zhigalin).
Fix crash
Sep 29 2017, 11:39 AM

Sep 20 2017

zhigalin added a comment to D7863: Add paste external script.

Ping

Sep 20 2017, 6:30 AM

Sep 17 2017

zhigalin created D7863: Add paste external script.
Sep 17 2017, 5:42 PM
zhigalin updated subscribers of D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.

Rest LGTM, do you have commit rights?

Sep 17 2017, 4:31 PM · Dolphin

Sep 16 2017

zhigalin added inline comments to D7847: Don't block unmounting when terminal panel's cwd is the mountpoint.
Sep 16 2017, 3:56 PM · Dolphin

Sep 8 2017

zhigalin added a comment to D7018: Allow optional parameters before non-optional ones in PHP.

Sorry, had no time lately

Sep 8 2017, 6:13 AM

Sep 7 2017

zhigalin committed R52:4b10347f367c: Allow optional parameters before non-optional ones in PHP (authored by mtijink).
Allow optional parameters before non-optional ones in PHP
Sep 7 2017, 6:39 PM
zhigalin closed D7018: Allow optional parameters before non-optional ones in PHP by committing R52:4b10347f367c: Allow optional parameters before non-optional ones in PHP (authored by mtijink).
Sep 7 2017, 6:39 PM

Aug 21 2017

zhigalin added a comment to D7018: Allow optional parameters before non-optional ones in PHP.

function foo($a, $b = false, $c) {}
Should work?
Now it says that $c should have a default...

Aug 21 2017, 7:17 PM
zhigalin committed R32:7e7cdcfd8089: Handle empty default arguments correctly (authored by mtijink).
Handle empty default arguments correctly
Aug 21 2017, 7:08 PM
zhigalin closed D7031: Handle empty default arguments correctly by committing R32:7e7cdcfd8089: Handle empty default arguments correctly (authored by mtijink).
Aug 21 2017, 7:08 PM

Aug 18 2017

zhigalin updated the task description for T6803: PHP 7.1 features.
Aug 18 2017, 5:44 PM · KDevelop
zhigalin updated the task description for T6809: PHP 7.0 features.
Aug 18 2017, 5:44 PM · KDevelop
zhigalin updated the task description for T6817: PHP 5.4 features.
Aug 18 2017, 5:44 PM · KDevelop
zhigalin created T6817: PHP 5.4 features.
Aug 18 2017, 4:19 PM · KDevelop
zhigalin updated the task description for T6809: PHP 7.0 features.
Aug 18 2017, 3:31 PM · KDevelop
zhigalin created T6816: PHP 5.5 features.
Aug 18 2017, 3:30 PM · KDevelop

Aug 17 2017

zhigalin created T6810: PHP 5.6 features.
Aug 17 2017, 5:25 PM · KDevelop
zhigalin updated the task description for T6804: PHP 7.2 features.
Aug 17 2017, 4:57 PM · KDevelop
zhigalin created T6809: PHP 7.0 features.
Aug 17 2017, 4:57 PM · KDevelop
zhigalin committed R32:3916d87d728a: GitHub Two Factor Authentication (authored by zhigalin).
GitHub Two Factor Authentication
Aug 17 2017, 1:47 PM
zhigalin closed D2621: GitHub Two Factor Authentication by committing R32:3916d87d728a: GitHub Two Factor Authentication.
Aug 17 2017, 1:47 PM

Aug 16 2017

zhigalin created T6804: PHP 7.2 features.
Aug 16 2017, 1:28 PM · KDevelop
zhigalin created T6803: PHP 7.1 features.
Aug 16 2017, 1:28 PM · KDevelop

Aug 8 2017

zhigalin committed R32:a8f3ba3d6c62: Added some alt-shortcuts for context menu in ProjectManagerView (authored by zhigalin).
Added some alt-shortcuts for context menu in ProjectManagerView
Aug 8 2017, 5:11 PM
zhigalin committed R32:aa56f1bfaa23: Use https://www.google.com instead of http://www.google.de in google selection… (authored by geetamc).
Use https://www.google.com instead of http://www.google.de in google selection…
Aug 8 2017, 5:11 PM
zhigalin committed R32:4a96a875c97f: Added some alt-shortcuts for context menu in ProjectManagerView (authored by zhigalin).
Added some alt-shortcuts for context menu in ProjectManagerView
Aug 8 2017, 5:11 PM

Aug 3 2017

zhigalin added a comment to T6049: package wacomtablet.

Hello
I should note that

Aug 3 2017, 7:21 AM · Neon

Aug 2 2017

zhigalin committed R52:bfc97e1e0f5f: Add callable type to PHP (authored by mtijink).
Add callable type to PHP
Aug 2 2017, 9:13 AM
zhigalin closed D7034: Add callable type to PHP by committing R52:bfc97e1e0f5f: Add callable type to PHP (authored by mtijink).
Aug 2 2017, 9:13 AM
zhigalin accepted D7034: Add callable type to PHP.
Aug 2 2017, 9:11 AM
zhigalin updated the diff for D2621: GitHub Two Factor Authentication.

Update

Aug 2 2017, 8:57 AM
zhigalin planned changes to D2621: GitHub Two Factor Authentication.
Aug 2 2017, 8:52 AM
zhigalin added a reviewer for D7031: Handle empty default arguments correctly: kfunk.

Way better then the previous hack.
@kfunk?

Aug 2 2017, 8:38 AM

Aug 1 2017

zhigalin added inline comments to D7034: Add callable type to PHP.
Aug 1 2017, 9:47 PM
zhigalin requested changes to D7034: Add callable type to PHP.

Rest LGTM

Aug 1 2017, 6:24 PM
zhigalin updated the diff for D2621: GitHub Two Factor Authentication.

New version

Aug 1 2017, 2:39 PM
zhigalin added inline comments to D2621: GitHub Two Factor Authentication.
Aug 1 2017, 2:34 PM
zhigalin commandeered D2621: GitHub Two Factor Authentication.
Aug 1 2017, 1:09 PM

Jul 31 2017

zhigalin committed R185:35d8a61fed46: Fix build (authored by zhigalin).
Fix build
Jul 31 2017, 1:27 PM

Jul 26 2017

zhigalin committed R52:ac25815f77bb: Process member properties/calls for unsure types in PHP (authored by mtijink).
Process member properties/calls for unsure types in PHP
Jul 26 2017, 6:07 PM
zhigalin closed D6923: Process member properties/calls for unsure types in PHP by committing R52:ac25815f77bb: Process member properties/calls for unsure types in PHP (authored by mtijink).
Jul 26 2017, 6:07 PM · KDevelop
zhigalin committed R52:9730beeb1eaa: Use null default types for determining argument type in PHP (authored by mtijink).
Use null default types for determining argument type in PHP
Jul 26 2017, 5:50 PM
zhigalin closed D6915: Use null default types for determining argument type in PHP by committing R52:9730beeb1eaa: Use null default types for determining argument type in PHP (authored by mtijink).
Jul 26 2017, 5:50 PM · KDevelop
zhigalin committed R52:2c863b8a3071: Fix uses of class in closure parameters and default values for functions (authored by mtijink).
Fix uses of class in closure parameters and default values for functions
Jul 26 2017, 5:17 PM
zhigalin closed D6690: Fix uses of class in closure parameters and default values for functions by committing R52:2c863b8a3071: Fix uses of class in closure parameters and default values for functions (authored by mtijink).
Jul 26 2017, 5:17 PM · KDevelop
zhigalin accepted D6690: Fix uses of class in closure parameters and default values for functions.

Perfect, thanks

Jul 26 2017, 5:15 PM · KDevelop
zhigalin committed R52:8862dde3b4ee: Fix bug 381123: crash while parsing PHP code (authored by mtijink).
Fix bug 381123: crash while parsing PHP code
Jul 26 2017, 4:47 PM
zhigalin closed D6837: Fix bug 381123: crash while parsing PHP code by committing R52:8862dde3b4ee: Fix bug 381123: crash while parsing PHP code (authored by mtijink).
Jul 26 2017, 4:47 PM · KDevelop
zhigalin abandoned D6807: Fix segmentation fault caused by certain files.
Jul 26 2017, 4:38 PM
zhigalin accepted D6837: Fix bug 381123: crash while parsing PHP code.
Jul 26 2017, 4:37 PM · KDevelop

Jul 23 2017

zhigalin requested changes to D6837: Fix bug 381123: crash while parsing PHP code.

Cool! Seems we were working on the same issue
As mentioned by @apol and @kfunk a test is needed.

Jul 23 2017, 10:17 AM · KDevelop

Jul 21 2017

zhigalin added a comment to D6807: Fix segmentation fault caused by certain files.
In D6807#127164, @apol wrote:

Maybe you could add a unit test?

Jul 21 2017, 2:07 PM
zhigalin created D6807: Fix segmentation fault caused by certain files.
Jul 21 2017, 10:38 AM

Jul 18 2017

zhigalin requested changes to D6690: Fix uses of class in closure parameters and default values for functions.
Jul 18 2017, 8:48 AM · KDevelop

Jul 17 2017

zhigalin committed R52:1b9bbdb7ff55: Use return typehints in typebuilder for PHP language (authored by mtijink).
Use return typehints in typebuilder for PHP language
Jul 17 2017, 8:28 AM
zhigalin closed D6680: Use return typehints in typebuilder for PHP language by committing R52:1b9bbdb7ff55: Use return typehints in typebuilder for PHP language (authored by mtijink).
Jul 17 2017, 8:28 AM · KDevelop
zhigalin accepted D6680: Use return typehints in typebuilder for PHP language.

Good one, pushing it right now...

Jul 17 2017, 8:27 AM · KDevelop
zhigalin committed R52:cdd1a8e8a950: Mark return types as uses for PHP language (authored by mtijink).
Mark return types as uses for PHP language
Jul 17 2017, 8:19 AM
zhigalin closed D6675: Mark return types as uses for PHP language by committing R52:cdd1a8e8a950: Mark return types as uses for PHP language (authored by mtijink).
Jul 17 2017, 8:19 AM · KDevelop
zhigalin accepted D6675: Mark return types as uses for PHP language.

Nice one, thanks

Jul 17 2017, 8:11 AM · KDevelop
zhigalin committed R52:3a8ad5cc279b: Allow non-scalar constants in PHP language support (authored by mtijink).
Allow non-scalar constants in PHP language support
Jul 17 2017, 7:58 AM
zhigalin closed D6670: Allow non-scalar constants in PHP language support by committing R52:3a8ad5cc279b: Allow non-scalar constants in PHP language support (authored by mtijink).
Jul 17 2017, 7:57 AM · KDevelop
zhigalin accepted D6670: Allow non-scalar constants in PHP language support.

Looks good, thanks for your work!

Jul 17 2017, 7:56 AM · KDevelop

Jul 13 2017

zhigalin committed R52:8da5db996bf9: Add spaceship and null coalesce operators to PHP language support (authored by mtijink).
Add spaceship and null coalesce operators to PHP language support
Jul 13 2017, 6:29 AM
zhigalin closed D6645: Add spaceship and null coalesce operators to PHP language support by committing R52:8da5db996bf9: Add spaceship and null coalesce operators to PHP language support (authored by mtijink).
Jul 13 2017, 6:29 AM · KDevelop
zhigalin committed R52:dad970d96bee: Better support iterable typehint in PHP language (authored by mtijink).
Better support iterable typehint in PHP language
Jul 13 2017, 6:28 AM
zhigalin closed D6644: Better support iterable typehint in PHP language by committing R52:dad970d96bee: Better support iterable typehint in PHP language (authored by mtijink).
Jul 13 2017, 6:28 AM · KDevelop
zhigalin committed R52:68f07d3a0098: Add return typehint support for PHP language (authored by mtijink).
Add return typehint support for PHP language
Jul 13 2017, 6:28 AM
zhigalin closed D6643: Add return typehint support for PHP language by committing R52:68f07d3a0098: Add return typehint support for PHP language (authored by mtijink).
Jul 13 2017, 6:28 AM · KDevelop

Jul 12 2017

zhigalin accepted D6643: Add return typehint support for PHP language.

This seems also OK

Jul 12 2017, 9:55 PM · KDevelop