Differential D8111

Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick
ClosedPublic
Actions

Authored by leinir on Oct 2 2017, 1:56 PM.

Details

Reviewers
mart
apol
Group Reviewers
KNewStuff
Commits
R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick
Summary

This reduces the amount of things which require the by now quite out of date Kirigami 1.0 further. This also introduces a find clause to the CMakeLists.txt (a runtime find, so we should get no issues as it's informational rather than a hard require). Preparatory work for extending the KNewStuff Qt Quick components in the near future.

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Oct 2 2017, 1:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 2 2017, 1:56 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bshah added a subscriber: bshah.Oct 2 2017, 1:57 PM

+1, looks good to me.

mart accepted this revision.Oct 2 2017, 2:06 PM
This revision is now accepted and ready to land.Oct 2 2017, 2:06 PM
apol accepted this revision.Oct 2 2017, 2:44 PM
apol added a subscriber: apol.

Kirigami 1.0 isn't supported anyway, so it's indeed needed.

Maybe it would be nice to have some tests on this code to make sure everything keeps working.

Closed by commit R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick (authored by leinir). · Explain WhyOct 2 2017, 2:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
Msrc/qtquick/qml/NewStuffItem.qml (3 lines)

Diff 20251

View Options

CMakeLists.txt

Loading...
View Options

src/qtquick/qml/NewStuffItem.qml

Loading...