Drop hardcoded IdealButtonBar spacing, use QStyle::PM_ToolBarItemSpacing
ClosedPublic
Actions

Authored by kossebau on Sep 28 2017, 2:51 PM.

Details

Reviewers

apol

Group Reviewers

KDevelop

Commits

Summary

For more consistent look and saving a few vertical pixels with common styles

Also:

drop IDEAL_LAYOUT_MARGIN and use 0 directly as elsewhere, no use for keeping this a separate #define
for bottom button bar with right corner widget, use normal style spacing between corner widget and buttons

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

LGTM

This revision is now accepted and ready to land.Sep 28 2017, 2:55 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kdevplatform/sublime/idealbuttonbarwidget.cpp (2 lines)
M			kdevplatform/sublime/ideallayout.h (5 lines)
M			kdevplatform/sublime/ideallayout.cpp (34 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20041	a61dcf6		Sep 28 2017, 2:51 PM	★	★
Diff 2	20043	fe4d438	R32:4b37d8dc50528714466c2ec79c685dcad9452c3b	Sep 28 2017, 3:24 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ae5aaec1700e	3ea90c6f2fcf	a61dcf62709e	Friedrich W. H. Kossebau	Drop hardcoded IdealButtonBar spacing, use QStyle::PM_ToolBarItemSpacing (Show More…)	Sep 28 2017, 2:48 PM