Differential D8115

Port KAccess away from kdelibs4support
ClosedPublic
Actions

Authored by apol on Oct 2 2017, 4:20 PM.

Tags

Subscribers

davidedmundson, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R119:1ded47814a61: Port KAccess away from kdelibs4support

Test Plan

Executed it locally, can start and stop orca

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Oct 2 2017, 4:20 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 2 2017, 4:20 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nice

kaccess/kaccess.cpp
722	we've effectively removed this connect to dialogClosed. Now closing goes to noClicked. Is this a problem?

apol added inline comments.Oct 2 2017, 11:45 PM

kaccess/kaccess.cpp
722	I noticed. I'm not sure to be honest. My thinking is that the user shouldn't notice the difference between saying "No" and closing the window. I can short-circuit the QDialogButtonBox::rejected if that makes you feel more comfortable with the patch. :)

davidedmundson accepted this revision.Oct 10 2017, 11:17 AM

davidedmundson added inline comments.

kaccess/main.cpp
91	?

This revision is now accepted and ready to land.Oct 10 2017, 11:17 AM

Remove comment

Fix

Closed by commit R119:1ded47814a61: Port KAccess away from kdelibs4support (authored by apol). · Explain WhyOct 15 2017, 11:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kaccess/CMakeLists.txt (6 lines)
M			kaccess/kaccess.h (13 lines)
M			kaccess/kaccess.cpp (90 lines)
M			kaccess/main.cpp (48 lines)

Diff 20783

kaccess/CMakeLists.txt

Loading...

kaccess/kaccess.h

Loading...

kaccess/kaccess.cpp

Loading...

kaccess/main.cpp

Loading...