Optional Migration Code for KF5

Authored by narvaez on Oct 9 2017, 4:35 PM.



This is long overdue and the fact that it has not caused more trouble in
bugzilla means it is probably a non-issue, but just to be complete,
here's code that migrates the old configuration to the new directories.

BUG: 353729

Test Plan

Delete the kigrc config file, and the kig/kig-types/macros.kigt files if you have them.
Run the application.
Run it with existing kig/kig-types/macros.kigt too to make sure it does not delete the files.

Diff Detail

R331 Kig
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
narvaez created this revision.Oct 9 2017, 4:35 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 9 2017, 4:35 PM
apol added a subscriber: apol.Oct 9 2017, 10:51 PM
apol added inline comments.

Why not required? It's probably pulled by some other dep anyway (xmlgui for instance)

narvaez added inline comments.Oct 10 2017, 7:14 AM

Yes, good point. I'll update the diff.

narvaez updated this revision to Diff 20549.Oct 10 2017, 7:21 AM
  • Making the Dependency to KF5CoreAddons REQUIRED
apol added inline comments.Oct 10 2017, 10:31 AM
4 ↗(On Diff #20549)

If it's required this is not needed anymore.

narvaez updated this revision to Diff 20569.Oct 10 2017, 3:00 PM
  • Since KCoreAddons is required, the migration is not optional
cfeck added a subscriber: cfeck.Oct 21 2017, 12:44 PM
cfeck added inline comments.

You can remove this call, since people will always have CoreAddons, if they also have the other KF5 dependencies.

narvaez updated this revision to Diff 21050.Oct 21 2017, 12:51 PM
  • Also remove the set_package_properties code, since it is not optional
apol accepted this revision.Oct 22 2017, 10:55 PM



You can mark this and dataMigration as static.

This revision is now accepted and ready to land.Oct 22 2017, 10:55 PM
narvaez marked an inline comment as done.Oct 22 2017, 11:30 PM
This revision was automatically updated to reflect the committed changes.