Put it in the root, todo/ stuff isn't built, it's for things that don't build.

Yes, default branch is master.

In D7273#138099, @graesslin wrote:

ping, anything speaking against pushing it?

Why?

Won't hurt, benefits from some compiler checking so it's better.

Seems good to me, I'm unsure how useful the script will be, I guess it can't hurt. Haven't tried it though.

I tested the patch, for me it worked for all but VirtualKeyboard (which might be indeed missing).

Ugh my bad ^^', I don't know what happened.

I was thinking: should I wait for a month so that ECM has been released with it maybe? Otherwise it will be a hard dependency and people won't be able to use the master branch...

In D7253#134653, @elvisangelaccio wrote:

Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone).
One usually already has a build folder around, so the idea is you change some code, build it as usual and then you run this target to quickly test the change in flatpak.

Figured out:
https://commits.kde.org/flatpak-kde-runtime/d016215d753b6178fe615f92263eb4d693ef204a

Right, so this means konsole has to make this desktop file visible to the dolphin part, which at the moment it isn't. We should figure it out.

Interesting feature.

Who installs konsolehere.desktop?

Included libcurl: https://commits.kde.org/flatpak-kde-applications/fe4e0b49001d46c26dd1246cc2376d80caaffe5f

LGTM

In D7192#134257, @jeanv wrote:

In D7192#134232, @apol wrote:

Please see https://phabricator.kde.org/D7224

I see what you mean. Your solution does seem better.

Where are we using libcurl? Would it make sense to build it separately in Kube's flatpak manifest?

What does the ark plugin do? Does it need ark code? If not maybe it could be moved into dolphin-plugins.

Please see https://phabricator.kde.org/D7224

Should we move (some of) this into kdevplatform/interfaces?

The advantage of using BUILD_INTEFACE is that you're setting the paths depending on what you're linking against rather than depending on where they are located which is essentially arbitrary.

To me it sounds like the issue you are trying to solve is elsewhere.

if that makes you happy, it makes me happy.
+1

Use the macro in ECM now

if no qmlplugindump

Address sitter's comments