Fix accepting dialogs with ctrl+return when buttons are renamed
ClosedPublic
Actions

Authored by apol on Aug 8 2017, 1:54 AM.

Details

Reviewers

dfaure

Group Reviewers

Frameworks

Commits

Summary

QAbstractButton::setText will call setShortcut(mnemonic), making this
little hack unusable.
This patch puts the shortcut into a separate object.

Test Plan

Improved the test to reproduce the issue I had
Now we can use it with KDE Connect send reply dialogs

Repository

R252 Framework Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Make sure there's such a button

This revision is now accepted and ready to land.Aug 9 2017, 8:14 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kstyle/kstyle.cpp (7 lines)
M			tests/kstyletest.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17860	81f8226		Aug 8 2017, 1:54 AM	★	★
Diff 2	17862	81f8226	Make sure there's such a button	Aug 8 2017, 2:00 AM	★	★
Diff 3	17921	cee18ca	R252:7524bf1535b448edc0d432ebcb53adf245b8e2b8	Aug 9 2017, 10:26 AM	★	★