Detach before setting the d pointer
ClosedPublic

Authored by apol on Aug 7 2017, 4:32 PM.

Details

Summary

Otherwise some objects have their information changed even though they
weren't modified

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Aug 7 2017, 4:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 7 2017, 4:32 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik added a subscriber: broulik.Aug 7 2017, 8:36 PM
broulik added inline comments.
src/core/entryinternal.cpp
170

Detach here also

apol updated this revision to Diff 17863.Aug 8 2017, 2:01 AM

Add missing detach()

leinir accepted this revision.Wed, Aug 23, 8:03 AM

Ah, yes, good catch :)

This revision is now accepted and ready to land.Wed, Aug 23, 8:03 AM
This revision was automatically updated to reflect the committed changes.