Use the new ECMQMLModules to specify all of KWin's runtime dependencies
AcceptedPublic

Authored by graesslin on Aug 12 2017, 12:08 PM.

Details

Reviewers
bshah
Group Reviewers
KWin
Plasma

Diff Detail

Repository
R108 KWin
Branch
ecmqmlmodules
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Aug 12 2017, 12:08 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 12 2017, 12:08 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

@apol any idea why several of the packages are reported not found?

-- The following RUNTIME packages have not been found:

 * QtQuick.Controls-QMLModule , QML module 'QtQuick.Controls' is a runtime dependency.
 * QtQuick.VirtualKeyboard-QMLModule , QML module 'QtQuick.VirtualKeyboard' is a runtime dependency.
 * org.kde.plasma.core-QMLModule , QML module 'org.kde.plasma.core' is a runtime dependency.
 * org.kde.plasma.components-QMLModule , QML module 'org.kde.plasma.components' is a runtime dependency.
bshah added a subscriber: bshah.EditedAug 12 2017, 12:15 PM

@apol any idea why several of the packages are reported not found?

Please try to run qmlplguindump QtQuick.Controls 1.2 for instance and paste it's output here.

EDIT: just check it's return value, output might be too huge.

In D7273#134905, @bshah wrote:

@apol any idea why several of the packages are reported not found?

Please try to run qmlplguindump QtQuick.Controls 1.2 for instance and paste it's output here.

I get: QQmlComponent: Component is not ready

I'm on neon dev/unstable for the record

apol added a comment.Aug 13 2017, 5:44 PM

I tested the patch, for me it worked for all but VirtualKeyboard (which might be indeed missing).

I'd suggest to look into why your qmlplugindump isn't returning what it should

ping, anything speaking against pushing it?

bshah accepted this revision as: Plasma, bshah.Aug 21 2017, 9:36 AM
This revision is now accepted and ready to land.Aug 21 2017, 9:36 AM
apol added a comment.Sep 4 2017, 9:53 AM

ping, anything speaking against pushing it?

Push? :)

In D7273#142926, @apol wrote:

ping, anything speaking against pushing it?

Push? :)

I think we first need to get D7543 in, to be able to depend from the ECM version.

apol added a comment.Sep 5 2017, 5:42 PM

I think we first need to get D7543 in, to be able to depend from the ECM version.

I don't see how it's related

In D7273#143252, @apol wrote:

I think we first need to get D7543 in, to be able to depend from the ECM version.

I don't see how it's related

ECMFindQMLModule is only available in ECM 5.38 if I see it correctly. Thus I need to request that version and that means the build structure changes and KWin needs the adjustments to make the autotests still work, which is D7543 - without that the autotests fail if ECM 5.38 is requested.