Differential D7058

Initialize the "Pause" button state in the widget tracker
ClosedPublic
Actions

Authored by apol on Aug 1 2017, 11:52 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R288:35b442449166: Initialize the "Pause" button state in the widget tracker
Summary

Check the capabilities and if it can't be suspended, don't even
show the button

Test Plan

Albert sent me several files over kdeconnect

Diff Detail

Repository
R288 KJobWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Aug 1 2017, 11:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 1 2017, 11:52 PM
aacid added a subscriber: aacid.Aug 2 2017, 9:21 PM

Did you actually try any suspendable job to make sure it still works in that case? (i assume kdeconnect jobs are not suspendable?)

apol added a comment.Aug 3 2017, 2:29 PM

I just tried now. It works. 👍

dfaure accepted this revision.Aug 9 2017, 7:42 AM
This revision is now accepted and ready to land.Aug 9 2017, 7:42 AM
Closed by commit R288:35b442449166: Initialize the "Pause" button state in the widget tracker (authored by apol). · Explain WhyAug 9 2017, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kwidgetjobtracker.cpp (1 line)

Diff 17920

View Options

src/kwidgetjobtracker.cpp

Loading...