Bah, I patched the wrong kapidox on the server, so last nights run still failed. Oh well... not sure I will have time in the evening for processing this patch, but at least now getting the diff applied also on the right kapidox, so next server check tomorrow.

I just applied the diff as-is to the working checkout of kapidox on the server, to see if the patch also works for the setup of the nightly run, other than my separate testing which might have missed any special environment setup. So tomorrow before noon CEST we should have proof this patch catches all issues.
So no immediate pressure to get this patch out ASAP to also get api.kde.org running again :)

In D29797#672263, @kossebau wrote:

Thanks for the (first) review :)

Open questions I have are these:
a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml

In D29797#672263, @kossebau wrote:

Thanks for the (first) review :)

Open questions I have are these:
a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml
b) by supposedly breaking support for Python 2, how to properly catch any usage of python2 now?

Thanks for the (first) review :)

+1 and also +1 for removing python2 support

• Fix arc going crazy

• Address review comments

Thank you!

Done :)

• Renaming of functions

Actually sorry, I have a few more comments before I think this can land:

Thanks!

In D29006#671172, @ngraham wrote:

Nice feature. I would rename the menu items a bit:
"Move to inactive split view"
"Copy to inactive split view"

No need to mention "the selection" because it's implicit. And I would mention that this is about the split view, or else when not using the split view feature, it's not clear how to enable the menu items. If you mention splits in the name though, it's advertising the split view feature for whose who haven't found it yet.

• Minor renaming of text and the according variables
• Merge remote-tracking branch 'origin' into arcpatch-D29006

Nice feature. I would rename the menu items a bit:
"Move to inactive split view"
"Copy to inactive split view"

In D29006#670660, @meven wrote:

Rather than merging master into your branches, I would recommend you rebasing ;)

Rather than merging master into your branches, I would recommend you rebasing ;)

• Fix broken patch

• Update messagelib dependency

Alright! Ship it

In D29667#669622, @ochurlaud wrote:

Don't use file as a variable name as it's a python keyword.

Don't use file as a variable name as it's a python keyword.

• Renamed to destinationUrl

• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006
• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006
• Rename to (copy|move)SelectedItems

Dump output information as well

In D29006#667654, @meven wrote:

In D29006#667588, @dfaure wrote:

It sounds to me like you found bugs in some kioslaves. Fixing that is out of scope for this change request. Certainly a good idea to do that, but IMHO not a blocker for this to go in.

I don't think this is a bug in any ioslave : dolphin view doesn't have this issue when copy/pasting files in , and for instance recentlyused:/ has "writing=false" and "moving=false" in its json file.
So I would guess this is not a bug there but somewhere else along the call chain. One can compare this code to DolphinContextMenu::createPasteAction that uses KIO::pasteActionText

I agree this should not keep this bug from landing.

In D29006#667588, @dfaure wrote:

It sounds to me like you found bugs in some kioslaves. Fixing that is out of scope for this change request. Certainly a good idea to do that, but IMHO not a blocker for this to go in.

Good from a KIO point of view, but this needs approval from Dolphin people.

It sounds to me like you found bugs in some kioslaves. Fixing that is out of scope for this change request. Certainly a good idea to do that, but IMHO not a blocker for this to go in.

I also accept the new version of the proposal, of course :-)

@meven
These seem to be 'special-cases' locations.
The call to capabilitiesDestination.isWritable() :

typo fix

• Fix typos found by yurchor

Thanks in advance for fixing these minor typos.

Updated missing files

• Rewrite so it's obvious that it is copying/moving to the inactive view

• Merge branch 'master' of https://anongit.kde.org/dolphin into arcpatch-D29006

• Revert "Instead of append, change the value to a simplifiedUrlList"

Davide, in order to simplify things, if you want you can apply the present commit and later I can apply the suggested changes.

Everything in that proposal looks good to me. Thanks for all the work!

@elvisangelaccio
copySelectedItems() is already used to copy to clipboard. See L365.

• Add check if destination is writable for copy
• Move copy/move logic to DolphinTabWidget
• Set Shift+F5/F6 instead of CTRL+F5/F6 as keyboard shortcut

The feature looks reasonable to me.

In D29006#662058, @meven wrote:

Just a check to add.

Actually, wait, I vote against Ctrl+F5/Ctrl+F6 because these shortcuts, by default, in Plasma, are bound to "Switch to Desktop 5" and "Switch to Desktop 6".

I tested the patch, works nicely.
Just a check to add.

In D29006#661964, @dfaure wrote:

Looks good to me.

Did you test copying and moving directories as well? Should work, but just to make sure.

I'll let the Dolphin developers/maintainers decide on whether the shortcuts are OK, and land this.

Looks good to me.

• Connect to copyingDone to update m_selectedUrls

• Instead of append, change the value to a simplifiedUrlList
• Remove 'selected' from text

Thanks

It's much better that way. Thanks, Davide! (and Yuri :-) )

Done :)

• Rename slotPasteJobResult to more generic slotJobResult
• Added error check when copying to other view

Thanks!