- User Since
- Mar 19 2016, 8:35 PM (169 w, 1 d)
Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab
Sun, Jun 9
Removed the single tab check in favor of a comment, like proposed by @abika
Wed, May 29
@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic
Tue, May 21
Oct 11 2018
I thought I had already committed that... changed to a more human macro name
Sep 22 2018
Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.
Sep 19 2018
Changed in favor of a macro solution (as suggested by Nikita).
Added flag for GCC as default
I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.
Sep 14 2018
I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:
Sep 12 2018
The use of a Macro was my second way to solve this, but I thought it would add more complexity to the code; instead, this patch makes the code unclear to read.
I updated the diff to v2 to fix spaces as requested.
Sep 10 2018
Sep 9 2018
May 28 2018
May 22 2018
I tried to break as less things as possible. I have a little knowledge of i18n but I think that merging the text will require a new strings translation; from my point of view, translations magically appear when I compile. I can put a comment in the final commit to let others to know that it can be refactored.
May 19 2018
May 15 2018
Mar 11 2018
All tests fine, it also work with zip:/ protocol
Feb 27 2018
Feb 25 2018
Tested on Slackware 14.2 with gcc 5 and Fedora 25 with gcc 6
Feb 22 2018
Feb 17 2018
Sep 10 2017
Jul 29 2017
Nov 24 2016
Nov 20 2016
Yes, kiso is missing the option we added to krarc (see https://groups.google.com/forum/#!topic/krusader-devel/mN8uyxBj4Wg).
What distro do you have? I'll dive into KIO to see where the problem is.
This patch can be applied on master; is this helpful, or the rework on VFS will make it obsolete?
Oct 24 2016
Great work!!! Sorry for not being present lately, but I have some issues with my pc an my work keeps my spare time lower.
Oct 10 2016
Sep 21 2016
I tried only on zip files, but I have to check all kind of archives supported by 7za. To stop the kio, I use error(ERR_CANNOT_RENAME). This doesn't permit KIO to switch to copy+del or get+put.
Sep 17 2016
You can't pass a QList of urls to every program, not every program likes it so no files are opened at all.
This is the first attempt to use 7za to rename a file inside an archive. It works, but we have to do more checks.
Aug 31 2016
I forgot non-empty folders. My solution can't be useful anymore. So I turned again on zipnote and looking to a possibile method with other types of archive, I've found that newer versions of 7za can rename files inside archives (both .zip and .7z).
Aug 28 2016
Aug 27 2016
A fix could be to change in krusader/Panel/panelfunc.cpp:215
Using D2603, I was able to find where to problem is:
Aug 24 2016
I agree too. The KrCalcSpaceDialog pops up after a while when calculating directory space. It is a way to know that Krusader isn't freezed. When done, the popup closes and the <DIR> string is changed with the dir space. Anything to say "hey, I'm working, but I'm not freezed" is good to; like when krarc reads a file.
Aug 23 2016
Atm, this task is almost a discussion, if you have already done some work, no problem. I'm focused on kio_iso T3490 (the solution to recognize path with symlinks, the other one is trivial).
Aug 21 2016
I've found two possible solutions:
Aug 20 2016
This explain very well the problem. We can't use kio_krarcProtocol::copy to rename an item inside an archive, and krArc doesn't have a rename method, so we must implement it.
Aug 18 2016
The problem starts here: the job is started but it is never completed.
Aug 16 2016
I agree, the analysis is right; it is also needed to search into archives (because they have the tar: krarc: or zip: scheme).
Aug 14 2016
In the first days of porting, I thought Extragear software was merging into Applications and no one never changed it.
CTRL+DEL works fine and it doesn't seems to conflicts with other actions (afaik, it is used to delete the whole next word, but we're not in an edit mode).