gengisdave (Davide Gianforte)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 19 2016, 8:35 PM (205 w, 5 d)
Availability
Available

Recent Activity

Tue, Feb 18

gengisdave accepted D27446: Changes in names of variables, functions, and comments (due to recent changes and old ones).

Sounds good to me, no errors found

Tue, Feb 18, 7:16 AM · Krusader

Sat, Feb 15

gengisdave accepted D27259: Manage the use of Shift+F4 when opening a local file that exists, or a remote folder or remote file that exists.

Compiled and tested on QT 5.14.1, QT 5.9.5 (Ubuntu 18.04) and QT 5.12.4 (Ubuntu 19.10); all fine

Sat, Feb 15, 11:24 AM · Krusader

Wed, Feb 12

gengisdave accepted D27335: Allow Krusader to be built under the 16.04 LTS versions of Ubuntu, Kubuntu, etc.

All good, thanks.

Wed, Feb 12, 10:16 AM · Krusader, Documentation

Mon, Feb 10

gengisdave requested review of D27302: Update obsolete KProcess::error.
Mon, Feb 10, 6:58 PM · Krusader
gengisdave requested review of D27290: Update obsolete QWidget::getContentsMargins.
Mon, Feb 10, 3:19 PM · Krusader
gengisdave requested review of D27289: Update obsolete QString::sprintf.
Mon, Feb 10, 2:41 PM · Krusader
gengisdave committed R167:2314fead5b12: Update deprecated KUrlLabel::leftClickedUrl (authored by gengisdave).
Update deprecated KUrlLabel::leftClickedUrl
Mon, Feb 10, 10:18 AM
gengisdave closed D26325: Update deprecated KUrlLabel::leftClickedUrl.
Mon, Feb 10, 10:18 AM · Krusader
gengisdave committed R167:2bebb93c944c: Add QT::KeyMenu action to search results (authored by gengisdave).
Add QT::KeyMenu action to search results
Mon, Feb 10, 10:13 AM
gengisdave closed D23924: Add QT::KeyMenu action to search results.
Mon, Feb 10, 10:13 AM · Krusader
gengisdave committed R167:528c1977e27f: Replace obsolete KFileItem::mostLocalUrl(bool &) (authored by gengisdave).
Replace obsolete KFileItem::mostLocalUrl(bool &)
Mon, Feb 10, 10:01 AM
gengisdave closed D26269: Remove deprecated mostLocalUrl.
Mon, Feb 10, 10:01 AM · Krusader
gengisdave accepted D27258: Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file.

All tests fine.

Mon, Feb 10, 9:47 AM · Krusader

Sat, Feb 8

gengisdave closed D26334: Select item from search window.
Sat, Feb 8, 1:52 PM · Krusader
gengisdave committed R167:f636ba2b616b: Select item from search window (authored by gengisdave).
Select item from search window
Sat, Feb 8, 1:52 PM
gengisdave added a comment to D26334: Select item from search window.

Although the current fix works for me, i propose to change the added line into

panel->view->setNameToMakeCurrent(nameToMakeCurrent);
Sat, Feb 8, 1:50 PM · Krusader

Jan 9 2020

gengisdave accepted D26535: Remove unused include.

Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3

Jan 9 2020, 1:25 AM · Krusader

Jan 3 2020

gengisdave abandoned D26383: Open screenshot folder with default file manager.

Closed in favor of adding FileManager1 dbus interface to Krusader

Jan 3 2020, 4:31 PM · Spectacle
gengisdave updated the summary of D26383: Open screenshot folder with default file manager.
Jan 3 2020, 8:50 AM · Spectacle
gengisdave requested review of D26383: Open screenshot folder with default file manager.
Jan 3 2020, 8:49 AM · Spectacle

Jan 1 2020

gengisdave closed T3479: Krusader freezes when renaming a file that is inside an archive as Resolved.
Jan 1 2020, 5:01 PM · Krusader
gengisdave committed R241:a6d068dee88a: [KUrlNavigator] Add RPM support to krarc: (authored by gengisdave).
[KUrlNavigator] Add RPM support to krarc:
Jan 1 2020, 10:46 AM
gengisdave closed D26155: Add RPM support to Krarc.
Jan 1 2020, 10:46 AM · Frameworks

Dec 31 2019

gengisdave requested review of D26334: Select item from search window.
Dec 31 2019, 5:56 PM · Krusader
gengisdave requested review of D26325: Update deprecated KUrlLabel::leftClickedUrl.
Dec 31 2019, 11:12 AM · Krusader

Dec 30 2019

gengisdave updated the diff for D26291: rework of keyboard widgets focus.

Updated docbook as stated by @yurchor.

Dec 30 2019, 2:51 PM · Krusader, Documentation
gengisdave requested review of D26291: rework of keyboard widgets focus.
Dec 30 2019, 1:56 PM · Krusader, Documentation

Dec 29 2019

gengisdave requested review of D26269: Remove deprecated mostLocalUrl.
Dec 29 2019, 8:57 AM · Krusader

Dec 22 2019

gengisdave requested review of D26155: Add RPM support to Krarc.
Dec 22 2019, 3:58 PM · Frameworks
gengisdave accepted D24809: Archive: Fix invalid destination URL when packing/unpacking from remote location.

Compiled and tested with no errors, thanks

Dec 22 2019, 1:16 PM · Krusader

Dec 2 2019

gengisdave accepted D25669: Replace Q_DECL_OVERRIDE with override.

Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).

Dec 2 2019, 7:03 AM · Krusader

Oct 2 2019

gengisdave committed R167:2f8a04cd027e: changes in class DefaultFileSystem for Windows (authored by gengisdave).
changes in class DefaultFileSystem for Windows
Oct 2 2019, 8:18 PM
gengisdave committed R167:7998aba48d5b: Change icon and window title in administrator mode (authored by gengisdave).
Change icon and window title in administrator mode
Oct 2 2019, 7:09 PM

Oct 1 2019

gengisdave committed R167:6085eebd58b3: Introduce KrWin class (authored by gengisdave).
Introduce KrWin class
Oct 1 2019, 6:21 PM

Sep 30 2019

gengisdave committed R167:5dfb11808f4d: Don't use POSIX signals in Windows (authored by gengisdave).
Don't use POSIX signals in Windows
Sep 30 2019, 9:17 PM

Sep 26 2019

gengisdave requested review of D24250: Add Krusader to Craft.
Sep 26 2019, 7:26 PM · Craft

Sep 21 2019

gengisdave committed R167:2fa5e3f23b3d: Fix warning about macro expansion (authored by gengisdave).
Fix warning about macro expansion
Sep 21 2019, 3:09 PM
gengisdave closed D23938: Fix warning about macro expansion.
Sep 21 2019, 3:09 PM · Krusader
gengisdave accepted D24026: Replace explicite type casting with dynamic casts.

Tested Synchronizer, Konfigurator and DiskUsage, no problems found.

Sep 21 2019, 2:21 PM · Krusader

Sep 15 2019

gengisdave committed R167:ebb75da3e2c0: Handle Ctrl+Left/Right not working in brief view (authored by gengisdave).
Handle Ctrl+Left/Right not working in brief view
Sep 15 2019, 8:29 PM
gengisdave closed D23880: Handle Ctrl+Left/Right not working in brief view.
Sep 15 2019, 8:29 PM · Krusader

Sep 14 2019

gengisdave added a comment to D23001: For the "kde4" branch: 08 - Update the synchronizer.docbook file because of the latest changes REVIEW: 124335.

I personally think that the original repo could be used, my perfect solution would be a scratch repo. But (this is a big but) the target of this set of patches shouldn't be a normal user but a distro packager, and we must show big warning saying that this does not mean that the developing is active and only trivial patches for critical bugs could be backported; sometime a single-line patch cannot be backported because all the logic around was changed, or the backport does not fix at all or even worse. Also, because the development is closed, no bugs should be reported because the first answer would be "can you try on a newer version?".

Sep 14 2019, 1:46 PM · Documentation, Krusader
gengisdave requested review of D23938: Fix warning about macro expansion.
Sep 14 2019, 11:29 AM · Krusader
gengisdave closed D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sep 14 2019, 7:54 AM · Krusader
gengisdave added 1 commit(s) for D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance: R167:f66e2a7481f0: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sep 14 2019, 7:54 AM · Krusader
gengisdave added an edge to R167:f66e2a7481f0: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance: D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Sep 14 2019, 7:54 AM

Sep 13 2019

gengisdave committed R167:f66e2a7481f0: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance (authored by gengisdave).
Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance
Sep 13 2019, 9:07 PM
gengisdave added a comment to D23885: Update build status icon.

I don't have write access to the repo, can someone please push? Thanks

Sep 13 2019, 8:53 PM · Krusader
gengisdave requested review of D23924: Add QT::KeyMenu action to search results.
Sep 13 2019, 10:58 AM · Krusader

Sep 12 2019

gengisdave requested review of D23912: Respect .hidden files.
Sep 12 2019, 5:04 PM · Krusader
gengisdave accepted D23476: Identify the "application/vnd.rar" MIME type in order to allow some operations.

The patch works fine, although it requires KIO 5.62 or a reverse patch

Sep 12 2019, 12:25 PM · Krusader

Sep 11 2019

gengisdave requested review of D23885: Update build status icon.
Sep 11 2019, 8:10 PM · Krusader
gengisdave requested review of D23880: Handle Ctrl+Left/Right not working in brief view.
Sep 11 2019, 4:14 PM · Krusader
gengisdave accepted D23243: Avoid that Krusader crashes when trying to view any archive using the ark part.

Tested, it works perfectly with every archive as if it had been opened with Ark

Sep 11 2019, 8:56 AM · Krusader

Aug 19 2019

gengisdave accepted D23236: Updates related to v2.7.2 release.
Aug 19 2019, 7:44 PM · Krusader
gengisdave accepted D23235: Released v2.7.2.
Aug 19 2019, 7:43 PM · Krusader
gengisdave accepted D23197: Updated ChangeLog and NEWS with v2.7.2 changes.
Aug 19 2019, 7:43 PM · Krusader

Aug 12 2019

gengisdave accepted D22883: Clarify the aim of two lines written recently by David Faure.
Aug 12 2019, 7:52 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Aug 12 2019, 7:50 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Aug 12 2019, 7:49 PM · Krusader
gengisdave updated subscribers of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

Aug 12 2019, 7:49 PM · Krusader

Jul 21 2019

gengisdave accepted D22602: Updated copyright years.

No objections

Jul 21 2019, 6:55 PM · Krusader, Documentation
gengisdave updated the diff for D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

Changed with macro, as suggested by @nmel; the code now is cleaner (and QFONTMETRICS_HORIZONTAL_ADVANCE seems a bit long)

Jul 21 2019, 6:36 PM · Krusader
gengisdave committed R167:11ad2b9ef22d: Wrap text in copy/move confirmation dialog (authored by gengisdave).
Wrap text in copy/move confirmation dialog
Jul 21 2019, 3:46 PM
gengisdave closed D22443: Wrap text in copy/move confirmation dialog.
Jul 21 2019, 3:46 PM · Krusader
gengisdave committed R167:1f7ffb360332: Remove obsolete qt version check (authored by gengisdave).
Remove obsolete qt version check
Jul 21 2019, 3:34 PM
gengisdave closed D22435: Remove obsolete qt version check.
Jul 21 2019, 3:34 PM · Krusader

Jul 18 2019

gengisdave added a comment to D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.

@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.

Jul 18 2019, 6:29 PM · Krusader
gengisdave accepted D22504: Get rid of some deprecated methods.

Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.

Jul 18 2019, 2:40 PM · Krusader

Jul 17 2019

gengisdave added a project to D22504: Get rid of some deprecated methods: Krusader.
Jul 17 2019, 10:15 AM · Krusader

Jul 13 2019

gengisdave requested review of D22443: Wrap text in copy/move confirmation dialog.
Jul 13 2019, 4:43 PM · Krusader
gengisdave requested review of D22435: Remove obsolete qt version check.
Jul 13 2019, 12:13 PM · Krusader
gengisdave requested review of D22434: Replace obsolete QFontMetrics::width with QFontMetrics::horizontalAdvance.
Jul 13 2019, 12:03 PM · Krusader
gengisdave accepted D22431: Fixed lost editor when file is updating and the list model to correctly handle next item.

Tested on Fedora 30; it compiles and the bug is not present anymore; during the same test, a Krusader version without this patch was having this problem while the patched one was able to rename the file.

Jul 13 2019, 9:52 AM · Krusader

Jun 16 2019

gengisdave closed D21323: Shortcuts for move tab.

Forgot to add the reference to this revision in the commit message, closed with Shortcuts to move tab

Jun 16 2019, 11:10 AM · Krusader

Jun 15 2019

gengisdave committed R167:ca00347a865e: Shortcuts to move tab (authored by gengisdave).
Shortcuts to move tab
Jun 15 2019, 7:32 PM

Jun 9 2019

gengisdave updated the diff for D21323: Shortcuts for move tab.

Removed the single tab check in favor of a comment, like proposed by @abika

Jun 9 2019, 6:20 AM · Krusader

May 29 2019

gengisdave added a comment to D21323: Shortcuts for move tab.

@abika : this is intentional to define that these two methods do nothing when the panel has just one tab, I can change them with a comment remarking this logic

May 29 2019, 5:18 AM · Krusader

May 21 2019

gengisdave requested review of D21323: Shortcuts for move tab.
May 21 2019, 7:00 PM · Krusader

Oct 11 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

I thought I had already committed that... changed to a more human macro name

Oct 11 2018, 8:20 PM · Krusader

Sep 22 2018

gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

Confirmed by the build (https://build.kde.org/job/Extragear/job/krusader/job/kf5-qt5%20FreeBSDQt5.11/4/warnings12Result/), 51 warnings fixed and 'missing-override' is not in the remaining 57.

Sep 22 2018, 9:03 AM · Krusader
gengisdave committed R167:b6cbaf17dd2e: Fix compile warnings on missing override declarations (authored by gengisdave).
Fix compile warnings on missing override declarations
Sep 22 2018, 8:54 AM
gengisdave closed D15400: Fix compile warnings on missing override declarations.
Sep 22 2018, 8:54 AM · Krusader

Sep 19 2018

gengisdave updated the diff for D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

Changed in favor of a macro solution (as suggested by Nikita).

Sep 19 2018, 2:15 PM · Krusader
gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

What do you think about creating a specialized version of UDSEntry, e.g. KrUDSEntry? This way the code:

Sep 19 2018, 12:15 PM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.

Added flag for GCC as default

Sep 19 2018, 11:59 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've looked at the Clang behaviour: the -Winconsistent-missing-override flag is always set (Debug, Release and none), so GCC should be set the same. My initial thought was to not users to be worried; on a second thought, every user is a tester too.

Sep 19 2018, 11:42 AM · Krusader

Sep 14 2018

gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I've tested with clang compiler and no additional flags are needed, on a clean Fedora 28 I used:

Sep 14 2018, 8:25 AM · Krusader

Sep 12 2018

gengisdave added a comment to D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.

The use of a Macro was my second way to solve this, but I thought it would add more complexity to the code; instead, this patch makes the code unclear to read.

Sep 12 2018, 8:51 AM · Krusader
gengisdave added a comment to D15400: Fix compile warnings on missing override declarations.

I updated the diff to v2 to fix spaces as requested.

Sep 12 2018, 8:40 AM · Krusader
gengisdave updated the diff for D15400: Fix compile warnings on missing override declarations.
Sep 12 2018, 8:31 AM · Krusader

Sep 10 2018

gengisdave requested review of D15400: Fix compile warnings on missing override declarations.
Sep 10 2018, 10:24 AM · Krusader

Sep 9 2018

gengisdave requested review of D15376: Replace deprecated UDSEntry::insert with UDSEntry::fastInsert.
Sep 9 2018, 2:34 PM · Krusader

May 28 2018

gengisdave committed R167:94ff5d6ccb3a: Fixed ugly message dialog on Compare by Content error (authored by gengisdave).
Fixed ugly message dialog on Compare by Content error
May 28 2018, 6:29 PM
gengisdave closed D12904: Fixed ugly message dialog on Compare by Content error.
May 28 2018, 6:28 PM · Krusader

May 22 2018

gengisdave added a comment to D12904: Fixed ugly message dialog on Compare by Content error.

I tried to break as less things as possible. I have a little knowledge of i18n but I think that merging the text will require a new strings translation; from my point of view, translations magically appear when I compile. I can put a comment in the final commit to let others to know that it can be refactored.

May 22 2018, 4:50 AM · Krusader
gengisdave retitled D12904: Fixed ugly message dialog on Compare by Content error from Ugly message dialog on Compare by Content error to Fixed ugly message dialog on Compare by Content error.
May 22 2018, 4:48 AM · Krusader

May 19 2018

gengisdave committed R167:eb60c734b940: Unselect all items when calculating occupied space on ".." (authored by gengisdave).
Unselect all items when calculating occupied space on ".."
May 19 2018, 9:56 AM
gengisdave retitled D12906: Unselect all items when calculating occupied space on ".." from Unselect all items when calculating occupied space to Unselect all items when calculating occupied space on "..".
May 19 2018, 9:49 AM · Krusader

May 15 2018

gengisdave requested review of D12906: Unselect all items when calculating occupied space on "..".
May 15 2018, 8:05 PM · Krusader