Piotr Henryk Dabrowski <firstname.lastname@example.org>
- User Since
- Aug 3 2018, 11:57 AM (95 w, 2 d)
Thu, May 21
Sat, May 9
Tue, May 5
Fwiw the KMoreTools in the free space bar doesn't use a local URL either.
I have noticed this now. And this seems a sane thing to do.
Do Search or any search tools even work in remote locations?
"More Search Tools" menu doesn't cause #420911 in remote connections even though it is also called every time that menu is shown.
It was added to handle this action as a button in toolbar (can be added by user, and this was requested in #384798).
I didn't notice this causes such a problem with remote connections, sorry.
It is a rare occasion that user changes preferred search tools, but I guess they would like to have it updated all over Dolphin when they do.
Apr 10 2020
I totally missed the D26688 request.
And it proposes some great ideas.
So just to update my mockup accordingly:
Maybe I should explain my motives and probably that would let us (including me) understand the goal better.
Mar 23 2020
Mar 12 2020
Mar 10 2020
more context lines in diff
"update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()"
instead of reverting by:
"don't use KParts::ReadOnlyPart::localFilePath() in DolphinPart"
Mar 6 2020
I do not plan to change this patch.
As for solving the issue with KRunner invoked from shortcut, I still do not have a good solution for it.
Mar 2 2020
Dropped autostart feature leaving only text aggregation in DesktopView (modified to allow spaces and national characters).
Feb 4 2020
Jan 19 2020
Jan 16 2020
Jan 11 2020
Jan 7 2020
Second thought on the label:
maybe instead of "Link to:" (noun) it should say "Links to:" or "Linked to:" (verb) to better match labels like "Modified:"?
Jan 6 2020
Dec 21 2019
Dec 6 2019
Is this OK now?
Nov 17 2019
Nov 16 2019
Nov 15 2019
Nov 13 2019
This privacy issue (#409366) is still unresolved in latest Plasma.
Oct 8 2019
Sep 15 2019
Sep 14 2019
Aug 5 2019
New, much better solution.
Aug 3 2019
You don't have commit access, do you?
No, I don't.
Is "Piotr Henryk Dabrowski <email@example.com>" fine as git authorship?
Aug 1 2019
Small fix for the "Open Preferred Search Tool" as a toolbar button.
Jul 29 2019
Jul 23 2019
new diff: proper fix for clipboard history management
Weak pointer might not work well for this after all.
I need to have a second look at this patch.
new diff: much better patch
Jul 21 2019
I did some more testing, and everything seems to work fine:
$ sudo su # cd /usr/share/applications
# sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_ # no KFind now
# sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop # KFind installed
Actions to test (KFind installed/not installed):
- menubar -> Tools -> Open KFind/none
- Control toolbutton (menubar hidden) -> Tools -> Open KFind/none
- [Settings] -> Configure Shortcuts... -> shortcut for Open KFind/Open Preferred Search Tool in the list
No problem. I'm glad it works :)
Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)?
The way you've implemented the menu item naming seems a bit fragile though
True. It's really hard to update it reliably.
KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu recreates the menu every time it is displayed.
So I tried updating the action every time menu containing it is shown. Connect()ions for this aren't pretty, but this should actually work...
- For the keyboard shortcut let's use Alt instead of Shift. It is an alternate search, after all.
- Instead of showing a generic text, how about making it actually say "Search with <name of preferred search tool"?