pdabrowski (Piotr Dabrowski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 3 2018, 11:57 AM (95 w, 2 d)
Availability
Available

Piotr Henryk Dabrowski <phd@phd.re>

Recent Activity

Thu, May 21

pdabrowski updated the test plan for D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:46 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:44 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:41 PM · Dolphin
pdabrowski updated the summary of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Thu, May 21, 8:40 PM · Dolphin

Sat, May 9

pdabrowski added inline comments to D29568: use KSycoca for updating OpenPreferredSearchTool action.
Sat, May 9, 5:34 PM · Dolphin
pdabrowski updated the diff for D29568: use KSycoca for updating OpenPreferredSearchTool action.
Sat, May 9, 5:31 PM · Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Sat, May 9, 2:43 PM · Documentation, Dolphin
pdabrowski requested review of D29568: use KSycoca for updating OpenPreferredSearchTool action.
Sat, May 9, 2:40 PM · Dolphin

Tue, May 5

pdabrowski accepted D29442: Don't use local URL for KMoreTool.
Tue, May 5, 9:57 AM · Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Tue, May 5, 9:44 AM · Documentation, Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Tue, May 5, 9:39 AM · Documentation, Dolphin
pdabrowski added a comment to D29442: Don't use local URL for KMoreTool.

Fwiw the KMoreTools in the free space bar doesn't use a local URL either.

I have noticed this now. And this seems a sane thing to do.
Do Search or any search tools even work in remote locations?
"More Search Tools" menu doesn't cause #420911 in remote connections even though it is also called every time that menu is shown.

Tue, May 5, 9:28 AM · Dolphin
pdabrowski added a comment to D29441: Don't update preferred search action on window activation.

https://phabricator.kde.org/D22594#inline-168528:

It was added to handle this action as a button in toolbar (can be added by user, and this was requested in #384798).

I didn't notice this causes such a problem with remote connections, sorry.

It is a rare occasion that user changes preferred search tools, but I guess they would like to have it updated all over Dolphin when they do.

Tue, May 5, 9:25 AM · Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Tue, May 5, 9:23 AM · Documentation, Dolphin

Apr 10 2020

pdabrowski added a comment to D27972: [NightColor] fix for plasmoid status and tooltip subtext.

It almost sounds like we need a "full manual control" mode where it's expected that the system tray applet or keyboard shortcut will be used to turn it on and off on demand.

Apr 10 2020, 8:41 PM · Plasma
pdabrowski added a comment to D27972: [NightColor] fix for plasmoid status and tooltip subtext.

I totally missed the D26688 request.
And it proposes some great ideas.
So just to update my mockup accordingly:

Apr 10 2020, 4:24 PM · Plasma
pdabrowski added a comment to D27972: [NightColor] fix for plasmoid status and tooltip subtext.

Maybe I should explain my motives and probably that would let us (including me) understand the goal better.

Apr 10 2020, 3:32 PM · Plasma

Mar 23 2020

pdabrowski updated the diff for D27972: [NightColor] fix for plasmoid status and tooltip subtext.
Mar 23 2020, 10:16 PM · Plasma
pdabrowski added a comment to D27972: [NightColor] fix for plasmoid status and tooltip subtext.

Could you update the description to be a bit more clear about what exactly has been changed for which cases?

Mar 23 2020, 10:07 PM · Plasma
pdabrowski updated the diff for D27972: [NightColor] fix for plasmoid status and tooltip subtext.
Mar 23 2020, 10:05 PM · Plasma

Mar 12 2020

pdabrowski updated the diff for D27972: [NightColor] fix for plasmoid status and tooltip subtext.
Mar 12 2020, 12:24 AM · Plasma
pdabrowski added a comment to D27972: [NightColor] fix for plasmoid status and tooltip subtext.
In D27972#625596, @zzag wrote:

Fix for NightColor plasmoid active/passive status

Could you please describe what's wrong with it right now?

Mar 12 2020, 12:20 AM · Plasma
pdabrowski added inline comments to D27972: [NightColor] fix for plasmoid status and tooltip subtext.
Mar 12 2020, 12:14 AM · Plasma
pdabrowski updated the diff for D27972: [NightColor] fix for plasmoid status and tooltip subtext.

new patch

Mar 12 2020, 12:12 AM · Plasma

Mar 10 2020

pdabrowski updated the diff for D27972: [NightColor] fix for plasmoid status and tooltip subtext.

more context lines in diff

Mar 10 2020, 11:13 PM · Plasma
pdabrowski requested review of D27972: [NightColor] fix for plasmoid status and tooltip subtext.
Mar 10 2020, 11:06 PM · Plasma
pdabrowski updated the diff for D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl().

"update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl()"
instead of reverting by:
"don't use KParts::ReadOnlyPart::localFilePath() in DolphinPart"

Mar 10 2020, 4:34 PM · Dolphin

Mar 6 2020

pdabrowski added a comment to D26718: aggregate text for KRunner in DesktopView.

Are you planning to work on that other part in this patch, or in a separate one?

I do not plan to change this patch.
As for solving the issue with KRunner invoked from shortcut, I still do not have a good solution for it.

Mar 6 2020, 4:53 AM · Plasma

Mar 2 2020

pdabrowski updated the diff for D26718: aggregate text for KRunner in DesktopView.
Mar 2 2020, 8:17 PM · Plasma
pdabrowski added inline comments to D26718: aggregate text for KRunner in DesktopView.
Mar 2 2020, 8:15 PM · Plasma
pdabrowski updated the diff for D26718: aggregate text for KRunner in DesktopView.

Dropped autostart feature leaving only text aggregation in DesktopView (modified to allow spaces and national characters).

Mar 2 2020, 8:12 PM · Plasma
pdabrowski updated the summary of D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl().
Mar 2 2020, 6:52 PM · Dolphin
pdabrowski requested review of D27790: update KParts' ReadOnlyPart::localFilePath in DolphinPart::openUrl().
Mar 2 2020, 6:45 PM · Dolphin
pdabrowski abandoned D27148: update d->m_file in ReadOnlyPart::setUrl().
Mar 2 2020, 6:40 PM · Frameworks

Feb 4 2020

pdabrowski updated the diff for D27148: update d->m_file in ReadOnlyPart::setUrl().
Feb 4 2020, 8:42 PM · Frameworks
pdabrowski added inline comments to D27148: update d->m_file in ReadOnlyPart::setUrl().
Feb 4 2020, 7:31 PM · Frameworks
pdabrowski added a comment to D27148: update d->m_file in ReadOnlyPart::setUrl().

Yes, I'd concluded that the real place to fix the problem was at the KParts level, but not being a KParts expert wanted to leave that decision to its maintainers. +1 for the elegant fix.

Feb 4 2020, 7:10 PM · Frameworks
pdabrowski requested review of D27148: update d->m_file in ReadOnlyPart::setUrl().
Feb 4 2020, 12:23 AM · Frameworks

Jan 19 2020

pdabrowski added a comment to D26718: aggregate text for KRunner in DesktopView.

I don't want us to make krunner autostart. It's a hack, not a fix.

Jan 19 2020, 8:56 PM · Plasma
pdabrowski planned changes to D26718: aggregate text for KRunner in DesktopView.
Jan 19 2020, 8:37 PM · Plasma

Jan 16 2020

pdabrowski updated the diff for D26718: aggregate text for KRunner in DesktopView.
Jan 16 2020, 11:25 PM · Plasma
pdabrowski added inline comments to D26718: aggregate text for KRunner in DesktopView.
Jan 16 2020, 9:27 PM · Plasma
pdabrowski added a comment to D26718: aggregate text for KRunner in DesktopView.

Maybe if we autostarted KRunner based on whether it was used previously

Jan 16 2020, 9:21 PM · Plasma
pdabrowski added a reviewer for D26718: aggregate text for KRunner in DesktopView: broulik.
Jan 16 2020, 9:01 PM · Plasma
pdabrowski updated the summary of D26718: aggregate text for KRunner in DesktopView.
Jan 16 2020, 8:59 PM · Plasma
pdabrowski requested review of D26718: aggregate text for KRunner in DesktopView.
Jan 16 2020, 8:52 PM · Plasma

Jan 11 2020

pdabrowski updated the diff for D26576: [Dolphin] Hide tooltip instantly on filter change.
Jan 11 2020, 12:24 PM · Dolphin
pdabrowski requested review of D26576: [Dolphin] Hide tooltip instantly on filter change.
Jan 11 2020, 8:27 AM · Dolphin

Jan 7 2020

pdabrowski added a comment to D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.

Second thought on the label:
maybe instead of "Link to:" (noun) it should say "Links to:" or "Linked to:" (verb) to better match labels like "Modified:"?

Jan 7 2020, 4:38 PM · Baloo
pdabrowski added a comment to D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.

How about only adding the "Link to:"/"Link Destination" to the detailed view, but moving it up in the ordering:

Done.

Jan 7 2020, 4:11 PM · Baloo
pdabrowski updated the diff for D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.
Jan 7 2020, 4:10 PM · Baloo

Jan 6 2020

pdabrowski updated the summary of D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.
Jan 6 2020, 2:38 PM · Baloo
pdabrowski requested review of D26469: [FileMetaDataProvider] support symlinks with a new "Link to" item.
Jan 6 2020, 2:35 PM · Baloo

Dec 21 2019

pdabrowski added a comment to D26140: Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal().

Follow up from D22594: https://phabricator.kde.org/D22594?vs=on&id=67500&whitespace=ignore-most#inline-139176

Dec 21 2019, 9:54 AM · Dolphin
pdabrowski requested review of D26140: Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal().
Dec 21 2019, 9:54 AM · Dolphin

Dec 6 2019

pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

Is this OK now?

Dec 6 2019, 5:40 AM · Plasma

Nov 17 2019

pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Nov 17 2019, 9:27 AM · Documentation, Dolphin
pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Nov 17 2019, 8:15 AM · Documentation, Dolphin
pdabrowski added inline comments to D22684: [Klipper] Fix clipboard history management.
Nov 17 2019, 8:03 AM · Plasma

Nov 16 2019

pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Nov 16 2019, 7:28 PM · Plasma
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Nov 16 2019, 7:25 PM · Documentation, Dolphin

Nov 15 2019

pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

Rebased.

Nov 15 2019, 12:16 AM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Nov 15 2019, 12:15 AM · Plasma

Nov 13 2019

pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

Bump.
This privacy issue (#409366) is still unresolved in latest Plasma.

Nov 13 2019, 6:55 AM · Plasma

Oct 8 2019

pdabrowski added inline comments to D22594: [Dolphin] Open Preferred Search Tool action.
Oct 8 2019, 1:32 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Oct 8 2019, 1:30 PM · Documentation, Dolphin

Sep 15 2019

pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.

Rebased.

Sep 15 2019, 9:38 PM · Documentation, Dolphin

Sep 14 2019

pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Done.

Sep 14 2019, 11:05 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Sep 14 2019, 11:03 PM · Documentation, Dolphin

Aug 5 2019

pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 10:16 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 10:14 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 9:22 PM · Plasma
pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

New, much better solution.

Aug 5 2019, 9:01 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 9:01 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 8:23 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 8:19 PM · Plasma

Aug 3 2019

pdabrowski added a comment to D22512: [Dolphin] Hide tooltip instantly on key press.

You don't have commit access, do you?

No, I don't.

Is "Piotr Henryk Dabrowski <phd@phd.re>" fine as git authorship?

Yes.

Aug 3 2019, 12:22 PM · Dolphin
pdabrowski added a comment to D22512: [Dolphin] Hide tooltip instantly on key press.

Done.

Aug 3 2019, 11:41 AM · Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.
Aug 3 2019, 11:41 AM · Dolphin

Aug 1 2019

pdabrowski updated the summary of D22594: [Dolphin] Open Preferred Search Tool action.
Aug 1 2019, 4:17 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.

Small fix for the "Open Preferred Search Tool" as a toolbar button.

Aug 1 2019, 4:01 PM · Documentation, Dolphin
pdabrowski updated the summary of D22594: [Dolphin] Open Preferred Search Tool action.
Aug 1 2019, 3:14 PM · Documentation, Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.
Aug 1 2019, 2:58 PM · Dolphin

Jul 29 2019

pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Where? Do we have an open wish on bugs.kde.org ?

Jul 29 2019, 9:30 AM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

I'd like to remind that the menubar is hidden by default and the average user won't know about the CTRL+Shift+F shortcut.
So is this feature only aimed at advanced users who expect CTRL+Shift+F to do something?

Jul 29 2019, 8:58 AM · Documentation, Dolphin

Jul 23 2019

pdabrowski requested review of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 10:46 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.

new diff: proper fix for clipboard history management

Jul 23 2019, 10:45 PM · Plasma
pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

Weak pointer might not work well for this after all.
I need to have a second look at this patch.

Jul 23 2019, 6:16 PM · Plasma
pdabrowski planned changes to D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 6:14 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 5:58 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.

new diff: much better patch

Jul 23 2019, 3:04 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 2:16 PM · Plasma
pdabrowski requested review of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 2:01 PM · Plasma

Jul 21 2019

pdabrowski planned changes to D22243: Add Breeze Light and Chrome color schemes.
Jul 21 2019, 11:30 PM · Konsole
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

I did some more testing, and everything seems to work fine:

$ sudo su
# cd /usr/share/applications
# sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_    # no KFind now
# sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop    # KFind installed

Actions to test (KFind installed/not installed):

  • menubar -> Tools -> Open KFind/none
  • Control toolbutton (menubar hidden) -> Tools -> Open KFind/none
  • [Settings] -> Configure Shortcuts... -> shortcut for Open KFind/Open Preferred Search Tool in the list
Jul 21 2019, 10:53 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

No problem. I'm glad it works :)

Jul 21 2019, 10:51 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)?

Jul 21 2019, 10:16 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

The way you've implemented the menu item naming seems a bit fragile though

True. It's really hard to update it reliably.
KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu recreates the menu every time it is displayed.
So I tried updating the action every time menu containing it is shown. Connect()ions for this aren't pretty, but this should actually work...

Jul 21 2019, 8:58 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.
  1. For the keyboard shortcut let's use Alt instead of Shift. It is an alternate search, after all.
Jul 21 2019, 6:18 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
  1. Instead of showing a generic text, how about making it actually say "Search with <name of preferred search tool"?
Jul 21 2019, 5:53 PM · Documentation, Dolphin