pdabrowski (Piotr Dabrowski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 3 2018, 11:57 AM (58 w, 4 d)
Availability
Available

Piotr Henryk Dabrowski <phd@phd.re>

Recent Activity

Sun, Sep 15

pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.

Rebased.

Sun, Sep 15, 9:38 PM · Documentation, Dolphin

Sat, Sep 14

pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Done.

Sat, Sep 14, 11:05 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
Sat, Sep 14, 11:03 PM · Documentation, Dolphin

Aug 5 2019

pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 10:16 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 10:14 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 9:22 PM · Plasma
pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

New, much better solution.

Aug 5 2019, 9:01 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 9:01 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 8:23 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Aug 5 2019, 8:19 PM · Plasma

Aug 3 2019

pdabrowski added a comment to D22512: [Dolphin] Hide tooltip instantly on key press.

You don't have commit access, do you?

No, I don't.

Is "Piotr Henryk Dabrowski <phd@phd.re>" fine as git authorship?

Yes.

Aug 3 2019, 12:22 PM · Dolphin
pdabrowski added a comment to D22512: [Dolphin] Hide tooltip instantly on key press.

Done.

Aug 3 2019, 11:41 AM · Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.
Aug 3 2019, 11:41 AM · Dolphin

Aug 1 2019

pdabrowski updated the summary of D22594: [Dolphin] Open Preferred Search Tool action.
Aug 1 2019, 4:17 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.

Small fix for the "Open Preferred Search Tool" as a toolbar button.

Aug 1 2019, 4:01 PM · Documentation, Dolphin
pdabrowski updated the summary of D22594: [Dolphin] Open Preferred Search Tool action.
Aug 1 2019, 3:14 PM · Documentation, Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.
Aug 1 2019, 2:58 PM · Dolphin

Jul 29 2019

pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Where? Do we have an open wish on bugs.kde.org ?

Jul 29 2019, 9:30 AM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

I'd like to remind that the menubar is hidden by default and the average user won't know about the CTRL+Shift+F shortcut.
So is this feature only aimed at advanced users who expect CTRL+Shift+F to do something?

Jul 29 2019, 8:58 AM · Documentation, Dolphin

Jul 23 2019

pdabrowski requested review of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 10:46 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.

new diff: proper fix for clipboard history management

Jul 23 2019, 10:45 PM · Plasma
pdabrowski added a comment to D22684: [Klipper] Fix clipboard history management.

Weak pointer might not work well for this after all.
I need to have a second look at this patch.

Jul 23 2019, 6:16 PM · Plasma
pdabrowski planned changes to D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 6:14 PM · Plasma
pdabrowski updated the summary of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 5:58 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.

new diff: much better patch

Jul 23 2019, 3:04 PM · Plasma
pdabrowski updated the diff for D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 2:16 PM · Plasma
pdabrowski requested review of D22684: [Klipper] Fix clipboard history management.
Jul 23 2019, 2:01 PM · Plasma

Jul 21 2019

pdabrowski planned changes to D22243: Add Breeze Light and Chrome color schemes.
Jul 21 2019, 11:30 PM · Konsole
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

I did some more testing, and everything seems to work fine:

$ sudo su
# cd /usr/share/applications
# sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_    # no KFind now
# sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop    # KFind installed

Actions to test (KFind installed/not installed):

  • menubar -> Tools -> Open KFind/none
  • Control toolbutton (menubar hidden) -> Tools -> Open KFind/none
  • [Settings] -> Configure Shortcuts... -> shortcut for Open KFind/Open Preferred Search Tool in the list
Jul 21 2019, 10:53 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

No problem. I'm glad it works :)

Jul 21 2019, 10:51 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)?

Jul 21 2019, 10:16 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.

The way you've implemented the menu item naming seems a bit fragile though

True. It's really hard to update it reliably.
KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu recreates the menu every time it is displayed.
So I tried updating the action every time menu containing it is shown. Connect()ions for this aren't pretty, but this should actually work...

Jul 21 2019, 8:58 PM · Documentation, Dolphin
pdabrowski added a comment to D22594: [Dolphin] Open Preferred Search Tool action.
  1. For the keyboard shortcut let's use Alt instead of Shift. It is an alternate search, after all.
Jul 21 2019, 6:18 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
  1. Instead of showing a generic text, how about making it actually say "Search with <name of preferred search tool"?
Jul 21 2019, 5:53 PM · Documentation, Dolphin
pdabrowski updated the diff for D22594: [Dolphin] Open Preferred Search Tool action.
  1. Whenever you change anything in a .rc file, you need to bump the version number that appears at the top of the file.

Done.

Jul 21 2019, 5:51 PM · Documentation, Dolphin
pdabrowski updated the summary of D22594: [Dolphin] Open Preferred Search Tool action.
Jul 21 2019, 12:55 AM · Documentation, Dolphin

Jul 20 2019

pdabrowski requested review of D22594: [Dolphin] Open Preferred Search Tool action.
Jul 20 2019, 7:08 PM · Documentation, Dolphin
pdabrowski added inline comments to D22547: [KFind] Natural auto-scrolling during new items insertion into search results view.
Jul 20 2019, 12:28 PM
pdabrowski updated the diff for D22547: [KFind] Natural auto-scrolling during new items insertion into search results view.
Jul 20 2019, 12:27 PM

Jul 19 2019

pdabrowski updated the diff for D22547: [KFind] Natural auto-scrolling during new items insertion into search results view.
Jul 19 2019, 10:05 PM
pdabrowski added inline comments to D22547: [KFind] Natural auto-scrolling during new items insertion into search results view.
Jul 19 2019, 10:04 PM
pdabrowski requested review of D22547: [KFind] Natural auto-scrolling during new items insertion into search results view.
Jul 19 2019, 1:17 AM
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.

Uploaded (final?) diff with version using duplicated hideToolTip()/hideToolTipInstantly() slots.

Jul 19 2019, 1:06 AM · Dolphin
pdabrowski updated the diff for D22512: [Dolphin] Hide tooltip instantly on key press.

Uploaded diff with version using QOverload.

Jul 19 2019, 1:04 AM · Dolphin

Jul 18 2019

pdabrowski added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Jul 18 2019, 8:52 PM · Dolphin
pdabrowski added inline comments to D22512: [Dolphin] Hide tooltip instantly on key press.
Jul 18 2019, 8:46 PM · Dolphin

Jul 17 2019

pdabrowski requested review of D22512: [Dolphin] Hide tooltip instantly on key press.
Jul 17 2019, 3:26 PM · Dolphin

Jul 9 2019

pdabrowski added a comment to D22243: Add Breeze Light and Chrome color schemes.

@hindenburg
are

Opacity=1
Wallpaper=

also the defaults that could be removed from color schemes?

Jul 9 2019, 6:02 PM · Konsole
pdabrowski added a comment to D22243: Add Breeze Light and Chrome color schemes.

@ngraham, @hindenburg
I will modify the commit (BreezeLight only, Blur=, CMakeLists.txt) and sumbit it via GitLab (invent.kde.org).

Jul 9 2019, 5:59 PM · Konsole

Jul 3 2019

pdabrowski updated the diff for D22243: Add Breeze Light and Chrome color schemes.
Jul 3 2019, 8:37 PM · Konsole
pdabrowski added a reviewer for D22243: Add Breeze Light and Chrome color schemes: Konsole.
Jul 3 2019, 5:36 PM · Konsole
pdabrowski requested review of D22243: Add Breeze Light and Chrome color schemes.
Jul 3 2019, 5:09 PM · Konsole