SendLaterAgent: merge libKF5SendLater library into the agent
ClosedPublic

Authored by dvratil on May 13 2020, 4:36 PM.

Details

Summary

The library has been split into two parts: the client-side code now
lives in MessageComposer where it's used exclusively, and all the code
that is used by the Agent has been moved in here.

Instead of the client writing into a shared config file, a new DBus
method has been added to the agent that the client can call in order to
schedule a new message for sending later.

Tests for classes that now live in MessageComposer have been moved to MessageComposer.

Diff Detail

Repository
R206 KMail
Branch
arcpatch-D29724
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27014
Build 27032: arc lint + arc unit
dvratil created this revision.May 13 2020, 4:36 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 13 2020, 4:36 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.May 13 2020, 4:36 PM
mlaurent requested changes to this revision.May 15 2020, 12:24 PM
mlaurent added inline comments.
agents/sendlateragent/sendlaterutil.cpp
33

#include "sendlaterinfo.h"

agents/sendlateragent/sendlaterutil_p.h
23

not necessary no ?

This revision now requires changes to proceed.May 15 2020, 12:24 PM
dvratil updated this revision to Diff 82928.May 15 2020, 12:38 PM
  • Address review comments
Restricted Application added a project: Documentation. · View Herald TranscriptMay 15 2020, 12:38 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
dvratil updated this revision to Diff 82929.May 15 2020, 12:38 PM
  • Fix arc going crazy
mlaurent added inline comments.May 16 2020, 8:23 AM
agents/sendlateragent/sendlaterutil_p.h
23

I think that we can remove this include no ?

dvratil updated this revision to Diff 83039.May 18 2020, 1:05 PM
  • Remove useless include
dvratil marked 3 inline comments as done.May 18 2020, 1:06 PM
dvratil added inline comments.
agents/sendlateragent/sendlaterutil.cpp
33

Done on line 24.

mlaurent accepted this revision.May 19 2020, 5:08 AM
This revision is now accepted and ready to land.May 19 2020, 5:08 AM
dvratil closed this revision.May 19 2020, 8:46 AM