- change BEFORE to BEFORE_AND_AT, to match actual Qt behaviour (though do not copy confusing name, but be more precise using AND_AT
- add NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE option
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Sep 9 2019
In D23789#527769, @cgiboudeaux wrote:Tests needed :)
Sep 8 2019
Tests needed :)
Implementation prototype for T11490.
Sep 6 2019
Given ECM 5.62 will be tagged this WE and thus the API of the new macro ecm_qtdesignerplugin_widget being frozen, and no-one really gave feedback on the initial API, would take the responsibility and push tonight, unless there is last minute discussion. Only users of the arguments changed here is Okteta (by what lxr.kde.org reports), which are my changes as well and partial motivation for this change.
For convenience still enable CONSTRUCTOR_ARGS_CODE, usually simple string
without ";"
Sep 4 2019
Aug 29 2019
[spam comment removed by sysadmin]
[spam comment removed by sysadmin]
Ah, I didn't realize there was no warning if calling set_package_properties with different properties.
I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.
Aug 28 2019
Compare though all the
Ideally this is set already directly in the Find-module.
for DESCRIPTION and URL properties in the docs https://cmake.org/cmake/help/latest/module/FeatureSummary.html
No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this.
Aug 27 2019
Aug 25 2019
@heikobecker ping!
Aug 22 2019
KF6 is a long time out so I'm abandoning this.
KF6 is a long time out so I'm abandoning this.
Aug 20 2019
Aug 19 2019
Thanks!
Yep, KTextEditor is broken for me, too.
This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394
LGTM
typo--
bump version again
Aug 15 2019
Aug 14 2019
Thanks!
Patch as is fine with me.
But no expert on both flags itself, no idea if there could be sideeffects of having those two now injected as ON to all projects. Possibly best to do global rebuilds of all projects on CI once this lands.
I'm happy with this, +2 from my side.
This shall be compliant with the minimum ECM version set in the project.
Aug 13 2019
Aug 6 2019
Marco explained privately he doesn't want this so I'll move it to my codebase for now until the alternative better thing appears (maybe I'll try to make it appear soon).
In D22958#507299, @nicolasfella wrote:Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well?
Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well?
Aug 5 2019
The patch makes sense. +1
This is the culmination of a patch series that makes About dialogs in Kirigami work reasonably across platforms:
The code is mostly copy-and-pasted together from ECMAddAppIcon.cmake and ECMInstallIcons.cmake.
Ping
Ping
Aug 1 2019
Seems people so far are fine with this, any comments were rather positive. No changes requested.
Jul 31 2019
document behavior and when it was introduced, also enable autouic
Indeed, both good points.
Jul 29 2019
+1, same for AUTOUIC probably?
Just a small principal comment with "supporting-old-versions" hat on.
Cannot give feedback on autorcc itself, never used, so no idea how useful/reliable it is.
+1 I've been using it in several project, it works good. I don't see how this could be misused.
Jul 28 2019
+1 LGTM
- escape strings to be used as strings in C++ code
- use Qt5Core version to decide whether checking only for QtUiPlugin is enough
Jul 27 2019
add more options: DEFAULT_HEADER_CASE, DEFAULT_HEADER_EXTENSION, DEFAULT_ICON_DIR
Accidentally uploaded the wrong diff.
- more code comments
- fix icon file existance check
Jul 26 2019
- API DOX: explain arguments
- add argument to make it work for Okteta's extra code
- avoid rebuilding if generated file did not change
- place generated files in subdir for namespacing
Jul 25 2019
Jul 24 2019
Update CMake minimum required version to 3.1 (for target_sources).
I
Jul 23 2019
I'm not sure if its beneficial to use cmake_parse_arguments here. It seems like it would make the macro harder to understand compared to the current change. I'm also not entirely sure how it would work? I haven't worked with cmake_parse_arguments before.
How about pass it as a TARGET argument using CMakeParseArguments.
You can see documentation about it here: https://cmake.org/cmake/help/latest/command/cmake_parse_arguments.html
LGTM
address cgiboudeaux's comments