Differential D22580

Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh
ClosedPublic
Actions

Authored by apol on Jul 20 2019, 12:14 PM.

Details

Reviewers
albertvaka
krop
Group Reviewers
Frameworks
Commits
R240:685959c3fa78: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh
Summary

It's especially when KDE_INSTALL_USE_QT_SYS_PATHS=OFF that the different environment variables will have to be initialised.
This adds a message that should tell users about the script so they have a hint of what is going on.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 20 2019, 12:14 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJul 20 2019, 12:14 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 20 2019, 12:14 PM
albertvaka added a subscriber: albertvaka.Jul 20 2019, 12:47 PM
albertvaka added inline comments.
kde-modules/KDEInstallDirs.cmake
724

Installing in ${CMAKE_INSTALL_PREFIX}. You will need to run ./prefix.sh to set the environment for this app.

?

apol updated this revision to Diff 62110.Jul 20 2019, 12:49 PM

Improve wording

apol marked an inline comment as done.Jul 20 2019, 12:50 PM
albertvaka accepted this revision.Jul 20 2019, 12:53 PM
This revision is now accepted and ready to land.Jul 20 2019, 12:53 PM
krop added a subscriber: krop.Jul 20 2019, 3:26 PM
krop added inline comments.
kde-modules/KDEInstallDirs.cmake
724

'NOTICE' doesn't exist in CMake < 3.15.

apol marked an inline comment as done.Jul 21 2019, 9:03 AM
apol updated this revision to Diff 62169.Jul 21 2019, 9:04 AM

Support older cmakes

krop accepted this revision.Jul 21 2019, 9:12 AM
krop added a comment.EditedJul 21 2019, 9:28 AM

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true.

apol added a comment.Jul 23 2019, 11:01 AM
In D22580#499015, @cgiboudeaux wrote:

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true.

We can iterate the message too, it's a bit harder to detect if XDG_CONFIG/DATA_DIRS are wrong.

Closed by commit R240:685959c3fa78: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh (authored by apol). · Explain WhyJul 25 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkde-modules/KDEInstallDirs.cmake (4 lines)

Diff 62533

View Options

kde-modules/KDEInstallDirs.cmake

Loading...