disable autouic again - it breaks builds

Authored by sitter on Aug 19 2019, 2:01 PM.



autouic (like automoc) assumes that every ui_*.h include statement it finds
relates to a .ui file that needs generating. this is not always true.

e.g. we have software which generates ui_debug.h which is simply
a qloggingcategory header for the UI category of that software which would
then trip up autouic because it would assume there's a .ui file when there
really isn't one.

unfortunately the ui_ assumption cannot be selectively disabled, so we
can't have explicit listing of .ui in source lists

set(foo_SRCS foo.cpp foo.ui)

without also getting the not particularly compatible include assumptions.
this should be revisited for kf6 since there isn't a technical need for
files to be called ui_*, they could just as well be *_ui or anything else
so as to not clash with autouic assumption.

autorcc does not suffer from this problem so we can leave it enabled, for
now anyway.

Test Plan

sonnet builds again

Diff Detail

R240 Extra CMake Modules
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Aug 19 2019, 2:01 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptAug 19 2019, 2:01 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Aug 19 2019, 2:01 PM
apol accepted this revision.Aug 19 2019, 2:29 PM


This revision is now accepted and ready to land.Aug 19 2019, 2:29 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by bcooksley.
bcooksley removed a subscriber: fusitter.