daandemeyer (Daan De Meyer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2019, 7:03 PM (8 w, 3 d)
Availability
Available

daan.j.demeyer@gmail.com

Recent Activity

Sat, Aug 24

daandemeyer committed R365:8f33ba3ff928: Install modules/ksb/DebugOrderHints.pm. (authored by daandemeyer).
Install modules/ksb/DebugOrderHints.pm.
Sat, Aug 24, 7:47 PM
daandemeyer abandoned D23406: kdesrc-build: install DebugOrderHints.pm.

Closing as kdescr-build has moved to Gitlab.

Sat, Aug 24, 7:16 PM · kdesrc-build
daandemeyer added a comment to D23406: kdesrc-build: install DebugOrderHints.pm.
Sat, Aug 24, 7:15 PM · kdesrc-build
daandemeyer requested review of D23406: kdesrc-build: install DebugOrderHints.pm.
Sat, Aug 24, 4:36 PM · kdesrc-build
daandemeyer updated the diff for D23336: [KDirOperator] Add follow new directories options.

Split followDirectories option into followNewDirectories and followSelectedDirectories options. followSelectedDirectories only applies to tree views. Let me know if you want the option name to include that information.

Sat, Aug 24, 12:16 PM · Frameworks
daandemeyer added a comment to D23336: [KDirOperator] Add follow new directories options.

The use case is showing a project tree view in an application where we want the root of the KDirOperator to stay fixed. The initial motivation for this change was replicating the File Explorer from Visual Studio Code (text editor) where one opens a folder and the file explorer stays fixed at that specific folder until another folder is opened. KDirOperator almost fit this use case except when creating new directories or selecting existing directories, that directory would be made the top level directory in the KDirOperator. When the new option is enabled, the top level directory stays the same when selecting directories or creating new directories which makes KDirOperator behave more like the File Explorer in Visual Studio Code.

Sat, Aug 24, 9:37 AM · Frameworks
daandemeyer updated the diff for D23336: [KDirOperator] Add follow new directories options.

Added default value to documentation.

Sat, Aug 24, 9:27 AM · Frameworks

Fri, Aug 23

daandemeyer updated the diff for D23336: [KDirOperator] Add follow new directories options.

Remove extra unnecessary '&'

Fri, Aug 23, 5:02 PM · Frameworks
daandemeyer added a comment to D23373: KTextEditor: Fix left border flicker when switching between documents.

According to the documentation they should both achieve the same effect. However, Qt::WA_OpaquePaintEvent takes precedence if both are used.

Fri, Aug 23, 2:15 PM · Frameworks, KTextEditor, Kate
daandemeyer updated the diff for D23336: [KDirOperator] Add follow new directories options.

When selecting directories, only disable following directories if a tree view is used (normal or detail).

Fri, Aug 23, 2:05 PM · Frameworks
daandemeyer requested review of D23373: KTextEditor: Fix left border flicker when switching between documents.
Fri, Aug 23, 9:05 AM · Frameworks, KTextEditor, Kate

Thu, Aug 22

daandemeyer added a comment to D23336: [KDirOperator] Add follow new directories options.

That is something I hadn't considered yet. Would it be acceptable to only apply this option when the KDirOperator is configured as a tree view?

Thu, Aug 22, 8:44 PM · Frameworks
daandemeyer added a comment to D23336: [KDirOperator] Add follow new directories options.

Now, with followDirectories set to false, directories simply expand on double click which is what I wanted to achieve. The general behaviour I want to get with this change is to have a project tree view where the root folder stays fixed.

Thu, Aug 22, 6:06 PM · Frameworks
daandemeyer added a comment to D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.

Email: daan.j.demeyer@gmail.com (added to my profile as well)

Thu, Aug 22, 5:30 PM · Frameworks
daandemeyer added a comment to D23336: [KDirOperator] Add follow new directories options.

I changed the option to apply to directories that are double clicked as well. Previously, double clicking a directory would also change the listed url which now depends on whether the option is enabled. Since it applies to both new and existing directories, followDirectories seemed more apt. I'm open to other name suggestions but your suggestions seem to only consider the new directory case (perhaps you missed the added behaviour in the latest revision?).

Thu, Aug 22, 5:26 PM · Frameworks
daandemeyer updated the diff for D23336: [KDirOperator] Add follow new directories options.
  • Address comment
  • Apply option when selecting directories as well
  • Rename to followDirectories
Thu, Aug 22, 5:22 PM · Frameworks

Aug 22 2019

daandemeyer requested review of D23336: [KDirOperator] Add follow new directories options.
Aug 22 2019, 8:57 AM · Frameworks
daandemeyer requested review of D23333: KDirOperator: Only enable "Create New" menu if the selected item is a directory.
Aug 22 2019, 8:12 AM · Frameworks
daandemeyer abandoned D22699: Support passing target to ecm_qt_declare_logging_category.

KF6 is a long time out so I'm abandoning this.

Aug 22 2019, 7:53 AM · Build System, Frameworks
daandemeyer abandoned D22709: Support passing target to ecm_add_app_icon..

KF6 is a long time out so I'm abandoning this.

Aug 22 2019, 7:53 AM · Frameworks, Build System

Aug 17 2019

daandemeyer updated the diff for D23208: Use CMake find_dependency in CMake config file instead of find_package.

Use REQUIRED_QT_VERSION to specifiy required Qt version.

Aug 17 2019, 11:22 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 16 2019

daandemeyer requested review of D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 16 2019, 5:33 PM · Frameworks, Kate, Framework: Syntax Highlighting
daandemeyer committed R40:c5c2676230f5: Rename kate target to kate-lib to fix Windows compilation error (authored by daandemeyer).
Rename kate target to kate-lib to fix Windows compilation error
Aug 16 2019, 3:56 PM
daandemeyer requested review of D23203: Use CMake find_dependency instead of find_package in CMake config file template..
Aug 16 2019, 3:11 PM · Frameworks, KTextEditor, Kate
daandemeyer committed R40:a167b31210a0: Clean up main CMake scripts. (authored by daandemeyer).
Clean up main CMake scripts.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:fdc8a93f52cd: Clean up kate autotests CMake script. (authored by daandemeyer).
Clean up kate autotests CMake script.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:8521250f25a8: Expand leftover `SRCS` abbrevation. (authored by daandemeyer).
Expand leftover `SRCS` abbrevation.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:7985d3a54fd5: Cleanup docs CMake scripts. (authored by daandemeyer).
Cleanup docs CMake scripts.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:458e783209dc: Refactor config.h handling. (authored by daandemeyer).
Refactor config.h handling.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:f99afa4e727a: Rename kateprivate_export.h to katetests_export.h (authored by daandemeyer).
Rename kateprivate_export.h to katetests_export.h
Aug 16 2019, 3:05 PM
daandemeyer committed R40:10fff7e1fb87: Add source file for katewaiter.h. (authored by daandemeyer).
Add source file for katewaiter.h.
Aug 16 2019, 3:05 PM
daandemeyer committed R40:58e195667314: Further cleanup addons CMake scripts. (authored by daandemeyer).
Further cleanup addons CMake scripts.
Aug 16 2019, 10:42 AM

Aug 5 2019

daandemeyer added a comment to D22709: Support passing target to ecm_add_app_icon..

Ping

Aug 5 2019, 6:01 PM · Frameworks, Build System
daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

Ping

Aug 5 2019, 5:59 PM · Build System, Frameworks
daandemeyer added a comment to D22768: Forward declare KLocalizedString and make I18n a private dependency..

Ping

Aug 5 2019, 5:57 PM · Frameworks
daandemeyer added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

To give an example of how the addition would improve KDE CMake build scripts, let's look at part of Kate's CMake build script.

Aug 5 2019, 5:54 PM · Frameworks

Aug 2 2019

daandemeyer added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

Ping

Aug 2 2019, 4:48 PM · Frameworks

Jul 28 2019

daandemeyer added a comment to P434 Masterwork From Distant Lands.

#TypeameMacros: [Q_PROPERTY] should be #TypenameMacros: [Q_PROPERTY]

Jul 28 2019, 9:21 AM

Jul 27 2019

daandemeyer updated the diff for D22699: Support passing target to ecm_qt_declare_logging_category.

Accidentally uploaded the wrong diff.

Jul 27 2019, 12:54 PM · Build System, Frameworks
daandemeyer requested review of D22773: Further clean up addons CMake scripts..
Jul 27 2019, 10:47 AM · Kate

Jul 26 2019

daandemeyer requested review of D22768: Forward declare KLocalizedString and make I18n a private dependency..
Jul 26 2019, 10:47 PM · Frameworks
daandemeyer added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

OK, thanks for the information. I'm still getting familiar with this whole process.

Jul 26 2019, 7:57 PM · Frameworks
daandemeyer updated subscribers of D22698: Support passing target to ki18n_wrap_ui macro.

@alexmerry I think I added the wrong reviewer for this. I noticed your name in the git blame of k18n_wrap_ui, perhaps you know who I should add as a reviewer for ki18n revisions?

Jul 26 2019, 7:25 PM · Frameworks
daandemeyer updated the diff for D22721: Clean up Kate addons CMake scripts..

Diff to latest master as requested.

Jul 26 2019, 12:14 PM · Kate
daandemeyer added a comment to D22721: Clean up Kate addons CMake scripts..

The new revision should fix the compile error

Jul 26 2019, 12:00 PM · Kate
daandemeyer updated the diff for D22721: Clean up Kate addons CMake scripts..

Replace leftover source list variable with an empty string.

Jul 26 2019, 11:59 AM · Kate
daandemeyer added a comment to D22721: Clean up Kate addons CMake scripts..

My bad, I forgot to replace a source list variable with the empty string.
This does not cause errors on the latest CMake versions because it is now
allowed to pass no sources to an add_executable call so I didn't have any
problems locally. The issue is solved by replacing ${ProjectPluginSrc} in
addons/project/autotests/CMakeLists.txt by the empty string ("")

Jul 26 2019, 11:57 AM · Kate

Jul 25 2019

daandemeyer added a comment to D22721: Clean up Kate addons CMake scripts..

@cullmann I think this revision is good to merge now. I was thinking of making a second revision with the changes to the global, kwrite and kate CMake scripts to keep things a bit more manageable. However, those changes depend on this revision so ideally this revision would be merged before I make the second one. Does that sound good to you or should I add the other changes to this revision as well?

Jul 25 2019, 8:20 AM · Kate

Jul 24 2019

daandemeyer added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

I want to keep the changes in KDE Frameworks focused on what's necessary to clean up Kate's CMake scripts. I'll leave the general cleanup for another revision.

Jul 24 2019, 7:18 PM · Frameworks
daandemeyer added a comment to D22721: Clean up Kate addons CMake scripts..

@turbov This is exactly what I've already proposed, See https://phabricator.kde.org/D22698. I've also proposed similar patches for ecm_add_app_icon and ecm_qt_declare_logging_category (https://phabricator.kde.org/D22709, https://phabricator.kde.org/D22699)

Jul 24 2019, 6:50 PM · Kate
daandemeyer updated the diff for D22699: Support passing target to ecm_qt_declare_logging_category.

Update CMake minimum required version to 3.1 (for target_sources).

Jul 24 2019, 6:20 PM · Build System, Frameworks
daandemeyer added a comment to D22721: Clean up Kate addons CMake scripts..

This may be a stupid question but is the TRANSLATION_DOMAIN stuff actually used somewhere? I'm not familiar with how it works. However, I find it strange that its not defined for kwrite and kate but is defined for all plugins.

Jul 24 2019, 6:16 PM · Kate
daandemeyer updated the diff for D22721: Clean up Kate addons CMake scripts..
  • Switched to new recommended style for multi-line commands.
  • Removed escaping from TRANSLATION_DOMAIN definitions as this is done automatically by CMake.
  • Added a few missing PRIVATE's and removed some extra whitespace where needed.
Jul 24 2019, 6:11 PM · Kate
daandemeyer added inline comments to D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:46 PM · Kate
daandemeyer added inline comments to D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:32 PM · Kate
daandemeyer updated the summary of D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:15 PM · Kate
daandemeyer updated the summary of D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:15 PM · Kate
daandemeyer requested review of D22721: Clean up Kate addons CMake scripts..
Jul 24 2019, 5:14 PM · Kate
daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

I

Jul 24 2019, 12:21 PM · Build System, Frameworks
daandemeyer added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 11:18 AM · Build System, Frameworks
daandemeyer added a comment to D22698: Support passing target to ki18n_wrap_ui macro.

Removed the cmake_minimum_required call

Jul 24 2019, 8:07 AM · Frameworks
daandemeyer updated the diff for D22698: Support passing target to ki18n_wrap_ui macro.
Jul 24 2019, 8:06 AM · Frameworks
daandemeyer requested review of D22709: Support passing target to ecm_add_app_icon..
Jul 24 2019, 7:30 AM · Frameworks, Build System

Jul 23 2019

daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

I'm not sure if its beneficial to use cmake_parse_arguments here. It seems like it would make the macro harder to understand compared to the current change. I'm also not entirely sure how it would work? I haven't worked with cmake_parse_arguments before.

Jul 23 2019, 9:51 PM · Build System, Frameworks
daandemeyer requested review of D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 23 2019, 8:27 PM · Build System, Frameworks
daandemeyer added a reviewer for D22698: Support passing target to ki18n_wrap_ui macro: ilic.
Jul 23 2019, 7:27 PM · Frameworks
daandemeyer updated the diff for D22698: Support passing target to ki18n_wrap_ui macro.
Jul 23 2019, 7:16 PM · Frameworks
daandemeyer requested review of D22698: Support passing target to ki18n_wrap_ui macro.
Jul 23 2019, 7:11 PM · Frameworks