I only worked on the visuals of the theme so I'm not 100% sure either, but there is extra dummy data that might be worth looking it, sddm.qml in particular: https://github.com/KDE/plasma-workspace/tree/master/sddm-theme/dummydata

In D21026#472883, @ngraham wrote:

Add checkable: true and click it

restore checkable state

This is indeed not working as in PC2 so the change seems to be OK.

Looks good, but also just add a few words to the description about why we need this.

In D20598#471150, @meven wrote:

In D20598#471149, @filipf wrote:

In D20598#455424, @ngraham wrote:

This doesn't actually work for me. Upon opening, the following is printed to the console:

org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was not found." 
Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", "/usr/bin") 
The environment variable QT_PLUGIN_PATH might be not correctly set
<Unknown File>:3:89: Unable to assign [undefined] to double
QQmlExpression: Expression file:///usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:436:33 depends on non-NOTIFYable properties:
    Solid::Battery::serial

I am now getting the same error as well, kcmshell5 is eating up one cpu core in the background.

I am not focused on this anymore and might abandon this review as I really don't enjoy Qml hacking and lack of good tooling at least in my experience.

In D21026#462978, @mart wrote:

but now it doesn't display the checked state in any way?

@broulik I tried again in master and icon.width and icon.height aren't working for me with this patch.

I agree with David, when doing these sorts of changes it's imperative they're instantly implemented in all relevant places. I checked SDDM (with our theme) and the password field is disabled when in the timeout period so we need to fix that.

Obviously looks better to me since there is alignment.

In D20598#455424, @ngraham wrote:

This doesn't actually work for me. Upon opening, the following is printed to the console:

org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was not found." 
Plugin search paths are ("/usr/lib/x86_64-linux-gnu/qt5/plugins", "/usr/bin") 
The environment variable QT_PLUGIN_PATH might be not correctly set
<Unknown File>:3:89: Unable to assign [undefined] to double
QQmlExpression: Expression file:///usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:436:33 depends on non-NOTIFYable properties:
    Solid::Battery::serial

This font is somewhat oddly narrow i.e. tall. Since I don't use hinting I guess the narrowness is most pronounced in my case. As hinting off = the closest we can get to the original design of the typeface, it's a bit odd that a font designed for high DPI phone screens would have nicer geometry with hinting. With hinting on it looks a bit better than Noto Sans. In general using UI variants is obviously preferable. So +1 ... I'd prefer if we could find a a font with more personality though, but that's still easier said than done.

In D21378#469611, @ndavis wrote:

In D21378#469607, @filipf wrote:

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

I gave it a quick spin with Breeze Dark however and it's just not picking up some color schemes. It remains stuck on the colors of some previous scheme that worked. This seems to be random and may be a bug originating elsewhere so I'm hitting accept.

After changing the system colorscheme, did you try restarting plasmashell or switching to a different desktop theme and switching back? I'll admit, it's a bit janky, but it should work if you do that. It definitely seems like a bug that originates from elsewhere.

So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good solution, +1 for the idea.

In D20585#465924, @mart wrote:

I don't like adding a new property to separator for doing duck typing...

even is really ugly and errorprone as well, but i would prefer
Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0

with a comment:
// FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11

minor fix

use mart's solution

In D20972#465912, @davidedmundson wrote:

When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it

From what? Should they be there?

fix

In D21279#468029, @davidedmundson wrote:

This is an ugly hack.

ActionItems ultimately end up in
SessionManagementScreen.qml:113

Row {
id: actionItemsLayout
}

A Row has a spacing property.

It would be really cool if we could have some icon that would signalize that a particular desktop theme is color-scheme aware.

In D21312#467721, @ndavis wrote:

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

In D19631#467170, @rikmills wrote:

! In D19631#467167, @filipf wrote:

Why does it look different than Neon?

Seems neon have a settings tweak to force more font Noto (especially for sddm).

Cherry picking that...

In D19631#467156, @rikmills wrote:

Not looking good.

height=width

+1 from a visual POV

In D21027#464443, @broulik wrote:

I tried to set icon.width and icon.height but it doesn't do anything.

In desktop style that should work since D20418

You were too quick for me but just wanted to say: nice!

• change easing type from InOutQuad to InOutQuart to improve behavior when clicked fast
• shorten the animation for the same reason

In T10875#184502, @ngraham wrote:

Here would be some pieces of advice that I could offer:

• It's encouraged to emulate the pastel geometric style of prior wallpapers; try to avoid unmodified photographs
• Avoid large areas of super bright colors, as these can be visually overwhelming and look uncomfortable when closing or minimizing windows
• Consider how lots of desktop icons would appear when placed on top of your wallpaper. To ensure that their labels remain readable, try to avoid very visually noisy or busy elements, particularly on the left side
• Don't add text or logos on top of your wallpaper; however the Plasma logo is permissible if it is integrated as a key design element

• use Kirigami.Theme for color, remove syspal
• replace ListView Item with Control and have it be the delegate
• replace Text with Label and have it be ListView's contentItem

Everything looks good to me now!

• add space after comment slashes
• add punctuation in the comments for the added function

Hmm I can't set the number of columns anymore when in vertical position.

remove some hack I was working on for scrollbar color

write a function for text and icon colors so as to not duplicate code everywhere

@mart does this look good to you? As you're the author I wouldn't want to merge without your approval.

Here's what I'm trying to avoid:

So I looked up Google's documentation and it turns out sliders do have to be mirrored:
https://material.io/design/usability/bidirectionality.html#mirroring-elements
https://material.io/design/components/sliders.html#usage

fix handle behavior for right to left layouts

In D21075#462419, @broulik wrote:

Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think visualPosition is what we want to be using

In D21075#462393, @broulik wrote:

-1
This breaks the slider in right-to-left mode. Run qmlscene -reverse to see

In T10875#184332, @ngraham wrote:

I'm noticing that a lot of entries have the KDE logo or the Plasma name or version number embedded in it. I feel like this is kind of tacky and not really appropriate given that our prior wallpapers didn't do this, but we didn't make a rule prohibiting it. I'm tempted to recommend that we retroactively do so and ask the people who have submitted such wallpapers to remove those elements. Thoughts?

I'm going to look into the different easing curves a bit more because I sometimes see the semi-scaled circle if clicking too fast.

• remove ID
• height = width
• use and animate scale instead of height & width

Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to Theme.View instead