Make the icon applet use the same shadow settings as desktop icons
ClosedPublic

Authored by filipf on Sun, Jun 2, 5:17 PM.

Details

Summary

We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Sun, Jun 2, 5:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jun 2, 5:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Sun, Jun 2, 5:17 PM
ngraham accepted this revision.Sun, Jun 2, 5:18 PM
ngraham added a subscriber: ngraham.

Stable branch please!

This revision is now accepted and ready to land.Sun, Jun 2, 5:18 PM
filipf edited the test plan for this revision. (Show Details)Sun, Jun 2, 5:18 PM
filipf added a reviewer: VDG.
filipf edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
filipf added a comment.EditedSun, Jun 2, 8:12 PM

Sorry for not using merge, can someone please update the wiki (https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22) or explain the case when landing on 2 stable branches because it wouldn't merge when I was doing step 2 for 5.16.

EDIT: I figured out what I was doing wrong, my bad!

In step 2, you need to merge 5.12. It asks you which branch you want to merge into the current one.