Support custom icon size for ToolButton
ClosedPublic

Authored by broulik on Apr 9 2019, 9:19 PM.

Details

Test Plan

Copied from PushButton

ToolButton {
    icon.width: 128
    icon.height: 128
    icon.name: "help-about"
    text: "About"
    display: AbstractButton.TextUnderIcon
}

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 9 2019, 9:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2019, 9:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 9 2019, 9:19 PM
apol accepted this revision.Apr 9 2019, 9:47 PM
This revision is now accepted and ready to land.Apr 9 2019, 9:47 PM

What's the use case, out of curiosity?

@laysrodrigues asked for it. I don't think there's a usecase for a "proper" desktop app, but having an API in Qt that we then silently ignored is bad, especially since it works fine with a regular Button

This revision was automatically updated to reflect the committed changes.