Using the Plasma theme, when only a label exists in a toolbutton, without filling the width of the rowlayout, the label is not properly aligned in the center.
Details
Details
- Reviewers
filipf - Group Reviewers
Plasma VDG - Commits
- R242:cd8b6b71cebc: Fix the alignment of the label of the toolbutton
Fill a rectangle with a label-only toolbutton. Before patching label is not aligned in the center.
In these pictures, the day numbers are labels of a (repeated) ToolButton that fills a Rectangle.
Before:
After:
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Before-and-after screenshots in the Test Plan section are very helpful for patches like this. :)
Comment Actions
This is indeed not working as in PC2 so the change seems to be OK.
I used the following code to test in qmlscene
import QtQuick 2.12
import org.kde.plasma.components 3.0 as PlasmaComponents
Rectangle {
width: 50
height: childrenRect.height
color: "black"
PlasmaComponents.ToolButton {
text: "1"
width: parent.width
}
}