[sddm-theme] Add spacing between action buttons' labels
ClosedPublic

Authored by filipf on May 18 2019, 10:45 PM.

Details

Summary

Currently there is no spacing between the labels of action buttons, leading to crammed text with longer translations which are not split up into more rows.

BUG: 407704

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.May 18 2019, 10:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 18 2019, 10:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 18 2019, 10:45 PM
filipf edited the test plan for this revision. (Show Details)May 18 2019, 10:46 PM
filipf added reviewers: VDG, Plasma, ngraham.
filipf edited the summary of this revision. (Show Details)
filipf updated this revision to Diff 58269.May 18 2019, 11:11 PM

height=width

ngraham accepted this revision.May 20 2019, 2:14 PM

Stable branch please!

This revision is now accepted and ready to land.May 20 2019, 2:14 PM
This revision was automatically updated to reflect the committed changes.

This is an ugly hack.

ActionItems ultimately end up in
SessionManagementScreen.qml:113

Row {
id: actionItemsLayout
}

A Row has a spacing property.

This is an ugly hack.

ActionItems ultimately end up in
SessionManagementScreen.qml:113

Row {
id: actionItemsLayout
}

A Row has a spacing property.

Thanks, I was looking for some sort of a Row(Layout), but as I was expecting it to be in ActionButton.qml I couldn't find it. Will push a fix reverting this and adding spacing in the SessionManagementScreen.qml.