This patch replaces the ColumnLayout with Kirigami.FormLayout and make use of twinFormLayouts to link child layout with parent layout.
QQC1 comboboxes are retained due to a QQC2 bug with resizing the popup to delegate width.
ngraham |
Plasma | |
VDG |
This patch replaces the ColumnLayout with Kirigami.FormLayout and make use of twinFormLayouts to link child layout with parent layout.
QQC1 comboboxes are retained due to a QQC2 bug with resizing the popup to delegate width.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
If it's not getting set on load, the problem is probably somewhere in those funky for loops to get and set the value of the combobox.
The problem though I've run into with having QQC1 Combobox in the Form Layout is all the code that was used to fix its width stops working:
property int textLength: 24 width: theme.mSize(theme.defaultFont).width * textLength
And then we get quite narrow, elided comboboxes which don't match the width of the QQC2 comboxes from ConfigurationContainmentAppearance.qml. Will investigate if I can write some new code to hack the width, though my rationale here was that the QQC2 combobox was the lesser evil.
Hah yeah, possibly, although it works just fine with the QQC1 Combobox.
I could set the width of the QQC1 combobox to match the QQC2 ones above, but it won't get resized if a wider entry is selected (as is the case with QQC2). Thoughts on how to proceed?
EDIT: ignore this, I've made them resizable.
Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese:
wallpapers/potd/contents/ui/config.qml | ||
---|---|---|
76 | This should not be plural and should probably say "Provider:" or maybe even "Source:". |
We need to set a maximum width. Here's what I can do:
End result:
Hmm, setting a maximum width is kind of lousy for really long strings though, because they get elided. I think it might make more sense to make sure that the window expands to accomodate a wide combobox, and them trim down that particular string. It's just way too long right now.
Few changes needed to the Description before landing: