Make the Trashcan applet use the same shadow settings as desktop icons
ClosedPublic

Authored by filipf on Sun, Jun 2, 5:05 PM.

Details

Summary

We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Trashcan applet which renders its own label and shadows.

Settings have been copied. This also made it obvious that the label will be blurry with non-integer placement so a workaround for that is also provided.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Sun, Jun 2, 5:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Jun 2, 5:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Sun, Jun 2, 5:05 PM
filipf edited the summary of this revision. (Show Details)Sun, Jun 2, 5:07 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
ngraham accepted this revision.Sun, Jun 2, 5:18 PM

Huh, how about that.

Stable branch please.

This revision is now accepted and ready to land.Sun, Jun 2, 5:18 PM
filipf added inline comments.Sun, Jun 2, 5:34 PM
applets/trash/package/contents/ui/main.qml
155

Should I copy all of the code from FolderItemDelegate.qml? It's:

width: Math.round(Math.min(label.implicitWidth + units.smallSpacing, parent.width - units.smallSpacing))

ngraham added inline comments.Sun, Jun 2, 5:42 PM
applets/trash/package/contents/ui/main.qml
155

Not necessary since this is a free-floating applet rather than an item in a grid, so we don't need any of the parent-related logic.

This revision was automatically updated to reflect the committed changes.