The former scaling of the x-Positions of the data points did not fit to the time axis.
Now the x-values of the points, i. e. their timestamps, are correctly aligned.

Remove redundant semicolons and move comment about unit (ms) to the declaration of the var

Use a switch statement for xTicksAt

*Friendly ping to the reviewers.*

I think I should exclude the headlines in a following patch.

Set correct right border for the grid lines and ticks.

Move stroke() out of the loop.
Reduce line with by pixel.

Shrink plotWidth a little bit so the earliest date on the right side may fit.
Change the way the division widths are defined to hopefully make the code easier to understand
and to maintain.

For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs.

I have changed some stuff, can you please review it again.

Rename variables to make their function clearer.
Decrease the lower loop border by 1 to make sure that all
possible grid lines are drawn.

Fix issue that a date may be displayed unintentionally.
Shrink right margin for grid lines and try to add an additional grid line
on the right side if reasonable.
Add more divisions for 2h and 24h graphs.

Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint.
Rename variable to make its function clearer.
Show grid lines at all five minutes for the 1 hour graph.

Align grid to 10 minutes for the 1h graph.

Set valid defaults.

• Set valid defaults.

In D23464#524994, @ndavis wrote:

Looks like you've got everything

16px: add 2px margins to top and bottom
22px: add 3px margins to top and bottom
32px: use existing and approved 32px icon as template instead of shrinking the 64px version

Remove all circles and only use root symbol.
This makes the root symbol less faint and the icons fit better to Breeze overall.

In D23464#522270, @trickyricky26 wrote:

As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep the icon looking as intended with the Qt SVG renderer

The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint.

Add new 32px icons.

Also add the new 64px breeze icon.
Add new 22 px icons. Transparent background, less faint, original color.

In D23464#521662, @ndavis wrote:

I think we should use #1ed4e5 for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess anyway and I don't think it's worth worrying too much about unless Breeze's official color palette is expanded.

Improve the root logo layout and change the root's color to the offical color 1ED4E5

Right now I only display the date under the tick mark if the date has changed and the tickmark number is odd, which I think is already good enough for this graph.
However, indicating a date change at midnight (12 pm / 0 am) would make sense as well. If you prefer that and find a suitable position for the indicator label, I may implemement it.

Fix displaying wrong variable.
Add postfix "Str" to indicate that those vars are explicitely strings.
Make sure that the date is only displayed when date has changed for <= 24h graphs.

Improve the formatting's consistancy

Update comment

Omit the date if date equals today and the graph does not range over 24 hours.

Resolve formatting issues

I am not sure if I am allowed to intervene in this discussion, but "smart" is a really "dumb" description as it says nothing about what it actually does.
As a user I am left to do four things to find out, what it means:

Set more sane left/right margins

Set correct default value for a tick position

In D23465#519586, @yurchor wrote:

Yes. The maintainers of shared-mime-info will tell you if the type is right (I think, that it would be better to use <mime-type type="application/root">, similar to PDF, but I might be wrong).

In D23465#519544, @ltoscano wrote:

The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file is meant to contain a limited number of entities and possibiy disappear over time.

Sorry, for some reason it was easier for me to abandon this revision and to reopen another one here: https://phabricator.kde.org/D23464

Here's a testfile for the defined mime type:

For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doing wrong?

I am not against a better version, but the culprit is that I am no designer.
For anything more complicated we would need an icon/svg.

Is the triangle set? How about such a triangle:

https://www.netclipart.com/pp/m/120-1201455_play-button-png-video-youtube-youtube-video-play.png

I can imagine that it can be discerned better due to the dark background casted on the image preview within the outer white ring.
For Breeze Dark, the colors could become inverted.

for various technical reasons that are not yet fixable

DnD is not very intuitive for things that don't look inherently draggable

Just brainstorming: What about two sections, 1) "default" with a single entry and 2) "others".
The user could drag and drop the speaker to default place and the current default one would move downwards with an animation.

In D23237#514325, @broulik wrote:

It literally says in the commit message that this will be moved exactly there.

In which GUI do I find "Vendor" and "Model" now? There's the "Energy Information" in KInfocenter, which
has a section "manufacturer" (in screenshot "Hersteller"), but only lists the serial number. Maby it could go there?

In T11124#195411, @ndavis wrote:

Friendly ping. :-)

In D22493#496764, @ngraham wrote:

Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like.

For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though.

You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part.

I would like to test it and post a screenshot, however I am not able to compile it:

1. I cloned the source from the git repository
2. mkdir plasma-workspace/applets/notifications/build
3. cd plasma-workspace/applets/notifications/build
4. cmake ..

This patch looks more like a workaround to me. I'd suggest to identify the root cause of "^C" and "cd <path>" whenever the terminal is hidden and reopened again by hitting F4 and to find a another solution as I guess and especially hope that this behaviour is actually not necessary to happen.

In D18809#408482, @davidre wrote:

Do you mean the Controls on the top? (...) Please correct me if I'm wrong.

Great work!

In D18744#405851, @ngraham wrote:

Seems sane enough to me. However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some familiarity there?

In D17354#372274, @ngraham wrote:

Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab:

In T9658#169557, @filipf wrote:

Yeah it bothers me as well. The problem with black text is that it often doesn't offer satisfactory legibility:

In T9658#169496, @filipf wrote:

If a lot of things were possible, this is how I'd do the SDDM theme design.