[Notifications] Move history items' icons over to the left a bit
Needs RevisionPublic

Authored by ngraham on Jul 16 2019, 4:20 PM.

Details

Reviewers
broulik
filipf
Group Reviewers
VDG
Plasma
Summary

Move the expired history items' icons over a bit so there isn't such an icon soup
on the right-hand side of the widget. This patch makes the icons vertically aligned
with the configure button, not the close button.

BUG: 409855
FIXED-IN: 5.16.4

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Branch
tweak-history-icon-placement (branched from Plasma/5.16)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14015
Build 14033: arc lint + arc unit
ngraham created this revision.Jul 16 2019, 4:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2019, 4:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 16 2019, 4:20 PM
ngraham edited the summary of this revision. (Show Details)Jul 16 2019, 4:20 PM

Is it just me or does vertical alignment look off now? How does it affect the popup layout?

ndavis added a subscriber: ndavis.Jul 17 2019, 9:36 AM

Is it just me or does vertical alignment look off now? How does it affect the popup layout?

Doesn't seem different from the current vertical alignment.

Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like.

No, no, leave the popup :P I was asking to make sure it doesn't accidentally change the popups.

alexde added a subscriber: alexde.Jul 21 2019, 11:30 AM

Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like.

Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked like that:

Friendly ping. :-)

filipf requested changes to this revision.Jul 29 2019, 10:50 PM
filipf added a subscriber: filipf.

Yeah this affects popups as well

Before:

After:

This revision now requires changes to proceed.Jul 29 2019, 10:50 PM