[Digital clock plasmoid] Calendar settings page: port to QQC2 & Kirigami and improve layout
ClosedPublic

Authored by ngraham on Tue, Dec 4, 6:09 PM.

Details

Summary

BUG: 400663
FIXED-IN: 5.15.0

Test Plan

Before:

After:

(label alignment being a bit off is unrelated to this patch)

Everything still works.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Tue, Dec 4, 6:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Dec 4, 6:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Tue, Dec 4, 6:09 PM
ngraham edited the test plan for this revision. (Show Details)Tue, Dec 4, 6:10 PM
ngraham updated this revision to Diff 46855.Tue, Dec 4, 6:14 PM

Make sure it's centered

ngraham edited the test plan for this revision. (Show Details)Tue, Dec 4, 6:14 PM
zzag added a subscriber: zzag.Tue, Dec 4, 6:16 PM

Just wondering, shouldn't it look like

Available plugins: [ ] Astronomical events
                   [ ] Holidays

?

In D17354#371239, @zzag wrote:

Just wondering, shouldn't it look like

Available plugins: [ ] Astronomical events
                   [ ] Holidays

?

That was my first thought too, but this whole list of checkboxes/plugins is dynamic, so putting the label on the left for the first item is a bit challenging.

Though maybe this reveals that we should be using a list box instead of a dynamic set of checkboxes.

abetts added a subscriber: abetts.Tue, Dec 4, 6:22 PM

Would you want to move the General section to the top and plugins second?

In general, general labels maybe belong to the very top of a KCM? To me, it seems like a more logical progression. From all items to more specific items.

In D17354#371239, @zzag wrote:

Just wondering, shouldn't it look like

Available plugins: [ ] Astronomical events
                   [ ] Holidays

?

That was my first thought too, but this whole list of checkboxes/plugins is dynamic, so putting the label on the left for the first item is a bit challenging.

Though maybe this reveals that we should be using a list box instead of a dynamic set of checkboxes.

It should be possible, how about adding "Available Plugins" in an item that has the exacth same height with the QtControls.CheckBox ?
at least this was one of the tricks I used for: https://cn.opendesktop.org/img/7/a/f/8/d62284cb18eb3f6c6aaabc9b58f474cb1475.png

OK, if I give the ColumnLayout a label, it mostly works, but the label is vertically centered rather than being top-aligned:

ngraham updated this revision to Diff 46872.EditedTue, Dec 4, 8:47 PM
  • Move General section back to the top, where it belongs
  • Use a left label for the plugin section (currently buggy pending a Kirigami patch: D17362)
ngraham edited the test plan for this revision. (Show Details)Tue, Dec 4, 8:48 PM
abetts added a comment.Tue, Dec 4, 8:49 PM

Thank you!

ngraham updated this revision to Diff 46967.Thu, Dec 6, 3:14 PM

Align the label to the first child properly

ngraham edited the test plan for this revision. (Show Details)Thu, Dec 6, 3:15 PM
davidedmundson accepted this revision.Thu, Dec 6, 3:52 PM
This revision is now accepted and ready to land.Thu, Dec 6, 3:52 PM
alexde added a subscriber: alexde.EditedThu, Dec 6, 6:34 PM

Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab:

General

[  ] Show week number

Available plugins

[  ] Plugin A
[  ] Plugin B

That's would I personally would favor.

Kind Regards

Thank you Nate! I am just curious if you considered to structure titles and options vertically, where the options are indented by a tab:

Yes, quite a bit. This current layout style is the result of an enormous amount of internal discussion. There is no one style that pleased everyone, but this is the one that was most popular and generally considered the most attractive and pleasant to use overall. Again, you can't please everybody especially in matters of style and design, but this style seemed overall to be the favorite when we were trying to figure what we should standardize on.

Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

This revision was automatically updated to reflect the committed changes.
alexde added a comment.Thu, Dec 6, 7:02 PM

Changing the style just here would introduce inconsistency at a time when we're trying to make everything more consistent. The current FormLayout style is what we've decided on for the moment and I think it makes sense to fully implement it before we think about replacing it with something else. :)

Sounds reasonable to me! ;) Can you please point me to the discussion? Thanks!