Set notifications entry icon size to medium
AbandonedPublic

Authored by alexde on Jul 21 2019, 9:30 AM.

Details

Reviewers
None
Group Reviewers
VDG
Summary

The current history entry icon is rather large and therefore
hits the bottom of the entry in the list.
As the margin between two entries is small, it looks more clear
overall if the icon becomes smaller.

BUG: 409855

Diff Detail

Repository
R120 Plasma Workspace
Branch
plasma-nm-applet (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14200
Build 14218: arc lint + arc unit
alexde created this revision.Jul 21 2019, 9:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2019, 9:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alexde requested review of this revision.Jul 21 2019, 9:30 AM
alexde retitled this revision from Set plasma-nm history entry icon size to medium to Set notifications entry icon size to medium.Jul 21 2019, 9:35 AM

I would like to test it and post a screenshot, however I am not able to compile it:

  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..

This resulted in

CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json):
  Unknown CMake command "kcoreaddons_desktop_to_json".
  1. I then added
find_package(KF5Plasma REQUIRED)

to the CMakeLists.txt, which at least make cmake succeed. However, when I tried to compile it with

  1. make

It breaks with

Scanning dependencies of target plasma_applet_notifications
[ 20%] Building CXX object CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o
/path/KDE/plasma-workspace/applets/notifications/notificationapplet.cpp:27:10: error: QQuickItem: File or directory not found
   27 | #include <QQuickItem>
      |          ^~~~~~~~~~~~
Compilation terminated.
make[2]: *** [CMakeFiles/plasma_applet_notifications.dir/build.make:63: CMakeFiles/plasma_applet_notifications.dir/notificationapplet.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:233: CMakeFiles/plasma_applet_notifications.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

I have the Qt development and kcoreaddons' files installed. I thought this procedure would be more straight forward. I'm looking forward to your advice. :)

pino added a subscriber: pino.Jul 21 2019, 10:09 AM

I would like to test it and post a screenshot, however I am not able to compile it:

  1. I cloned the source from the git repository
  2. mkdir plasma-workspace/applets/notifications/build
  3. cd plasma-workspace/applets/notifications/build
  4. cmake ..

    This resulted in ` CMake Error at CMakeLists.txt:11 (kcoreaddons_desktop_to_json): Unknown CMake command "kcoreaddons_desktop_to_json". `

You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part.

You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part.

What I also needed to install is

kdesignerplugin

then

So the procedure is as follows:

  1. cd plasma-workspace (root folder)
  2. cmake -DCMAKE_INSTALL_PREFIX=/usr .
  3. cd applets/notifcation
  4. make -j6
  5. sudo make install
  6. Log out & log in

Is there a simly way to not override my working plasma desktop files?

I am now going to attach the screenshot above.

alexde edited the summary of this revision. (Show Details)Jul 21 2019, 11:06 AM

For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though.

alexde added a comment.EditedJul 21 2019, 11:08 AM

For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though.

I have to admit, that I'm not very much satisfied myself with the size. It could be a bit larger, something between medium and large. Maby we should discard it again. :P

And unfortunately it does change the popups somehow,


despite what Nate said:

Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like.

pino removed a subscriber: pino.Jul 21 2019, 11:09 AM
alexde abandoned this revision.Jul 21 2019, 11:20 AM