Let's put this on the Navigation page. It's not a perfect fit, but I think makes sense to hide it there so it doesn't clutter up the General page. Also, most if the possible actions are navigation-related, and it's invoked by double-clicking in the view, which is a navigation area.

You don't have commit access, do you?

No, I don't.

Is "Piotr Henryk Dabrowski <phd@phd.re>" fine as git authorship?

Yes.

Thanks, LGTM now.

In D22444#496089, @elvisangelaccio wrote:

Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages

Done.

There seems to be another issue: if I run dolphin <some folder> from cmd line I always get Add 'file' to place, no matter what the folder is.

• Re-enable action when nothing is selected
• Display name of item that will be added to Places for clarity, to support the above

In D7446#503575, @meven wrote:

I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into recentlyused:/ ioslave D22144)

This will allow us to provide similar filters as timeline:/ has : accessed today, accessed yesterday...
And perhaps replace timeline:/ default entries in places, at least when baloo is turned off.

And since I am also adding date range filtering, I ask what date range would we want to have ?

My proposition would be: today, yesterday, this week (today and the previous 6 days) and maybe this month.
No more than 4, for sure, maybe three would be enough.
But I am all ears for inputs.

@elvisangelaccio ping.

The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the rights of the owner of the file are returned and on Windows the rights of the current user are returned. "

Small fix for the "Open Preferred Search Tool" as a toolbar button.

As a person who opened https://bugs.kde.org/show_bug.cgi?id=391677 I would like to note that it is not in fact a duplicate of https://bugs.kde.org/show_bug.cgi?id=384798
My reasoning for opening that bug was because baloo is sometimes very unreliable at finding anything on my machine. And thanks to solid state drives there is no issue of waiting for spinning rust so lack of indexing is not an issue, also you could argue that indexing is a privacy risk.

In D22594#503270, @elvisangelaccio wrote:

In D22594#498890, @ngraham wrote:

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Where? Do we have an open wish on bugs.kde.org ?

In D22594#503270, @elvisangelaccio wrote:

I'd like to remind that the menubar is hidden by default and the average user won't know about the CTRL+Shift+F shortcut.
So is this feature only aimed at advanced users who expect CTRL+Shift+F to do something?

I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into recentlyused:/ ioslave D22144)

In D22420#503317, @elvisangelaccio wrote:

I'd still like to understand what happend at the change in 4e40fe810d324.

@ngraham Any idea?

On autoplay mode when a media file has already been previewed once, a none media file was previewed, and the media file is being previewed again, play it automatically as the autoplay implies

I'd still like to understand what happend at the change in 4e40fe810d324.

Thanks, going to push to 19.08 :)

Well, I like that we are replacing 20+ lines of code with only one ;)

In D22594#498890, @ngraham wrote:

As for the feature itself, for the past few years I'd been opposed to this, on the basis that people should just use the built-in Baloo-based search instead. But unfortunately the requests keep coming in

Code looks good, but I spotted a regression: 'Add to Places' is now disabled if you don't select any folder. Currently it is possible to add the current folder as place without the need for any selection.

I like this solution better. I'll push on master only for now, and we'll see if we break something ;)

Ping!

Refresh the preview when a video is hidden, in auto-play mode avoid restarting a video that has been stopped when resizing the panel

Oops, I had a perception that you have to press - twice to zoom out. Maybe it came to me from Windows.

You're not blind, but that's how keyboard shortcuts look in KDE software.

If I am not blind, it shows ctrl+-. :)

In D22444#502241, @shubham wrote:

Shouldn't the zoom out shortcut be ctrl-- or is it already occupied?

Shouldn't the zoom out shortcut be ctrl-- or is it already occupied?

The HIG is silent on the matter, but Okular and Konsole put the reset action in the middle, so I think it makes sense to do the same here.

Does our HIG say the order is In/Out/Reset or In/Reset/Out?

@elvisangelaccio This is now ready for review.

Add new action to View menu properly

Sure, I'd be happy to.

Thanks for proposing it! In general we track individual bugs and feature requests in bugs.kde.org, not here on Phab. Phab is best used for task coordination for projects that require multiple bugfixes or close work across multiple repos.

other than building, please also check that it actually still works on Linux

In D22444#501560, @ngraham wrote:

@shubham are you able to make those changes?

In D22727#501824, @vonreth wrote:

Looks good.
Why not the first time 😊

Looks good.
Why not the first time 😊

Rebase

@elvisangelaccio Ping. As it has a string change, this has now missed 19.08. :(

@shubham are you able to make those changes?

Use QStringLiteral only check for commas in string once to check for multiple values parameters, typo

Remove the current option to filter on curent application as it does not work

In D7446#500913, @ngraham wrote:

With your awesome new recentlyused:/ ioslave, I find myself wondering if the old timeline:/ ioslaves even still have value, and if it makes sense to have them in the Places Panel by default.

With your awesome new recentlyused:/ ioslave, I find myself wondering if the old timeline:/ ioslaves even still have value, and if it makes sense to have them in the Places Panel by default.

Use recentlyused:/ ioslave introduced in D22144

Avoid playing a paused video when autoplay is on and the panel is resized

This should be backported to Applications/19.08.

Check the video is not already playing the current file before resetting the video preview state

thanks Hannah!

Disallow getting mimetype or stating non root path

:p

I'll not leave it like this from next time, that's for sure. :p

Indeed. I assumed it wasn't in your actual commit log (bad idea, for this exact reason). Phabricator often shows outdated descriptions compared to the commit log (unless people use arc diff --verbatim) so I stopped complaining about the description.... Clearly I should have done it anyway :)

I did some more testing, and everything seems to work fine:

$ sudo su
# cd /usr/share/applications

# sleep 2 && mv org.kde.kfind.desktop org.kde.kfind.desktop_    # no KFind now

# sleep 2 && mv org.kde.kfind.desktop_ org.kde.kfind.desktop    # KFind installed

Actions to test (KFind installed/not installed):

• menubar -> Tools -> Open KFind/none
• Control toolbutton (menubar hidden) -> Tools -> Open KFind/none
• [Settings] -> Configure Shortcuts... -> shortcut for Open KFind/Open Preferred Search Tool in the list

No problem. I'm glad it works :)

should've removed WIP before landing 😬

yeah I can push! I'm a GSoCer lol

Thanks for your persistence :-)

updated!

Well now I'm embarrassed to admit that I probably didn't. I think I updated it but forgot to compile lol. Sorry for wasting your time!

Hmm... Are you using the latest diff (https://phabricator.kde.org/D22594?id=62212)?