AndreyYashkin (Andrey Yashkin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 7 2019, 6:22 AM (22 w, 3 d)
Availability
Available

Recent Activity

Aug 21 2019

AndreyYashkin added a comment to T10783: Right-click on touch.

MouseArea.pressAndHold runs based on the synthesised left press event, I don't see anything in your code which would prevent a conflict there.
Same for any widget code that uses a current QTapAndHoldGesture

Aug 21 2019, 9:11 PM · Plasma, VDG
AndreyYashkin added a comment to T10783: Right-click on touch.

IIRC the objection was that making press-and-hold always mean right-click at the toolkit level could interfere with apps that want to re-implement the press-and-hold behavior for some other behavior. For example a lot of Android apps use press-and-hold to mean "make this list/view editable".

Personally I think a consistent behavior is more important, but I understand that it is a concern.

Aug 21 2019, 7:32 PM · Plasma, VDG
AndreyYashkin added a comment to T10783: Right-click on touch.

No, we need exactly right click events. They are too important for many apps. For instance, how will we mark the cells in KMines without right click event? I backported my patch on 5.12 in order to replace native Qt version under Kubuntu and now I can successfully mark and unmark the cells.

Aug 21 2019, 6:04 PM · Plasma, VDG

Aug 19 2019

AndreyYashkin added a comment to T10783: Right-click on touch.

I made a patch which adds ability to emulate right click for Qt widgets which do not accepted touch events, but Qt devs say "such a feature should live in the platform itself (not in Qt), e.g. at the driver level or similar". So we have a strange situation when libinput (driver devs) have no plans to add right-click emulation to libinput, because it is the wrong layer of the stack and KWin devs think so, but Qt devs believe that it shall by done somewhere on this layer.

Aug 19 2019, 2:30 PM · Plasma, VDG

Aug 18 2019

AndreyYashkin requested review of D23246: Fix crash on "Close Current Tab" handling.
Aug 18 2019, 7:56 PM · Konsole

Aug 14 2019

AndreyYashkin added a comment to D23146: In confirm close dialog, remove 'close current tab' option.

Hmm, can you explain why you think this is an improvement? To me it seems sensible enough to warn people that closing a tab (even if it's the only tab) will kill the running program.

Aug 14 2019, 2:34 PM · Konsole
AndreyYashkin requested review of D23146: In confirm close dialog, remove 'close current tab' option.
Aug 14 2019, 9:08 AM · Konsole

Aug 7 2019

AndreyYashkin added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

Ping?

Aug 7 2019, 9:33 PM · Dolphin
AndreyYashkin requested review of D23012: Fix an incorrect text bounding rectangle calculation inside the sidebar.
Aug 7 2019, 9:31 PM · Okular

Jul 29 2019

AndreyYashkin added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

I'd still like to understand what happend at the change in 4e40fe810d324.

@ngraham Any idea?

Jul 29 2019, 7:31 AM · Dolphin

Jul 28 2019

AndreyYashkin added a comment to R318:dc586ada63d1: Fix name grouping feature for cyrillic names.

@elvisangelaccio, you have forgotten or I did not say clear enough that it is the previous cosmetic cosmetic version(Diff 61904) that was correct! Read my remark again in the revision conversation, please. @hein did not respond and I cannot say even if this one is fully correct for Korean. The one line solution does groupping of some Cyrillic symbols, which cannot be grouped toggether(aleast in Russian dictionary)
This was my fall. Sorry again for it.

Oh, I see.

So should we revert this commit or are you going to post another patch on top of it?

Jul 28 2019, 5:38 PM
AndreyYashkin updated subscribers of R318:dc586ada63d1: Fix name grouping feature for cyrillic names.

@elvisangelaccio, you have forgotten or I did not say clear enough that it is the previous cosmetic cosmetic version(Diff 61904) that was correct! Read my remark again in the revision conversation, please. @hein did not respond and I cannot say even if this one is fully correct for Korean. The one line solution does groupping of some Cyrillic symbols, which cannot be grouped toggether(aleast in Russian dictionary)
This was my fall. Sorry again for it.

Jul 28 2019, 5:10 PM

Jul 27 2019

AndreyYashkin added a comment to D22386: Fix an issue with a new tab focus.

Ping!

Jul 27 2019, 1:54 PM · Dolphin

Jul 21 2019

AndreyYashkin added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

Friendly ping!

Jul 21 2019, 8:41 PM · Dolphin
AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

Previous Diff 61904 was correct.

Did that work also with Korean?

Jul 21 2019, 8:30 PM · Dolphin

Jul 18 2019

AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

I am sorry. I was so happy with this simple solution that forgot about one impornat aspect which is different from from language to language. If in a German dictionary 'O' and 'Ö' would be in the same group, in Russian 'Е' and 'Ё' or 'И' and 'Й' can never be together like new patch does. Probably, it is applicable to Korean, but in doesen't solve problem for all languages.

Jul 18 2019, 10:55 AM · Dolphin
AndreyYashkin updated the diff for D22303: Fix name grouping feature for cyrillic names.

I used @hein idea to apply normalization which is implemented in unicode. Now it seems to be the final solution without working with particular writing system individually.

Jul 18 2019, 10:05 AM · Dolphin

Jul 17 2019

AndreyYashkin updated the diff for D22303: Fix name grouping feature for cyrillic names.

Fixed brackets and spaces style

Jul 17 2019, 11:39 AM · Dolphin

Jul 16 2019

AndreyYashkin added a comment to D22386: Fix an issue with a new tab focus.

It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.

Jul 16 2019, 9:33 AM · Dolphin

Jul 15 2019

AndreyYashkin updated the diff for D22386: Fix an issue with a new tab focus.

Equivalent solution

Jul 15 2019, 2:46 PM · Dolphin
AndreyYashkin added a comment to D22420: Fix an issue with focus lost after closing terminal panel.

This issue was supposed to be fixed by commit 4e40fe810d324 but it seems it got reintroduced in the past months.

Could you try to git bisect it to figure out when this happend?

Jul 15 2019, 1:08 PM · Dolphin

Jul 12 2019

AndreyYashkin updated the diff for D22422: Fix dir change when show hidden terminal panel with running program in it.

Added braces

Jul 12 2019, 2:46 PM · Dolphin
AndreyYashkin requested review of D22422: Fix dir change when show hidden terminal panel with running program in it.
Jul 12 2019, 2:35 PM · Dolphin
AndreyYashkin requested review of D22420: Fix an issue with focus lost after closing terminal panel.
Jul 12 2019, 1:01 PM · Dolphin

Jul 11 2019

AndreyYashkin updated the diff for D22303: Fix name grouping feature for cyrillic names.

I've deleted the else repeating and added warning about founded wrong behavior for Z group corner case.


Solving this requires another method for separation Latin and non Latin characters.

Jul 11 2019, 9:17 AM · Dolphin

Jul 10 2019

AndreyYashkin added a reviewer for D22386: Fix an issue with a new tab focus: Dolphin.
Jul 10 2019, 6:16 PM · Dolphin
AndreyYashkin requested review of D22386: Fix an issue with a new tab focus.
Jul 10 2019, 6:16 PM · Dolphin

Jul 8 2019

AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

By the way. Even now it is broken for corner cases and I can't see any simple solution for this.

Jul 8 2019, 11:29 AM · Dolphin
AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

Thanks for the patch!

Given that the correctness of this code depends on the locale, I'm not confident we won't break some corner cases.
Ideally we'd need more unit tests in KFileItemModelTest::testNameRoleGroups(), but I understand that's a lot to ask.

@cfeck in the bug report suggested to add more letters ranges. @AndreyYashkin Did you try that?

Jul 8 2019, 11:22 AM · Dolphin

Jul 7 2019

AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

If you don't have a contributor account, someone who does needs to land the patch on your behalf. Don't worry, it'll happen! I just want Dolphin's maintainer @elvisangelaccio to give his OK first.

Jul 7 2019, 6:28 PM · Dolphin
AndreyYashkin added a comment to D22303: Fix name grouping feature for cyrillic names.

Thanks, very nice first patch! This looks like the correct fix to me, and doesn't break grouping with the Latin alphabet or any of the unit tests. And you even used arc to submit the patch, so I don't have to ask for your email address. All in all, solid work!

@elvisangelaccio?

Jul 7 2019, 5:49 PM · Dolphin
AndreyYashkin added a reviewer for D22303: Fix name grouping feature for cyrillic names: Dolphin.
Jul 7 2019, 9:28 AM · Dolphin
AndreyYashkin updated the test plan for D22303: Fix name grouping feature for cyrillic names.
Jul 7 2019, 9:20 AM · Dolphin
AndreyYashkin requested review of D22303: Fix name grouping feature for cyrillic names.
Jul 7 2019, 8:54 AM · Dolphin