Mon, Jun 17
Sun, Jun 16
Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM modules trying to keep aspects separate. And yes, by the price of the overhead with more explicit module includes, but it's like that. Or we should just screw it and put everything in one big "KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to have such a generic wrapper module in any case, for quick prototyping. But the individual modules should stay focussed.
The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there).
Sat, Jun 15
This change appears to be responsible for all Android builds being broken.
Thu, Jun 13
- add options to take identifiers/type names from file base names
- add option to specify version suffix to install path
Mon, Jun 10
Where does this FindTaglib.cmake come from?
attic/modules/FindTaglib.cmake shall be deleted.
Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all...
Sun, Jun 9
I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked fine.
Fri, May 31
Maybe also update the commit message to 'Create specific directory for Qt logging categories file'
Thu, May 30
So ? :)
Tue, May 28
Change as qlogging-categories5
Indeed qlogging-categories5 seems a good name :)
Mon, May 27
My suggestion is to call this qlogging-categories5.
May 25 2019
- use appstream-util and appstreamcli to validate appdata file
LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ?
no idea if it's better.
May 24 2019
Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence)
Not to mention that Flatpak is Linux only as well, while Appstream data isn't applicable to multiple platforms.
How about we test against both?
Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR
May 22 2019
Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts
Use DEBUGCATEGORIESDIR and debug-categories5
May 21 2019
DEBUGCATEGORIESDIR is fine for me too
Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.
Remove unrelated change
Fix comment reported by Christophe Giboudeaux
Forgot to commit before creating diff