Build SystemOrganization
ActivePublic

Recent Activity

Mon, Jun 17

vkrause added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector?

Mon, Jun 17, 6:07 PM · Build System, Frameworks

Sun, Jun 16

kossebau added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM modules trying to keep aspects separate. And yes, by the price of the overhead with more explicit module includes, but it's like that. Or we should just screw it and put everything in one big "KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to have such a generic wrapper module in any case, for quick prototyping. But the individual modules should stay focussed.

Sun, Jun 16, 1:33 PM · Build System, Frameworks
bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there).

Sun, Jun 16, 8:43 AM · Build System, Frameworks
vkrause added a comment to D21313: Create specific directory for Qt logging categories file.

@apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both visible at the same time.

Sun, Jun 16, 7:51 AM · Build System, Frameworks
kossebau updated subscribers of D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Could someone take a look please?

Sun, Jun 16, 12:37 AM · Build System, Frameworks

Sat, Jun 15

bcooksley added a comment to D21313: Create specific directory for Qt logging categories file.

This change appears to be responsible for all Android builds being broken.
See https://build.kde.org/view/Failing/

Sat, Jun 15, 9:25 PM · Build System, Frameworks

Thu, Jun 13

apol accepted D20984: Add ECMAddQmlModule.
Thu, Jun 13, 12:33 AM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.
  • add options to take identifiers/type names from file base names
  • add option to specify version suffix to install path
Thu, Jun 13, 12:21 AM · Build System, Frameworks

Mon, Jun 10

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows

Mon, Jun 10, 7:55 PM · Build System, Frameworks
elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

Where does this FindTaglib.cmake come from?

Mon, Jun 10, 7:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D21695: Add FindTaglib.cmake.

attic/modules/FindTaglib.cmake shall be deleted.

Mon, Jun 10, 11:44 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21695: Add FindTaglib.cmake.
Mon, Jun 10, 11:41 AM · Build System, Frameworks
dfaure requested changes to D21695: Add FindTaglib.cmake.

Certainly a good idea to have this in ECM, so that this mess can be sorted out once and for all...

Mon, Jun 10, 11:04 AM · Build System, Frameworks

Sun, Jun 9

heikobecker added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked fine.

Sun, Jun 9, 3:40 PM · Build System, Frameworks
heikobecker requested review of D21695: Add FindTaglib.cmake.
Sun, Jun 9, 3:34 PM · Build System, Frameworks

Fri, May 31

mlaurent closed D21313: Create specific directory for Qt logging categories file.
Fri, May 31, 2:56 PM · Build System, Frameworks
mlaurent retitled D21313: Create specific directory for Qt logging categories file from Create specific directory for kdebugsettings categories file to Create specific directory for Qt logging categories file.
Fri, May 31, 2:55 PM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Fix typo

Fri, May 31, 2:54 PM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

Fri, May 31, 8:45 AM · Build System, Frameworks
cgiboudeaux accepted D21313: Create specific directory for Qt logging categories file.
Fri, May 31, 8:43 AM · Build System, Frameworks

Thu, May 30

mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

So ? :)

Thu, May 30, 1:07 PM · Build System, Frameworks

Tue, May 28

mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Change as qlogging-categories5

Tue, May 28, 6:55 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

Thanks david.
Indeed qlogging-categories5 seems a good name :)

Tue, May 28, 6:52 AM · Build System, Frameworks

Mon, May 27

dfaure added a comment to D21313: Create specific directory for Qt logging categories file.

My suggestion is to call this qlogging-categories5.

Mon, May 27, 8:48 PM · Build System, Frameworks

May 25 2019

mgallien added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.
In D21381#469617, @apol wrote:

How about we test against both?

May 25 2019, 9:44 AM · Build System, Frameworks
mgallien updated the diff for D21381: use org.freedesktop.appstream-glib package to validate appstream data.
  • use appstream-util and appstreamcli to validate appdata file
May 25 2019, 9:40 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ?
no idea if it's better.

May 25 2019, 8:08 AM · Build System, Frameworks

May 24 2019

bcooksley added a comment to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence)
Not to mention that Flatpak is Linux only as well, while Appstream data isn't applicable to multiple platforms.

May 24 2019, 7:30 PM · Build System, Frameworks
apol requested changes to D21381: use org.freedesktop.appstream-glib package to validate appstream data.

How about we test against both?

May 24 2019, 7:26 PM · Build System, Frameworks
ngraham added a reviewer for D21381: use org.freedesktop.appstream-glib package to validate appstream data: apol.
May 24 2019, 2:52 PM · Build System, Frameworks
kossebau added inline comments to D21313: Create specific directory for Qt logging categories file.
May 24 2019, 2:44 PM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR

May 24 2019, 2:35 PM · Build System, Frameworks
mgallien requested review of D21381: use org.freedesktop.appstream-glib package to validate appstream data.
May 24 2019, 1:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 7:45 AM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 5:02 AM · Build System, Frameworks

May 22 2019

kossebau updated the summary of D20984: Add ECMAddQmlModule.
May 22 2019, 6:05 PM · Build System, Frameworks
kossebau updated the diff for D20984: Add ECMAddQmlModule.

Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts

May 22 2019, 5:51 PM · Build System, Frameworks
dfaure closed D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 22 2019, 7:49 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Use DEBUGCATEGORIESDIR and debug-categories5

May 22 2019, 4:55 AM · Build System, Frameworks

May 21 2019

dvratil accepted D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 21 2019, 2:09 PM · Build System, Frameworks
mlaurent added a comment to D21313: Create specific directory for Qt logging categories file.

DEBUGCATEGORIESDIR is fine for me too

May 21 2019, 10:58 AM · Build System, Frameworks
apol added a comment to D21314: Don't enable QT_STRICT_ITERATORS on Windows..

+1

May 21 2019, 10:53 AM · Build System, Frameworks
cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

May 21 2019, 7:52 AM · Build System, Frameworks
dfaure updated the diff for D21314: Don't enable QT_STRICT_ITERATORS on Windows..

Remove unrelated change

May 21 2019, 7:32 AM · Build System, Frameworks
dfaure requested review of D21314: Don't enable QT_STRICT_ITERATORS on Windows..
May 21 2019, 7:32 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 7:16 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Fix comment reported by Christophe Giboudeaux

May 21 2019, 7:08 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 6:51 AM · Build System, Frameworks
mlaurent updated the diff for D21313: Create specific directory for Qt logging categories file.

Forgot to commit before creating diff

May 21 2019, 6:14 AM · Build System, Frameworks
lbeltrame added a reviewer for D21313: Create specific directory for Qt logging categories file: cgiboudeaux.
May 21 2019, 5:51 AM · Build System, Frameworks