Plasma::PluginLoader cleanup
Open, Needs TriagePublic

Description

Plasma::PluginLoader contains methods for listing/loading of various Plasma related plugins (Applets, DataEngines, ContainmentActions etc).

A lot of this is based on KPluginInfo/KPluginTrader, this should be ported to KPluginMetaData/KPluginLoader.

It defines virtual methods that allow writing custom loaders. This seems to be mostly unused (only ShellPluginLoader (deprecated) and SimpleLoader (for tests)) extend it in KDE code. Might be a good idea to get rid of that then.

With https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/231 and https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/226 all public methods using KPluginInfo are deprecated.

What remains is the question whether we need/want to have all the virtual stuff in the future

ltoscano moved this task from Needs Input to Backlog on the KF6 board.Apr 24 2021, 1:24 PM
alex claimed this task.Jul 20 2021, 7:39 AM
alex added a comment.EditedAug 8 2021, 11:02 AM

https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/303 Took care of the virtual load methods.

https://invent.kde.org/frameworks/kpackage/-/merge_requests/25 took care of it's friend in kpackage.

The virtual standardInternal* methods remain, but I guess this can be deprecated too. I am not aware of any applications that use - or might use these methods. If anything they should use the KCoreAddons KPluginLoader/KPluginMetaData.

mart added a subscriber: mart.Oct 29 2021, 7:15 AM
In T13889#261518, @alex wrote:

The virtual standardInternal* methods remain, but I guess this can be deprecated too. I am not aware of any applications that use - or might use these methods. If anything they should use the KCoreAddons KPluginLoader/KPluginMetaData.

+1 to deprecate those as well

alex moved this task from Backlog to Waiting on KF6 Branching on the KF6 board.Oct 29 2021, 7:50 AM

https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/369

Some stuff regarding the parent app filtering remains, but that is handled in T14730

Since there is nothing on the Plasma side to do and it only waits for KF6 branching, I have adjusted the tags accordingly

nicolasfella moved this task from In Progress to Done on the KF6 board.