A repository added later to differential review is not shown
Closed, ResolvedPublic

Description

For example, see https://phabricator.kde.org/D5538.
The repository was added later, but it is not added in the "Diff Detail" section.

I understand that this does not happen when arcanist is used; nevertheless, if I set the repository, it should be visible in the usual place.

ltoscano created this task.May 7 2017, 1:03 PM

When updating a Diff i've noticed you get an option to set a Repository - have you been setting that? (This is separate to the metadata of the review itself)

I did that when uploading https://phabricator.kde.org/D6073 and it seems to have worked there.

I did not updated the diff itself; I edited the review and added the value in the repository field (see the history of https://phabricator.kde.org/D5538 ). Right now that review shows the repository in the proper field, but it was submitted so something else may have happened that set the field properly.I would try to look for reviews without repo.

Yeah. When you upload a diff you are given an option to set the repository which I think is what needs to be done here. I suspect that is the step that is being missed and unfortunately you can't go back and amend this once it's been uploaded.

But you can edit the review later, and you can set the repository. If you can edit and set the repository anytime, the repository should appear in the proper place. If bot, it's a pahbricator bug.

I think there are two different items at play here:

  • Revisions (Reviews), which have multiple Diffs and Comments attached to them. You can edit the repository set for this by editing the revision.
  • Diffs, which comprise a given change to the source code. These also have a repository, which is set when the diff is created.

I suspect the Diff Detail section only shows the information from the latest Diff, and not from the Revision. I suspect the Revision has a repository for metadata purposes only and it isn't shown anywhere, which would explain the confusion here.

I think that the Diff Detail section is then confusing: even if it does not contain metadata about the repository, if I forcibly set the repository then it should be shown.
Or anyway, the repository should be shown anyway.
Updated example: https://phabricator.kde.org/D5037

ltoscano closed this task as Resolved.Mar 3 2023, 12:39 AM
ltoscano claimed this task.

As we moved away from phabricator (to gitlab) for code reviews, this is no more relevant.