In D27862#637793, @zzag wrote:

Is it still WIP?

restore Q_ASSERT

In D27724#633240, @davidedmundson wrote:

Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled.

I'm not sure I understand why that would happen.

That means there's something else going on, and we shouldn't ship this till we understand it.

remove unnecessary cast

fix leak. rename m_ui to m_form since it's not the ui. remove unnecessary enum cast.

drop ancestor.

fix leak. replace macros.

In D27133#625924, @apol wrote:

The patch and the feature sound good to me, the resulting xml feels a bit weird and could use some clarification.

@dfaure, any opinion on this revision ?

rebase

Plan to make a common component that will be used by kwinscreenedges as well.

Move ui class to separate file.
Move from inheritance to delegating.
No longer write directly to settings, only on save.

rename

Tested as an alternative to D27944
At initialization, the apply button is enabled.
Unfortunately, if the user clicks on reset button at first, the apply button is disabled an stays disabled.

In D27862#622926, @ervin wrote:

It's only a first step right? We'll move toward addConfig in a further step? Wondering what the plan is there.

remove auto, qAsConst

This diff is almost a rework of the previous one in ordre to move Ui class from inhertitance to delegation and handle unmanaged settings according to KCModule philosophy.

Consider comments

Move Ui from inheritance to delegation.
Rework KCModule to modify settings only on save().

rename group attribute to parentGroupName

rename attribute to parentGroupName

fix CMakeList

commit message

code style

code style

misspelling

use parentGroup attribute

rework: introduce parentGroup attribute to group element

Thanks for your comments.

style

constexpr

constexpr instead of static

@broulik any thoughts on this ?

fix comment

@ngraham do you confirm it is not working ?

Consider Kevin's comments

In D27482#614006, @meven wrote:

Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General

Thanks for the confirmation.

Weird, I've tested again, and works like expected on my machine.

This fix the issue for Breeze theme, but according to bug description (https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also have oxygen instead of Oxygen and maybe the case for fusion and window them style.

In D27482#613699, @ngraham wrote:

How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it.

restore blank line

Will do in a separate commit. I guess it's more or less related to the KCM Style.

Comments

looks ok to me

Sounds like it will provide a complete fix, the update script will fix the issue without requiring the user to reset its application style, and this patch will ensure it won't come back.

In D27407#611723, @ngraham wrote:

This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though.

@ngraham my bad, didn't see your edit ^^