KCM Notifications : Manage app-specific notifications with KCconfigXT's magic
Needs RevisionPublic

Authored by crossi on Thu, Feb 6, 10:41 AM.

Details

Reviewers
ervin
broulik
bport
meven
Group Reviewers
Plasma
Summary

App-specific notifications' behavior are now managed with KConfigXT. The default values are set in plasmanotifyrc shipped with the libnotificationmanager and can be override.
Immutability can be set at applicatioin level in plasmanotifyrc.
Reinitialize button reset all modifications not applied. Default button does not reset to default applications' behavior (same as before).

Require D27059 D27133 D27155

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22296
Build 22314: arc lint + arc unit
crossi created this revision.Thu, Feb 6, 10:41 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Feb 6, 10:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Thu, Feb 6, 10:41 AM
bport added inline comments.Mon, Feb 10, 8:11 AM
kcms/notifications/kcm.cpp
257

Add a if to emit signal only if needed

crossi updated this revision to Diff 75360.Mon, Feb 10, 1:35 PM

Check before assign and emit changed

crossi marked an inline comment as done.Mon, Feb 10, 1:35 PM
bport accepted this revision.Tue, Feb 11, 9:01 AM
This revision is now accepted and ready to land.Tue, Feb 11, 9:01 AM
ervin requested changes to this revision.Wed, Feb 12, 3:48 PM
ervin added inline comments.
kcms/notifications/kcm.cpp
277

What about m_behaviorSettingsList is empty? I'm not sure we can guarantee that it'll always contain something.

321

Replace with any_of ? This would break the loop earlier.

kcms/notifications/kcm.h
93

Should be a const ref

108

Space before * not after

kcms/notifications/sourcesmodel.cpp
380

const auto &

kcms/notifications/sourcesmodel.h
98

It's generally a better idea to define a small trivial struct when roll with QPair

This revision now requires changes to proceed.Wed, Feb 12, 3:48 PM