Breeze widgetStyle value is Breeze
AcceptedPublic

Authored by crossi on Fri, Feb 14, 3:38 PM.

Details

Summary

CCBUG: 417515

The KCM Look and feel writes to kdeglobals the values that are in plasma/look-and-feel/org.kde.breeze.desktop/contets/defaults
and the widgetStyle value was not what was expected.
Also, in breeze dark package, it is Breeze.

Test Plan
  • System settings > Look and Feel
  • Apply Breeze Dark
  • System settings > Application Style
  • Breeze is selected
  • System settings > Look and Feel
  • Apply Breeze
  • System settings > Application Style
  • Breeze is NOT selected

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22493
Build 22511: arc lint + arc unit
crossi created this revision.Fri, Feb 14, 3:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 14, 3:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Fri, Feb 14, 3:38 PM
crossi edited the summary of this revision. (Show Details)Fri, Feb 14, 3:43 PM
crossi edited the test plan for this revision. (Show Details)
ngraham edited the summary of this revision. (Show Details)Fri, Feb 14, 3:56 PM
crossi edited the summary of this revision. (Show Details)Fri, Feb 14, 3:59 PM
crossi edited the summary of this revision. (Show Details)
crossi added a subscriber: ngraham.Fri, Feb 14, 4:03 PM

@ngraham my bad, didn't see your edit ^^

davidedmundson accepted this revision.Fri, Feb 14, 4:07 PM
This revision is now accepted and ready to land.Fri, Feb 14, 4:07 PM

This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though.

So this is clearly a correct fix, but I'm not sure it's sufficient to fully resolve 417515.

ngraham accepted this revision.Fri, Feb 14, 4:15 PM
ngraham edited the summary of this revision. (Show Details)

This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for that use case though.

Yes, it requires to apply Breeze style again, to set widgetStyle to Breeze in kdeglobals, instead of breeze

Could we maybe ship a kconfig update script to change the string in the config file for people who don't ever change their global theme? Or is the problem moot because the global theme gets automatically applied on upgrade or something?

Sounds like it will provide a complete fix, the update script will fix the issue without requiring the user to reset its application style, and this patch will ensure it won't come back.

Shall we expect the migration script in that patch or another one?

Separate commit is probably fine, but if this lands on the stable branch, it should come soon.

Will do in a separate commit. I guess it's more or less related to the KCM Style.