Differential D27470

Set good default value for cursor theme and size in KRDB
ClosedPublic
Actions

Authored by bport on Feb 18 2020, 9:01 AM.

Details

Reviewers
broulik
ervin
meven
crossi
davidedmundson
Group Reviewers
Plasma
Commits
R119:ca9f0eeb9b53: Set good default value for cursor theme and size in KRDB
Summary

BUG: 414109
FIXED-IN: 5.18.2

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Feb 18 2020, 9:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2020, 9:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Feb 18 2020, 9:01 AM
meven accepted this revision.Feb 18 2020, 9:07 AM

This looks like a good kcms to convert to KConfigXT...

kcms/krdb/krdb.cpp
753

0 is unintuitive, it is for "default"/autodetermined I guess.

This revision is now accepted and ready to land.Feb 18 2020, 9:07 AM
davidre added a subscriber: davidre.Feb 18 2020, 9:43 AM
In D27470#613348, @meven wrote:

This looks like a good kcms to convert to KConfigXT...

This isn't even a kcm :D
See Kai's mail to plasma-devel
https://mail.kde.org/pipermail/plasma-devel/2020-February/110655.html

bport added a comment.Feb 18 2020, 10:01 AM

This is not a KCM, and because of how stuff works with KRDB we can't reuse kcfg easily there (because build by 5 or 6 kcm)
About the 0 as default value, perhaps we can change that but it's totally unrelated to this patch, goal there is only to honor default value as set by kcfg

davidedmundson accepted this revision.Feb 18 2020, 10:37 AM
crossi accepted this revision.Feb 18 2020, 10:45 AM
ngraham edited the summary of this revision. (Show Details)Feb 18 2020, 4:49 PM
ngraham edited the summary of this revision. (Show Details)

Can you run arc amend on your local branch to pick up the changes I just made to the description, and then land this on the stable branch?

Closed by commit R119:ca9f0eeb9b53: Set good default value for cursor theme and size in KRDB (authored by bport). · Explain WhyFeb 19 2020, 7:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/krdb/krdb.cpp (4 lines)

Diff 75962

View Options

kcms/krdb/krdb.cpp

Loading...