crossi (Cyril Rossi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2019, 3:32 PM (49 w, 3 d)
Availability
Available

Recent Activity

May 11 2020

crossi added a comment to D28662: KCM LookAndFeel check widgetStyle availability before applying it.

This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.:

14:11:19  FAIL!  : KcmTest::testKCMSave() Compared values are not the same
14:11:19     Actual   (cg.readEntry("widgetStyle", QString())): ""
14:11:19     Expected (QString("testValue"))                  : "testValue"
14:11:19     Loc: [/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]

https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console

May 11 2020, 11:59 AM · Plasma

May 5 2020

crossi added inline comments to D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.
May 5 2020, 10:37 AM · KWin
crossi updated the summary of D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.
May 5 2020, 9:34 AM · KWin
crossi added a comment to D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.

May 5 2020, 9:15 AM · KWin
crossi added reviewers for D29443: KCM KWinVirtualDesktops disable UI when settings are immutable: bport, meven, zzag, mart, KWin.
May 5 2020, 9:12 AM · KWin
crossi updated the diff for D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.

restore blank lines

May 5 2020, 8:54 AM · KWin
crossi requested review of D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.
May 5 2020, 8:52 AM · KWin

May 4 2020

crossi added reviewers for D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI: bport, meven, ngraham, davidedmundson, Plasma.
May 4 2020, 10:35 AM · Plasma
crossi requested review of D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI.
May 4 2020, 10:22 AM · Plasma

Apr 30 2020

crossi committed R119:fdfb48786ed5: Merge branch 'Plasma/5.18' (authored by crossi).
Merge branch 'Plasma/5.18'
Apr 30 2020, 8:05 AM
crossi committed R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader() (authored by crossi).
KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()
Apr 30 2020, 7:55 AM
crossi closed D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
Apr 30 2020, 7:55 AM · Plasma
crossi updated the summary of D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
Apr 30 2020, 7:49 AM · Plasma
crossi updated the diff for D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().

consider Kai's comments

Apr 30 2020, 7:36 AM · Plasma
crossi added a comment to D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().

Can this go into 5.18?

Apr 30 2020, 7:22 AM · Plasma

Apr 29 2020

crossi updated the summary of D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
Apr 29 2020, 5:39 PM · Plasma
crossi requested review of D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
Apr 29 2020, 5:38 PM · Plasma
crossi added a comment to D29231: Add keyboard_shortcuts_inhibit protocol.

some code style related comments

Apr 29 2020, 9:41 AM · Frameworks

Apr 27 2020

crossi added inline comments to D29231: Add keyboard_shortcuts_inhibit protocol.
Apr 27 2020, 3:37 PM · Frameworks

Apr 23 2020

crossi committed R119:6d12d2d62607: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic (authored by crossi).
KCM Notifications : Manage app-specific notifications with KCconfigXT's magic
Apr 23 2020, 4:32 PM
crossi closed D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Apr 23 2020, 4:32 PM · Plasma
crossi updated the test plan for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Apr 23 2020, 4:31 PM · Plasma
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.

clear the nitpicks

Apr 23 2020, 4:15 PM · Plasma
crossi updated the test plan for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Apr 23 2020, 4:14 PM · Plasma
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.

Consider Kai's comments

Apr 23 2020, 3:16 PM · Plasma
crossi planned changes to D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Apr 23 2020, 12:59 PM · Plasma
crossi requested review of D29120: KCM Fonts disable AA items if they are immutable.
Apr 23 2020, 7:45 AM · Plasma
crossi committed R108:db9d7a7f5d9c: KCM KWinScreenEdge fix build issue (authored by crossi).
KCM KWinScreenEdge fix build issue
Apr 23 2020, 6:48 AM
crossi closed D29104: KCM KWinScreenEdge fix build issue.
Apr 23 2020, 6:48 AM · KWin

Apr 22 2020

crossi updated the diff for D29104: KCM KWinScreenEdge fix build issue.

Update code comment accordingly

Apr 22 2020, 4:52 PM · KWin
crossi requested review of D29104: KCM KWinScreenEdge fix build issue.
Apr 22 2020, 4:35 PM · KWin
crossi committed R119:5ba33c6307a9: Merge branch 'Plasma/5.18' (authored by crossi).
Merge branch 'Plasma/5.18'
Apr 22 2020, 3:29 PM
crossi committed R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it. (authored by crossi).
KCM LookAndFeel check if splash screen is provided before applying it.
Apr 22 2020, 2:44 PM
crossi closed D28656: KCM LookAndFeel check if splash screen is provided before applying it..
Apr 22 2020, 2:44 PM · Plasma
crossi committed R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it (authored by crossi).
KCM LookAndFeel check widgetStyle availability before applying it
Apr 22 2020, 2:44 PM
crossi closed D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Apr 22 2020, 2:44 PM · Plasma
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.

use qAsConst, indent

Apr 22 2020, 2:34 PM · Plasma
crossi updated the summary of D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Apr 22 2020, 11:22 AM · Plasma
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.

maange reset to default application notification

Apr 22 2020, 11:22 AM · Plasma
crossi committed R108:cf7762eaa874: KCM KWinScreenEdges disable widgets if is immutable (authored by crossi).
KCM KWinScreenEdges disable widgets if is immutable
Apr 22 2020, 9:23 AM
crossi closed D28508: KCM KWinScreenEdges disable widgets if is immutable.
Apr 22 2020, 9:23 AM · KWin
crossi committed R108:a9c0337113c5: KCM KWinTouchEdges disable edge if is immutable (authored by crossi).
KCM KWinTouchEdges disable edge if is immutable
Apr 22 2020, 9:23 AM
crossi closed D28507: KCM KWinTouchEdges disable edge if is immutable.
Apr 22 2020, 9:23 AM · KWin
crossi committed R108:128eb13c09f2: KCM KWinScreenEdges port to KConfigXT (authored by crossi).
KCM KWinScreenEdges port to KConfigXT
Apr 22 2020, 9:22 AM
crossi closed D28475: KCM KWinScreenEdges port to KConfigXT.
Apr 22 2020, 9:22 AM · KWin
crossi committed R108:01314f8e9a73: KCM KWinTouchScreen port to KConfigXT (authored by crossi).
KCM KWinTouchScreen port to KConfigXT
Apr 22 2020, 9:22 AM
crossi closed D27862: KCM KWinTouchScreen port to KConfigXT.
Apr 22 2020, 9:22 AM · KWin
crossi committed R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings (authored by crossi).
libnotificationmanager : add app-specific kconfig settings
Apr 22 2020, 7:51 AM
crossi closed D27155: libnotificationmanager : add app-specific kconfig settings.
Apr 22 2020, 7:51 AM · Plasma
crossi committed R237:00213a3a0906: kconfig_compiler : generate kconfig settings with subgroup (authored by crossi).
kconfig_compiler : generate kconfig settings with subgroup
Apr 22 2020, 7:25 AM
crossi closed D27133: kconfig_compiler : generate kconfig settings with subgroup.
Apr 22 2020, 7:25 AM · Frameworks

Apr 20 2020

crossi updated the diff for D28629: [WIP] Port KCM to SettingStateBinding.

Work on fonts and style

Apr 20 2020, 6:52 AM · Plasma

Apr 14 2020

crossi updated the summary of D28629: [WIP] Port KCM to SettingStateBinding.
Apr 14 2020, 1:29 PM · Plasma
crossi committed R108:3284e19646df: KCM KWinTabbox disable widget if property is immutable. (authored by crossi).
KCM KWinTabbox disable widget if property is immutable.
Apr 14 2020, 12:32 PM
crossi closed D28484: KCM KWinTabbox disable widget if property is immutable..
Apr 14 2020, 12:32 PM · KWin
crossi added a dependent revision for D28475: KCM KWinScreenEdges port to KConfigXT: D28508: KCM KWinScreenEdges disable widgets if is immutable.
Apr 14 2020, 9:58 AM · KWin
crossi added a dependency for D28508: KCM KWinScreenEdges disable widgets if is immutable: D28475: KCM KWinScreenEdges port to KConfigXT.
Apr 14 2020, 9:58 AM · KWin
crossi added a dependency for D28507: KCM KWinTouchEdges disable edge if is immutable: D27862: KCM KWinTouchScreen port to KConfigXT.
Apr 14 2020, 9:57 AM · KWin
crossi added a dependent revision for D27862: KCM KWinTouchScreen port to KConfigXT: D28507: KCM KWinTouchEdges disable edge if is immutable.
Apr 14 2020, 9:57 AM · KWin
crossi updated the test plan for D27862: KCM KWinTouchScreen port to KConfigXT.
Apr 14 2020, 9:52 AM · KWin
crossi updated the diff for D27862: KCM KWinTouchScreen port to KConfigXT.

Fix action Present Windows - Current desktop that was saved as All desktop and vice versa

Apr 14 2020, 9:45 AM · KWin
crossi updated the diff for D28662: KCM LookAndFeel check widgetStyle availability before applying it.

Fix comments

Apr 14 2020, 8:46 AM · Plasma
crossi added a comment to D27271: [kcms/colors] RFC: Accent Colours.

These new properties can be managed by KConfig.
It will automatically handle the read/write process and isSaveNeeded/isDefault status.

Apr 14 2020, 8:46 AM · Plasma
crossi added inline comments to D28744: Rewrite of the global shortcuts kcm.
Apr 14 2020, 8:07 AM · Plasma

Apr 8 2020

crossi updated the test plan for D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Apr 8 2020, 3:46 PM · Plasma

Apr 7 2020

crossi requested review of D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Apr 7 2020, 4:37 PM · Plasma
crossi updated the diff for D27862: KCM KWinTouchScreen port to KConfigXT.

Fix two little things

Apr 7 2020, 4:11 PM · KWin
crossi requested review of D28656: KCM LookAndFeel check if splash screen is provided before applying it..
Apr 7 2020, 1:55 PM · Plasma

Apr 6 2020

crossi updated the summary of D28629: [WIP] Port KCM to SettingStateBinding.
Apr 6 2020, 5:05 PM · Plasma
crossi updated the diff for D28629: [WIP] Port KCM to SettingStateBinding.

port KCM cursor theme

Apr 6 2020, 5:05 PM · Plasma
crossi updated the diff for D28629: [WIP] Port KCM to SettingStateBinding.

fix import

Apr 6 2020, 4:51 PM · Plasma
crossi requested review of D28629: [WIP] Port KCM to SettingStateBinding.
Apr 6 2020, 4:48 PM · Plasma
crossi added a dependent revision for D27840: Introduce SettingState* elements to ease KCM writing: D28629: [WIP] Port KCM to SettingStateBinding.
Apr 6 2020, 4:48 PM · Frameworks
crossi added a dependent revision for D27840: Introduce SettingState* elements to ease KCM writing: D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding.
Apr 6 2020, 3:21 PM · Frameworks
crossi added a dependency for D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding: D27840: Introduce SettingState* elements to ease KCM writing.
Apr 6 2020, 3:21 PM · KWin
crossi added a comment to D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding.

The indicators are not well placed.

Apr 6 2020, 1:52 PM · KWin
crossi requested review of D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding.
Apr 6 2020, 1:22 PM · KWin

Apr 2 2020

crossi committed R119:443b028a1cb3: KCM Colors fix apply button always disabled (authored by crossi).
KCM Colors fix apply button always disabled
Apr 2 2020, 1:20 PM
crossi added inline comments to D28154: Add users KCM.
Apr 2 2020, 12:21 PM · Plasma
crossi added reviewers for D28508: KCM KWinScreenEdges disable widgets if is immutable: ervin, bport, meven, zzag, KWin.
Apr 2 2020, 10:09 AM · KWin
crossi added reviewers for D28507: KCM KWinTouchEdges disable edge if is immutable: ervin, bport, meven, zzag, KWin.
Apr 2 2020, 10:05 AM · KWin
crossi updated the diff for D28475: KCM KWinScreenEdges port to KConfigXT.

fix defaults

Apr 2 2020, 9:41 AM · KWin
crossi requested review of D28508: KCM KWinScreenEdges disable widgets if is immutable.
Apr 2 2020, 9:41 AM · KWin
crossi requested review of D28507: KCM KWinTouchEdges disable edge if is immutable.
Apr 2 2020, 9:41 AM · KWin
crossi updated the diff for D27862: KCM KWinTouchScreen port to KConfigXT.

fix defaults

Apr 2 2020, 9:39 AM · KWin

Apr 1 2020

crossi updated the summary of D28484: KCM KWinTabbox disable widget if property is immutable..
Apr 1 2020, 2:49 PM · KWin
crossi updated the diff for D28484: KCM KWinTabbox disable widget if property is immutable..

proper naming

Apr 1 2020, 2:48 PM · KWin
crossi requested review of D28484: KCM KWinTabbox disable widget if property is immutable..
Apr 1 2020, 2:42 PM · KWin
crossi committed R108:51a1e06dfc1f: KCM KWinTabBox manage KCModule states (authored by crossi).
KCM KWinTabBox manage KCModule states
Apr 1 2020, 9:09 AM
crossi closed D27784: KCM KWinTabBox manage KCModule states.
Apr 1 2020, 9:09 AM · KWin
crossi updated the diff for D27784: KCM KWinTabBox manage KCModule states.

fix error

Apr 1 2020, 8:59 AM · KWin
crossi added inline comments to D27784: KCM KWinTabBox manage KCModule states.
Apr 1 2020, 8:48 AM · KWin
crossi added a dependency for D28475: KCM KWinScreenEdges port to KConfigXT: D27862: KCM KWinTouchScreen port to KConfigXT.
Apr 1 2020, 8:23 AM · KWin
crossi added a dependent revision for D27862: KCM KWinTouchScreen port to KConfigXT: D28475: KCM KWinScreenEdges port to KConfigXT.
Apr 1 2020, 8:23 AM · KWin
crossi requested review of D28475: KCM KWinScreenEdges port to KConfigXT.
Apr 1 2020, 8:19 AM · KWin
crossi updated the diff for D27862: KCM KWinTouchScreen port to KConfigXT.

rename include guard

Apr 1 2020, 8:17 AM · KWin

Mar 31 2020

crossi requested review of D27862: KCM KWinTouchScreen port to KConfigXT.

From previous revision, I moved code related to the Monitor part in the ui in a separate class KWinScreenEdge, that will be used by KCM KWinScreenEdges to remove duplicated code and ease the port to KConfigXT.

Mar 31 2020, 10:10 AM · KWin
crossi retitled D27862: KCM KWinTouchScreen port to KConfigXT from [WIP] KCM KWinTouchScreen port to KConfigXT to KCM KWinTouchScreen port to KConfigXT.
Mar 31 2020, 10:05 AM · KWin
crossi updated the diff for D27862: KCM KWinTouchScreen port to KConfigXT.

rework to allow code reuse in KCM KWinScreenEdges

Mar 31 2020, 10:01 AM · KWin
crossi planned changes to D27862: KCM KWinTouchScreen port to KConfigXT.
Mar 31 2020, 7:31 AM · KWin