crossi (Cyril Rossi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2019, 3:32 PM (5 w, 2 d)
Availability
Available

Recent Activity

Yesterday

crossi updated the diff for D25290: KCM launchfeedback : port to KConfig XT.

Use proper signal handler & Fix typo

Thu, Nov 14, 1:02 PM · Plasma
crossi added inline comments to D25290: KCM launchfeedback : port to KConfig XT.
Thu, Nov 14, 12:36 PM · Plasma

Wed, Nov 13

crossi requested review of D25290: KCM launchfeedback : port to KConfig XT.
Wed, Nov 13, 4:14 PM · Plasma
crossi committed R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT (authored by crossi).
KCM Colors : port color scheme state management to KConfigXT
Wed, Nov 13, 9:32 AM
crossi closed D25198: KCM Colors : port color scheme state management to KConfigXT.
Wed, Nov 13, 9:32 AM · Plasma

Tue, Nov 12

crossi updated the diff for D25274: KCM LookAndFeel : port to KConfig XT.

misspelling

Tue, Nov 12, 4:00 PM · Plasma
crossi updated the diff for D25274: KCM LookAndFeel : port to KConfig XT.

Add kcfg files

Tue, Nov 12, 3:43 PM · Plasma
crossi requested review of D25274: KCM LookAndFeel : port to KConfig XT.
Tue, Nov 12, 3:42 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

style + consistency

Tue, Nov 12, 2:03 PM · Plasma
crossi added inline comments to D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Tue, Nov 12, 1:08 PM · Plasma

Fri, Nov 8

crossi added a comment to D25198: KCM Colors : port color scheme state management to KConfigXT.

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Fri, Nov 8, 5:09 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

missed that one

Fri, Nov 8, 5:02 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

make access to selectedStyle more consistent

Fri, Nov 8, 4:59 PM · Plasma
crossi requested review of D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Fri, Nov 8, 4:49 PM · Plasma

Thu, Nov 7

crossi requested review of D25198: KCM Colors : port color scheme state management to KConfigXT.
Thu, Nov 7, 5:11 PM · Plasma

Thu, Oct 31

crossi closed D25000: Do not assign combobox currentIndex as it breaks binding..
Thu, Oct 31, 10:40 AM · Plasma
crossi committed R858:35fae4b55fc8: Do not assign combobox currentIndex as it breaks binding. (authored by crossi).
Do not assign combobox currentIndex as it breaks binding.
Thu, Oct 31, 10:40 AM
crossi committed R119:332226003b04: KCM KSplash port to ManagedConfigModule (authored by crossi).
KCM KSplash port to ManagedConfigModule
Thu, Oct 31, 10:02 AM
crossi closed D24925: KCM KSplash port to ManagedConfigModule.
Thu, Oct 31, 10:02 AM · Plasma
crossi committed R119:fbed4b3efcdb: KCM Style port to KConfigXT (authored by crossi).
KCM Style port to KConfigXT
Thu, Oct 31, 10:02 AM
crossi closed D24917: KCM Style port to KConfigXT.
Thu, Oct 31, 10:02 AM · Plasma
crossi abandoned D24916: KCM style : fix combobox that weren't updated after user made change.

Fix by D25000

Thu, Oct 31, 9:58 AM · Plasma
crossi committed R135:9313c877f55f: Fix issue when there is no WidgetStyle value in kdeglobals (authored by crossi).
Fix issue when there is no WidgetStyle value in kdeglobals
Thu, Oct 31, 9:47 AM
crossi closed D24918: Fix issue when there is no WidgetStyle value in kdeglobals.
Thu, Oct 31, 9:47 AM · Plasma
crossi added inline comments to D25000: Do not assign combobox currentIndex as it breaks binding..
Thu, Oct 31, 8:50 AM · Plasma

Wed, Oct 30

crossi updated the test plan for D25000: Do not assign combobox currentIndex as it breaks binding..
Wed, Oct 30, 4:08 PM · Plasma
crossi updated the diff for D25000: Do not assign combobox currentIndex as it breaks binding..

Missing const ref, rename private header accordingly

Wed, Oct 30, 2:45 PM · Plasma
crossi updated the test plan for D25000: Do not assign combobox currentIndex as it breaks binding..
Wed, Oct 30, 1:19 PM · Plasma
crossi updated the diff for D25000: Do not assign combobox currentIndex as it breaks binding..

Remove assignement to currentIndex.
Add a C++ bypass to setCurrentIndex without breaking the binding.

Wed, Oct 30, 1:16 PM · Plasma

Tue, Oct 29

crossi updated the diff for D24917: KCM Style port to KConfigXT.

Move some duplicated code to a function

Tue, Oct 29, 2:16 PM · Plasma

Mon, Oct 28

crossi added inline comments to D25000: Do not assign combobox currentIndex as it breaks binding..
Mon, Oct 28, 3:41 PM · Plasma
crossi updated the test plan for D25000: Do not assign combobox currentIndex as it breaks binding..
Mon, Oct 28, 9:46 AM · Plasma
crossi requested review of D25000: Do not assign combobox currentIndex as it breaks binding..
Mon, Oct 28, 9:43 AM · Plasma

Fri, Oct 25

crossi updated the diff for D24916: KCM style : fix combobox that weren't updated after user made change.

qml style

Fri, Oct 25, 3:01 PM · Plasma
crossi updated the diff for D24916: KCM style : fix combobox that weren't updated after user made change.

refactor code into a function

Fri, Oct 25, 2:25 PM · Plasma
crossi updated the diff for D24925: KCM KSplash port to ManagedConfigModule.

Remove unnecessary override

Fri, Oct 25, 9:25 AM · Plasma

Thu, Oct 24

crossi updated the diff for D24925: KCM KSplash port to ManagedConfigModule.

setNeedsSave() not needed

Thu, Oct 24, 3:37 PM · Plasma
crossi added inline comments to D24925: KCM KSplash port to ManagedConfigModule.
Thu, Oct 24, 3:34 PM · Plasma
crossi added inline comments to D24925: KCM KSplash port to ManagedConfigModule.
Thu, Oct 24, 3:25 PM · Plasma
crossi resigned from D24923: Use more return early.
Thu, Oct 24, 3:14 PM · Plasma
crossi requested changes to D24923: Use more return early.
Thu, Oct 24, 2:22 PM · Plasma
crossi requested review of D24925: KCM KSplash port to ManagedConfigModule.
Thu, Oct 24, 2:15 PM · Plasma
crossi added reviewers for D24917: KCM Style port to KConfigXT: ervin, mart, bport, Plasma.
Thu, Oct 24, 12:19 PM · Plasma
crossi requested review of D24918: Fix issue when there is no WidgetStyle value in kdeglobals.
Thu, Oct 24, 12:16 PM · Plasma
crossi requested review of D24917: KCM Style port to KConfigXT.
Thu, Oct 24, 12:02 PM · Plasma
crossi requested review of D24916: KCM style : fix combobox that weren't updated after user made change.
Thu, Oct 24, 12:01 PM · Plasma

Tue, Oct 22

crossi committed R119:550a9a25d628: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package (authored by crossi).
KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package
Tue, Oct 22, 12:41 PM
crossi closed D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package.
Tue, Oct 22, 12:41 PM · Plasma
crossi committed R119:1b857f927037: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method… (authored by crossi).
KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method…
Tue, Oct 22, 12:41 PM
crossi closed D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.
Tue, Oct 22, 12:41 PM · Plasma
crossi committed R119:fd1f77d5dbff: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package (authored by crossi).
KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package
Tue, Oct 22, 12:41 PM
crossi closed D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package.
Tue, Oct 22, 12:41 PM · Plasma
crossi committed R119:77b27da43cd2: Port KCMSplashScreen to KConfigXT (authored by crossi).
Port KCMSplashScreen to KConfigXT
Tue, Oct 22, 12:41 PM
crossi closed D24730: Port KCMSplashScreen to KConfigXT.
Tue, Oct 22, 12:41 PM · Plasma
crossi committed R119:c402ff93c219: remove unnecessary ; + add const to getter + typo in Roles declaration. (authored by crossi).
remove unnecessary ; + add const to getter + typo in Roles declaration.
Tue, Oct 22, 12:41 PM
crossi closed D24729: remove unnecessary ; + add const to getter + typo in Roles declaration..
Tue, Oct 22, 12:41 PM · Plasma
crossi updated the diff for D24730: Port KCMSplashScreen to KConfigXT.

Use both key and name tag in entry to generate pretty signals' name.

Tue, Oct 22, 12:35 PM · Plasma
crossi accepted D24845: KCM don't support icons effect anymore, clean-up config file.
Tue, Oct 22, 12:22 PM · Plasma

Mon, Oct 21

crossi accepted D24822: Port the desktoptheme kcm to ManagedConfigModule.
Mon, Oct 21, 4:04 PM · Plasma
crossi updated the diff for D24730: Port KCMSplashScreen to KConfigXT.

remove unnecessary emit

Mon, Oct 21, 3:42 PM · Plasma
crossi added inline comments to D24730: Port KCMSplashScreen to KConfigXT.
Mon, Oct 21, 3:38 PM · Plasma
crossi updated the diff for D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.

restore blank lines

Mon, Oct 21, 10:18 AM · Plasma
crossi updated the test plan for D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.
Mon, Oct 21, 8:35 AM · Plasma
crossi requested review of D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package.
Mon, Oct 21, 8:34 AM · Plasma
crossi requested review of D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration.
Mon, Oct 21, 8:31 AM · Plasma

Fri, Oct 18

crossi added inline comments to D24730: Port KCMSplashScreen to KConfigXT.
Fri, Oct 18, 7:55 AM · Plasma

Thu, Oct 17

crossi requested review of D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package.
Thu, Oct 17, 1:10 PM · Plasma
crossi requested review of D24730: Port KCMSplashScreen to KConfigXT.
Thu, Oct 17, 1:10 PM · Plasma
crossi requested review of D24729: remove unnecessary ; + add const to getter + typo in Roles declaration..
Thu, Oct 17, 1:08 PM · Plasma

Wed, Oct 16

crossi removed a watcher for Plasma: crossi.
Wed, Oct 16, 1:33 PM
crossi added a watcher for Plasma: crossi.
Wed, Oct 16, 10:18 AM