crossi (Cyril Rossi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2019, 3:32 PM (14 w, 5 d)
Availability
Available

Recent Activity

Wed, Jan 15

crossi committed R119:e236b520a720: KCM Notifications : fix applications behavior not properly updated in KCM (authored by crossi).
KCM Notifications : fix applications behavior not properly updated in KCM
Wed, Jan 15, 10:42 AM
crossi closed D26683: KCM Notifications : fix applications behavior not properly updated in KCM.
Wed, Jan 15, 10:42 AM · Plasma
crossi updated the test plan for D26683: KCM Notifications : fix applications behavior not properly updated in KCM.
Wed, Jan 15, 8:58 AM · Plasma
crossi requested review of D26683: KCM Notifications : fix applications behavior not properly updated in KCM.
Wed, Jan 15, 8:55 AM · Plasma

Tue, Jan 14

crossi requested review of D26653: KCM Joystick : restore Default button to allow reset calibration..
Tue, Jan 14, 10:26 AM · Plasma
crossi committed R108:687fcd820341: KCM KWinDecoration port to KConfigXT (authored by crossi).
KCM KWinDecoration port to KConfigXT
Tue, Jan 14, 10:07 AM
crossi closed D25949: KCM KWinDecoration port to KConfigXT.
Tue, Jan 14, 10:07 AM · KWin

Mon, Jan 13

crossi updated the diff for D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..

API documentation. Schedule settingsChanged(). Clean up the list. Code style.

Mon, Jan 13, 2:24 PM · Frameworks

Fri, Jan 10

crossi updated the diff for D26082: Provide a method to query isImmutable attribute of a setting related to notification..

space

Fri, Jan 10, 5:10 PM · Plasma
crossi updated the diff for D26082: Provide a method to query isImmutable attribute of a setting related to notification..

Add API documentation

Fri, Jan 10, 5:07 PM · Plasma
crossi updated the diff for D26047: Expose KConfig settings to allow registration in KCM Notification.

Add API documentation

Fri, Jan 10, 5:07 PM · Plasma

Mon, Jan 6

crossi updated the diff for D25949: KCM KWinDecoration port to KConfigXT.

Break down nested ternary statement, add properies with explicit identifiers. Fix availableButtonsGrid.dragging property

Mon, Jan 6, 1:32 PM · KWin
crossi committed R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port (authored by crossi).
Restore notifier on AnimationDurationFactor that was lost during KConfig XT port
Mon, Jan 6, 11:04 AM
crossi closed D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port.
Mon, Jan 6, 11:04 AM · Plasma

Dec 20 2019

crossi added a comment to D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly.

some nitpicks, otherwise looks good.

Dec 20 2019, 2:03 PM · Plasma

Dec 18 2019

crossi added inline comments to D26047: Expose KConfig settings to allow registration in KCM Notification.
Dec 18 2019, 2:02 PM · Plasma
crossi requested review of D26083: KCM Notifications : disable settings that are immutable.
Dec 18 2019, 1:37 PM · Plasma
crossi requested review of D26082: Provide a method to query isImmutable attribute of a setting related to notification..
Dec 18 2019, 1:37 PM · Plasma
crossi added a comment to D26039: [Plasma Style KCM] Add search filter.
  • Only move to the next theme if the current selected one is marked for deletion

    FYI I could spot this same bug in the colors kcm. Will fix after this
Dec 18 2019, 10:57 AM · Plasma
crossi added a comment to D26039: [Plasma Style KCM] Add search filter.
  • Reinstate isSaveNeeded
  • Fix initial index and pendingDeletion
Dec 18 2019, 7:59 AM · Plasma

Dec 17 2019

crossi updated subscribers of D26039: [Plasma Style KCM] Add search filter.
Dec 17 2019, 12:58 PM · Plasma
crossi added a comment to D26039: [Plasma Style KCM] Add search filter.

Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality.

Dec 17 2019, 12:54 PM · Plasma
crossi added inline comments to D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Dec 17 2019, 12:33 PM · Frameworks
crossi added inline comments to D26045: Add immutability to KCM Icons.
Dec 17 2019, 9:30 AM · Plasma
crossi added inline comments to D26052: KCM Cursor Theme : Use ManagedConfigModule.
Dec 17 2019, 9:21 AM · Plasma
crossi added inline comments to D24846: Port kcm icons to kconfigxt.
Dec 17 2019, 8:56 AM · Plasma
crossi added a comment to D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.

Still some minor issue, looking good otherwise.

Dec 17 2019, 8:44 AM · KWin
crossi added inline comments to D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Dec 17 2019, 7:57 AM · Frameworks

Dec 16 2019

crossi requested review of D26048: KCM Notification port to ManagedConfigModule.
Dec 16 2019, 4:01 PM · Plasma
crossi requested review of D26047: Expose KConfig settings to allow registration in KCM Notification.
Dec 16 2019, 3:53 PM · Plasma
crossi requested review of D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton..
Dec 16 2019, 3:42 PM · Frameworks
crossi added a comment to D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.

Much better with isDefaults and isSaveNeeded override.

Dec 16 2019, 8:51 AM · KWin

Dec 13 2019

crossi updated the diff for D25949: KCM KWinDecoration port to KConfigXT.

proper naming (camel case)

Dec 13 2019, 2:32 PM · KWin
crossi updated the diff for D25949: KCM KWinDecoration port to KConfigXT.

Fix wrong default value in kcfg

Dec 13 2019, 2:01 PM · KWin
crossi requested review of D25949: KCM KWinDecoration port to KConfigXT.
Dec 13 2019, 1:32 PM · KWin

Dec 11 2019

crossi added a comment to D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule.

Some qml nitpicks on signal handler

Dec 11 2019, 2:43 PM · KWin
crossi added inline comments to D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings.
Dec 11 2019, 2:37 PM · KWin

Dec 10 2019

crossi added a comment to D25792: Add notifiers to workspace options kcfg.

Thanks @davidedmundson for spotting this regression.

Dec 10 2019, 1:10 PM · Plasma
crossi requested review of D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port.
Dec 10 2019, 1:09 PM · Plasma

Nov 29 2019

crossi committed R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties (authored by crossi).
KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties
Nov 29 2019, 12:10 PM
crossi committed R119:2b2383cc77f6: KCM launch feedback : take into account immutable properties (authored by crossi).
KCM launch feedback : take into account immutable properties
Nov 29 2019, 12:10 PM
crossi closed D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.
Nov 29 2019, 12:10 PM · Plasma
crossi committed R119:a7089ca61db2: KCM Style : take into account immutable properties (authored by crossi).
KCM Style : take into account immutable properties
Nov 29 2019, 12:10 PM
crossi closed D25526: KCM launch feedback : take into account immutable properties.
Nov 29 2019, 12:10 PM · Plasma
crossi committed R119:dd9a6da45f9e: KCM KSplash : take into account immutable property (authored by crossi).
KCM KSplash : take into account immutable property
Nov 29 2019, 12:10 PM
crossi closed D25525: KCM Style : take into account immutable properties.
Nov 29 2019, 12:10 PM · Plasma
crossi closed D25524: KCM KSplash : take into account immutable property.
Nov 29 2019, 12:10 PM · Plasma
crossi committed R119:277bb04e7455: KCM LookAndFeel : take into account immutable property (authored by crossi).
KCM LookAndFeel : take into account immutable property
Nov 29 2019, 12:10 PM
crossi closed D25523: KCM LookAndFeel : take into account immutable property.
Nov 29 2019, 12:10 PM · Plasma
crossi committed R119:298611977e3b: KCM Colors : take into account immutable property (authored by crossi).
KCM Colors : take into account immutable property
Nov 29 2019, 12:06 PM
crossi closed D25522: KCM Colors : take into account immutable property.
Nov 29 2019, 12:06 PM · Plasma

Nov 28 2019

crossi retitled D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties from KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties to KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.
Nov 28 2019, 9:19 AM · Plasma
crossi updated the diff for D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.

typo

Nov 28 2019, 9:19 AM · Plasma
crossi requested review of D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.
Nov 28 2019, 9:12 AM · Plasma

Nov 26 2019

crossi abandoned D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM.

No longer need since 866d3f45b84e

Nov 26 2019, 2:49 PM · Frameworks
crossi updated the summary of D25525: KCM Style : take into account immutable properties.
Nov 26 2019, 2:45 PM · Plasma
crossi updated the diff for D25525: KCM Style : take into account immutable properties.

adjustment since view.enabled also show disabled look and feel

Nov 26 2019, 2:43 PM · Plasma
crossi updated the diff for D25522: KCM Colors : take into account immutable property.

fix style issue

Nov 26 2019, 2:41 PM · Plasma

Nov 25 2019

crossi added inline comments to D25526: KCM launch feedback : take into account immutable properties.
Nov 25 2019, 4:26 PM · Plasma
crossi updated the diff for D25526: KCM launch feedback : take into account immutable properties.

Make the property readonly, boolean condition to repeat the same pattern enabled: !immutable

Nov 25 2019, 4:21 PM · Plasma
crossi updated the diff for D25526: KCM launch feedback : take into account immutable properties.

blank line

Nov 25 2019, 3:33 PM · Plasma
crossi added reviewers for D25526: KCM launch feedback : take into account immutable properties: ervin, bport, mart, davidedmundson, Plasma.
Nov 25 2019, 3:30 PM · Plasma
crossi requested review of D25526: KCM launch feedback : take into account immutable properties.
Nov 25 2019, 3:30 PM · Plasma
crossi added reviewers for D25525: KCM Style : take into account immutable properties: ervin, bport, mart, davidedmundson, Plasma.
Nov 25 2019, 3:29 PM · Plasma
crossi added reviewers for D25524: KCM KSplash : take into account immutable property: ervin, bport, mart, davidedmundson, Plasma.
Nov 25 2019, 3:28 PM · Plasma
crossi added reviewers for D25523: KCM LookAndFeel : take into account immutable property: ervin, bport, mart, davidedmundson, Plasma.
Nov 25 2019, 3:28 PM · Plasma
crossi added reviewers for D25522: KCM Colors : take into account immutable property: ervin, bport, mart, davidedmundson, Plasma.
Nov 25 2019, 3:27 PM · Plasma
crossi added a dependent revision for D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM: D25525: KCM Style : take into account immutable properties.
Nov 25 2019, 3:26 PM · Frameworks
crossi requested review of D25525: KCM Style : take into account immutable properties.
Nov 25 2019, 3:26 PM · Plasma
crossi requested review of D25524: KCM KSplash : take into account immutable property.
Nov 25 2019, 3:25 PM · Plasma
crossi requested review of D25523: KCM LookAndFeel : take into account immutable property.
Nov 25 2019, 3:25 PM · Plasma
crossi requested review of D25522: KCM Colors : take into account immutable property.
Nov 25 2019, 3:25 PM · Plasma
crossi added a comment to D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM.

Can't you do view.enabled: false?
Edit: Never mind, view is bound to scroll.view, not scroll

Nov 25 2019, 2:20 PM · Frameworks
crossi requested review of D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM.
Nov 25 2019, 2:09 PM · Frameworks
crossi committed R119:ff86f0abb454: KCM launchfeedback : port to KConfig XT (authored by crossi).
KCM launchfeedback : port to KConfig XT
Nov 25 2019, 9:28 AM
crossi closed D25290: KCM launchfeedback : port to KConfig XT.
Nov 25 2019, 9:28 AM · Plasma
crossi committed R119:613d5e12871c: KCM LookAndFeel : port to KConfig XT (authored by crossi).
KCM LookAndFeel : port to KConfig XT
Nov 25 2019, 9:28 AM
crossi closed D25274: KCM LookAndFeel : port to KConfig XT.
Nov 25 2019, 9:28 AM · Plasma
crossi committed R119:561401636f7d: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound… (authored by crossi).
KCM Style : kcm state is handled by ManagedConfigModule, properties are bound…
Nov 25 2019, 9:28 AM
crossi closed D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Nov 25 2019, 9:28 AM · Plasma

Nov 19 2019

crossi added inline comments to D25395: Make avatar icon dpr aware aka HiDPI rendered.
Nov 19 2019, 2:48 PM · Plasma

Nov 18 2019

crossi added inline comments to D23316: Port towards KConfig XT.
Nov 18 2019, 1:26 PM · Spectacle

Nov 15 2019

crossi added inline comments to D25290: KCM launchfeedback : port to KConfig XT.
Nov 15 2019, 11:10 AM · Plasma
crossi updated the diff for D25290: KCM launchfeedback : port to KConfig XT.

Add enum declaration to make boolean settings in qml a bit more readable.

Nov 15 2019, 11:00 AM · Plasma

Nov 14 2019

crossi updated the diff for D25290: KCM launchfeedback : port to KConfig XT.

Use proper signal handler & Fix typo

Nov 14 2019, 1:02 PM · Plasma
crossi added inline comments to D25290: KCM launchfeedback : port to KConfig XT.
Nov 14 2019, 12:36 PM · Plasma

Nov 13 2019

crossi requested review of D25290: KCM launchfeedback : port to KConfig XT.
Nov 13 2019, 4:14 PM · Plasma
crossi committed R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT (authored by crossi).
KCM Colors : port color scheme state management to KConfigXT
Nov 13 2019, 9:32 AM
crossi closed D25198: KCM Colors : port color scheme state management to KConfigXT.
Nov 13 2019, 9:32 AM · Plasma

Nov 12 2019

crossi updated the diff for D25274: KCM LookAndFeel : port to KConfig XT.

misspelling

Nov 12 2019, 4:00 PM · Plasma
crossi updated the diff for D25274: KCM LookAndFeel : port to KConfig XT.

Add kcfg files

Nov 12 2019, 3:43 PM · Plasma
crossi requested review of D25274: KCM LookAndFeel : port to KConfig XT.
Nov 12 2019, 3:42 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

style + consistency

Nov 12 2019, 2:03 PM · Plasma
crossi added inline comments to D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Nov 12 2019, 1:08 PM · Plasma

Nov 8 2019

crossi added a comment to D25198: KCM Colors : port color scheme state management to KConfigXT.

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Nov 8 2019, 5:09 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

missed that one

Nov 8 2019, 5:02 PM · Plasma
crossi updated the diff for D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..

make access to selectedStyle more consistent

Nov 8 2019, 4:59 PM · Plasma
crossi requested review of D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler..
Nov 8 2019, 4:49 PM · Plasma

Nov 7 2019

crossi requested review of D25198: KCM Colors : port color scheme state management to KConfigXT.
Nov 7 2019, 5:11 PM · Plasma

Oct 31 2019

crossi closed D25000: Do not assign combobox currentIndex as it breaks binding..
Oct 31 2019, 10:40 AM · Plasma