KCM KWinTabBox port to KConfigXT : use generated kcfg settings to load and save config
AcceptedPublic

Authored by crossi on Tue, Feb 11, 3:09 PM.

Details

Reviewers
ervin
bport
meven
zzag
Group Reviewers
KWin

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 22402
Build 22420: arc lint + arc unit
crossi created this revision.Tue, Feb 11, 3:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptTue, Feb 11, 3:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
crossi requested review of this revision.Tue, Feb 11, 3:09 PM
crossi added a reviewer: KWin.Tue, Feb 11, 3:24 PM
zzag added a subscriber: zzag.Tue, Feb 11, 3:59 PM
zzag added inline comments.
kcmkwin/kwintabbox/kwinpluginssettings.kcfg
16

Do we actually need code="true"?

crossi updated this revision to Diff 75481.Tue, Feb 11, 4:11 PM

remove unneeded code attribute.

crossi marked an inline comment as done.Tue, Feb 11, 4:12 PM
zzag accepted this revision.Tue, Feb 11, 4:37 PM

+1

kcmkwin/kwintabbox/main.h
73–75

Minor nitpick: it seems like there's no any reason to pass config by reference now. At each call site, we de-reference a settings object. I suggest to pass config by pointer.

This revision is now accepted and ready to land.Tue, Feb 11, 4:37 PM
meven accepted this revision.Tue, Feb 11, 5:47 PM
crossi updated this revision to Diff 75551.Wed, Feb 12, 2:23 PM

pass by pointer instead of ref

crossi marked an inline comment as done.Wed, Feb 12, 2:24 PM
ervin accepted this revision.Wed, Feb 12, 4:30 PM