In T14860#263323, @alex wrote:Not sure if KCModuleLoader::isDefaults needs a replacement, it is just loading the plugin & calling KCModuleData::isDefaults().
Also it only seems to be used in systemsettings, consequently calling the stuff there manually seems fine IMHO.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Sep 22 2021
Sep 22 2021
May 11 2020
May 11 2020
crossi added a comment to D28662: KCM LookAndFeel check widgetStyle availability before applying it.
In D28662#664211, @heikobecker wrote:This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.:
14:11:19 FAIL! : KcmTest::testKCMSave() Compared values are not the same 14:11:19 Actual (cg.readEntry("widgetStyle", QString())): "" 14:11:19 Expected (QString("testValue")) : "testValue" 14:11:19 Loc: [/home/jenkins/workspace/Plasma/plasma-desktop/stable-kf5-qt5 SUSEQt5.14/kcms/lookandfeel/autotests/kcmtest.cpp(185)]https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/23/console
May 5 2020
May 5 2020
crossi added inline comments to D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.
crossi updated the summary of D29443: KCM KWinVirtualDesktops disable UI when settings are immutable.
restore blank lines
May 4 2020
May 4 2020
crossi added reviewers for D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI: bport, meven, ngraham, davidedmundson, Plasma.
crossi requested review of D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI.
Apr 30 2020
Apr 30 2020
Merge branch 'Plasma/5.18'
crossi committed R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader() (authored by crossi).
KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()
crossi updated the summary of D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
crossi updated the diff for D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
consider Kai's comments
crossi added a comment to D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
In D29285#660158, @broulik wrote:Can this go into 5.18?
Apr 29 2020
Apr 29 2020
crossi updated the summary of D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader().
some code style related comments
Apr 27 2020
Apr 27 2020
Apr 23 2020
Apr 23 2020
crossi committed R119:6d12d2d62607: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic (authored by crossi).
KCM Notifications : Manage app-specific notifications with KCconfigXT's magic
crossi updated the test plan for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
clear the nitpicks
crossi updated the test plan for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
Consider Kai's comments
KCM KWinScreenEdge fix build issue
Apr 22 2020
Apr 22 2020
Update code comment accordingly
Merge branch 'Plasma/5.18'
crossi committed R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it. (authored by crossi).
KCM LookAndFeel check if splash screen is provided before applying it.
crossi committed R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it (authored by crossi).
KCM LookAndFeel check widgetStyle availability before applying it
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
use qAsConst, indent
crossi updated the summary of D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
crossi updated the diff for D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic.
maange reset to default application notification
crossi committed R108:cf7762eaa874: KCM KWinScreenEdges disable widgets if is immutable (authored by crossi).
KCM KWinScreenEdges disable widgets if is immutable
crossi committed R108:a9c0337113c5: KCM KWinTouchEdges disable edge if is immutable (authored by crossi).
KCM KWinTouchEdges disable edge if is immutable
KCM KWinScreenEdges port to KConfigXT
KCM KWinTouchScreen port to KConfigXT
crossi committed R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings (authored by crossi).
libnotificationmanager : add app-specific kconfig settings
crossi committed R237:00213a3a0906: kconfig_compiler : generate kconfig settings with subgroup (authored by crossi).
kconfig_compiler : generate kconfig settings with subgroup
Apr 20 2020
Apr 20 2020
Work on fonts and style
Apr 14 2020
Apr 14 2020
crossi committed R108:3284e19646df: KCM KWinTabbox disable widget if property is immutable. (authored by crossi).
KCM KWinTabbox disable widget if property is immutable.
crossi added a dependent revision for D28475: KCM KWinScreenEdges port to KConfigXT: D28508: KCM KWinScreenEdges disable widgets if is immutable.
crossi added a dependency for D28507: KCM KWinTouchEdges disable edge if is immutable: D27862: KCM KWinTouchScreen port to KConfigXT.
crossi added a dependent revision for D27862: KCM KWinTouchScreen port to KConfigXT: D28507: KCM KWinTouchEdges disable edge if is immutable.
Fix action Present Windows - Current desktop that was saved as All desktop and vice versa
crossi updated the diff for D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Fix comments
These new properties can be managed by KConfig.
It will automatically handle the read/write process and isSaveNeeded/isDefault status.
Apr 8 2020
Apr 8 2020
crossi updated the test plan for D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Apr 7 2020
Apr 7 2020
crossi requested review of D28662: KCM LookAndFeel check widgetStyle availability before applying it.
Fix two little things
crossi requested review of D28656: KCM LookAndFeel check if splash screen is provided before applying it..
Apr 6 2020
Apr 6 2020
port KCM cursor theme
fix import
crossi added a dependent revision for D27840: Introduce SettingState* elements to ease KCM writing: D28629: [WIP] Port KCM to SettingStateBinding.
crossi added a comment to D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding.
The indicators are not well placed.
crossi requested review of D28622: [WIP] Port KCM KWin Decoration and VirtualDesktop to SettingStateBinding.
Apr 2 2020
Apr 2 2020
crossi committed R119:443b028a1cb3: KCM Colors fix apply button always disabled (authored by crossi).
KCM Colors fix apply button always disabled
fix defaults
fix defaults
Apr 1 2020
Apr 1 2020
proper naming
KCM KWinTabBox manage KCModule states
fix error
crossi added a dependency for D28475: KCM KWinScreenEdges port to KConfigXT: D27862: KCM KWinTouchScreen port to KConfigXT.
crossi added a dependent revision for D27862: KCM KWinTouchScreen port to KConfigXT: D28475: KCM KWinScreenEdges port to KConfigXT.
rename include guard
Mar 31 2020
Mar 31 2020
From previous revision, I moved code related to the Monitor part in the ui in a separate class KWinScreenEdge, that will be used by KCM KWinScreenEdges to remove duplicated code and ease the port to KConfigXT.
crossi retitled D27862: KCM KWinTouchScreen port to KConfigXT from [WIP] KCM KWinTouchScreen port to KConfigXT to KCM KWinTouchScreen port to KConfigXT.
rework to allow code reuse in KCM KWinScreenEdges