mdawson (Matthew Dawson)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 6 2015, 11:20 PM (227 w, 3 d)
Availability
Available

Recent Activity

Aug 7 2019

mdawson accepted D22979: Security: remove support for $(...) in config keys with [$e] marker..
Aug 7 2019, 1:13 PM · Frameworks
mdawson added a comment to D22979: Security: remove support for $(...) in config keys with [$e] marker..

LGTM. Regarding the test, if we want to get this change in asap due to the security focus I can submit a follow up patch re-adding it.

Aug 7 2019, 2:14 AM · Frameworks

Jul 8 2018

mdawson accepted D13947: Honor BUILD_TESTING.

LGTM, thanks!

Jul 8 2018, 6:59 PM · Frameworks

Jul 7 2017

mdawson added a comment to D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab..

+1 LGTM. Before submitting, can you poke the usability people about this change please? If they are also happy, then it's got a ship it from me.

Jul 7 2017, 5:47 PM · Frameworks

Apr 25 2017

mdawson accepted D5502: Fix relativePath calculation in KDesktopFile::locateLocal().

LGTM! Thanks for working on this.

Apr 25 2017, 6:41 PM · Frameworks

Apr 23 2017

mdawson requested changes to D5502: Fix relativePath calculation in KDesktopFile::locateLocal().

Excellent! Could you add 4 more rows to the tests, to ensure a path without a folder (ex. systemConfigLocation + "/test.desktop") works correctly? Once that's done, it's a ship it from me.

Apr 23 2017, 5:08 AM · Frameworks

Apr 19 2017

mdawson added a comment to D5502: Fix relativePath calculation in KDesktopFile::locateLocal().

Can you please add some unit tests for this, to ensure it doesn't break in the future? I think just three extra tests, one for a desktop file in a config directory, one in a data directory, and one present elsewhere would be enough.

Yes, I'll try.
Though it will take till tomorrow I suppose...

Apr 19 2017, 2:47 PM · Frameworks
mdawson requested changes to D5502: Fix relativePath calculation in KDesktopFile::locateLocal().

+1 This definitely looks like the correct fix.

Apr 19 2017, 2:28 PM · Frameworks

Feb 20 2017

mdawson accepted D4604: KConfig: stop exporting and installing KConfigBackend..

Ship it!

Feb 20 2017, 11:13 PM · Frameworks
mdawson added inline comments to D4604: KConfig: stop exporting and installing KConfigBackend..
Feb 20 2017, 11:09 PM · Frameworks
mdawson requested changes to D4604: KConfig: stop exporting and installing KConfigBackend..

I agree, this can't be used so removing it from the API can't hurt anything. Just to be sure, let's take this change for the next release, but not change KConfigBackend' API/ABI until after the next release. If anyone complains about KConfigBackend missing before then, we can just re-export it easily. Otherwise this can always come back in a (ABI) different form if this ever becomes worthwhile. Does that sound good to you?

Feb 20 2017, 10:56 PM · Frameworks

Feb 4 2017

mdawson committed R237:b939b48f8d5e: Don't link against kconfigdata.cpp in the kentrymaptest unit test. (authored by mdawson).
Don't link against kconfigdata.cpp in the kentrymaptest unit test.
Feb 4 2017, 7:54 AM

Dec 1 2016

mdawson accepted D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg.

LGTM!

Dec 1 2016, 10:57 PM

Sep 10 2016

mdawson committed R108:80586c785ea8: Fix compile error in kwin's logout effect when opengl is disabled. (authored by mdawson).
Fix compile error in kwin's logout effect when opengl is disabled.
Sep 10 2016, 5:51 AM
mdawson committed R108:27cf33628271: Fix compile error in kwin's logout effect when opengl. (authored by mdawson).
Fix compile error in kwin's logout effect when opengl.
Sep 10 2016, 5:51 AM

Feb 19 2016

mdawson added a comment to D990: KConfigIniBackend: Fix expensive detach in lookup.
In D990#18933, @kfunk wrote:
In D990#18925, @mdawson wrote:
In D990#18917, @kfunk wrote:
In D990#18912, @mdawson wrote:

LGTM.

Out of curiosity, why is the QHash detaching for you here? Or is this just a general fixup found with a linter? Either way, I'm happy to take it :)

Well, we're calling QHash::find on a non-const variable -> QHash::find detaches internally. Showed up in a Callgrind run.

Right, but looking at this function it looks like the QHash shouldn't have multiple copies which should prevent a detach in the first place. Thus I was curious what work load triggered the copies causing the detach.

Indeed, you're right. I just noticed it calls QHash::detach, but doesn't reallocate (-> non-shared container). This patch won't harm, though: constFind/constEnd is still faster, doesn't check whether the container is shared to begin with.

Feb 19 2016, 4:42 PM
mdawson added a comment to D990: KConfigIniBackend: Fix expensive detach in lookup.
In D990#18917, @kfunk wrote:
In D990#18912, @mdawson wrote:

LGTM.

Out of curiosity, why is the QHash detaching for you here? Or is this just a general fixup found with a linter? Either way, I'm happy to take it :)

Well, we're calling QHash::find on a non-const variable -> QHash::find detaches internally. Showed up in a Callgrind run.

Feb 19 2016, 3:12 PM
mdawson accepted D990: KConfigIniBackend: Fix expensive detach in lookup.

Out of curiosity, why is the QHash detaching for you here? Or is this just a general fixup found with a linter? Either way, I'm happy to take it :)

Feb 19 2016, 2:36 AM

Jan 5 2016

mdawson committed R135:3ad8b8a1506b: Fix unit test failure on machines with an empty ~/.qttest. (authored by mdawson).
Fix unit test failure on machines with an empty ~/.qttest.
Jan 5 2016, 8:45 AM

Dec 30 2015

mdawson committed R8:90721e76ea9d: Fix GHNS build. (authored by mdawson).
Fix GHNS build.
Dec 30 2015, 10:13 AM