Sorry!! forgot to add you as the author when I pushed :(

We can have the slotRefreshSymbol() merging in a different patch.

I guess the tree flickering comes from the fact that when you edit the document you change the cursor position and the current item might changed even if it shouldn't. Adding a 2s delay only slows down the flickering, but the actual problem, that the wrong item is being activated is now even worse.

What I still would like to have in this patch is the preventing of the m_currItemTimer from being started while m_updateTimer is active.

You cannot measure the CPU consumption of this particular function by looking at the "System Activity" while scrolling up and down the file. There are a million other code paths that get executed while you scroll the page. System Activity gives you an average CPU load of the application during 2000ms. This less than 1ms function only gets called once when you start scrolling and once when you stop.

It definitely does not mean "The CPU waste does not matter".

Hmm... I'm not totally convinced ;)

I did it already :)

Just any way you want with the unused parameter. I'm not consistent with that..., but the warning is a no-no ;)

Thanks for the patch!

Thanks for the review request!

Thanks for the fix! Please commit.

Sorry I did not notice this request before the 2.1.0.1 release :(

If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)

Good idea!

I just discussed with a college and I have changed my mind :)

My feeling at the moment is that I would like to have the pattern for directory-only to be xxxx/ and not xxxx/* because the later matches all children in folder xxxx and not the folder itself... I wonder what is more intuitive...

I did a quick test and the xxxx/ works, but at the same time I noticed that I do very similar filtering separately for the project plugin. I think I need to move the filtering to one function in FolderFilesList and maybe remove "Folder" from the class name...

According to my tests build* does work as expected, but build/* does not work. I'm actually a bit surprised that the latter works in "Project" mode.

For some reason this review was not closed automatically by the commit. Closing manually.

Thanks for fixing the translation! :) Please commit.

Thanks! Besides the question about the conversion I think this is good to go.

Hmm... This patch causes my terminal to just flash up and then disappear immediately...

I'm OK with making this an optional dependency.

In D7647#158667, @markg wrote:

I resign (for now), i need to retest this.
Sars brought up a very valid point that i didn't even consider yet. You do introduce some hybrid between single- and double click flows while potentially breaking current flows.

To be continued..

In D7647#158264, @akrutzler wrote:

If you change focus after selecting an item and then give focus back to dolphin by clicking the selected item it starts the edit. In my book that is not what you want ;)

That's indeed what we want. Have a look at my reply to your last inline comment :)

Are you aware that dragging a selection to anywhere in kate, except the document view, will create a new file with the selection. But that requires mouse action....

In D7647#158040, @akrutzler wrote:

The focus lost-abort triggers abortTwoClicksRenaming() before the second click. That means that changing focus window does not cancel the rename.

The focus-lost-cancellation works pretty well for me.

I just tried the patch and I don't think the cancellation works as intended. The cancellation only works for double-click or selection change during the double-click period. The focus lost-abort triggers abortTwoClicksRenaming() before the second click. That means that changing focus window does not cancel the rename.

I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark.

This new iteration is much better :)

I think "spaceWidth() / 2" goes a little bit too far.

The point 2) problem that I described is what I get from a Windows 7 installation.... Wonder why you get a different result.

The problematic things for me are:

Nice plugin :)

I think I fixed it.
The comment about the dragging was only partially correct. The press must be inside the slider for dragging, so when the initial press is outside or not translated from the mini-map coordinates, the dragging does not start.

Use qBound() + remove one set of unneeded parenthesis

Reasoning behind the change of behavior:

https://commits.kde.org/ktexteditor/1bd9d474763ca891ef67c736398289cfd61bf21f

I searched through the kdevelop repo and found marks 8, 21-27 in use + the "reserved" for Bookmark,... So for KDevelop it looks OK, but we have other users also.

We could think about adding default shortcuts also for go-to-next-match and search-in-new-tab

At least Ubuntu has a non-zero sudo-timeout and the attack can also be executed on the konsole window after the first sudo command, but I think it is a good idea to educate people about sudoedit. And you have to start somewhere :)