Remove obsolete QScript includes from CMake files
ClosedPublic
Actions

Authored by sars on Dec 11 2017, 8:09 PM.

Details

Reviewers

cullmann
dhaumann

Group Reviewers

Kate

Commits

R40:4a157701ad3f: Remove obsolete QScript includes from CMake files

Summary

During the porting-away from QScript, a few unneeded finds and target_linking of QScript remained. This patch removes the last traces of QScript from Kate.

Is this something that should be back-ported to 17.12?

Test Plan

I have compiled Kate on Windows totally without QScript and tried all the plugins that has QScript in the CMakeLists.txt (except the SQL plugin that is not compiled because I don't have KWallet compiled)

Diff Detail

Repository

R40 Kate

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sars created this revision.Dec 11 2017, 8:09 PM

Restricted Application added a project: Kate. · View Herald TranscriptDec 11 2017, 8:09 PM

sars requested review of this revision.Dec 11 2017, 8:09 PM

Looks good to me. I don't think a backport is really necessary, or?

This revision is now accepted and ready to land.Dec 11 2017, 10:41 PM

Closed by commit R40:4a157701ad3f: Remove obsolete QScript includes from CMake files (authored by sars). · Explain WhyDec 12 2017, 5:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			addons/katesql/CMakeLists.txt (2 lines)
M			addons/project/CMakeLists.txt (2 lines)
M			addons/search/CMakeLists.txt (2 lines)
M			addons/snippets/CMakeLists.txt (2 lines)