The strings from sane requires a different translation domain.
Wraps the i18n calls to a special function instead of simply
redefining TRANSLATION_DOMAIN because in some files the calls
to *i18n* with the default domain are interleaved with the
i18n calls to strings from Sane.
Remove the old (and now useless) commented porting notes about
re-adding the support for the sane-backends translation domain.
Details
Details
- Reviewers
sars - Commits
- R382:fc30bcf15d0d: Fix translations from Sane
The strings are shown when KSaneWidget is used (for example
inside Skanlite).
Diff Detail
Diff Detail
- Repository
- R382 KSane Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks! Besides the question about the conversion I think this is good to go.
src/options/ksaneoption.h | ||
---|---|---|
53 | Why the conversion: const char* -> QLatin1String -> const char* ? |
src/options/ksaneoption.h | ||
---|---|---|
53 | Because in the process of trying to find the simplest fix, I originally added the call to another place where this dance was required; or at least I did something wrong and it was not workin; and then I didn't try to simplify. It does indeed work without the double conversion; new patch incoming. |