[Build Addon] Force LTR direction on the treeWidget for RTL locales
ClosedPublic

Authored by safaalfulaij on Jan 21 2018, 4:45 AM.

Details

Summary

In RTL locales, the tree widget (showing target set and errors) is mirrored and
unusable, this should force it’s direction to be LTR.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
safaalfulaij created this revision.Jan 21 2018, 4:45 AM
Restricted Application added a project: Kate. · View Herald TranscriptJan 21 2018, 4:45 AM
safaalfulaij requested review of this revision.Jan 21 2018, 4:45 AM

Before:

After:

I don't know but should we also use the fixed-width font here? Since it is parsed I don't see the need of it, and it will make the widget strange a bit.

safaalfulaij retitled this revision from [Build Addon] For LTR direction on the treeWidget for RTL locales to [Build Addon] Force LTR direction on the treeWidget for RTL locales.Jan 21 2018, 4:50 AM
sars accepted this revision as: sars.Jan 22 2018, 6:58 AM

If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)

This revision is now accepted and ready to land.Jan 22 2018, 6:58 AM
In D10003#194173, @sars wrote:

If that is the right thing to do for RTL locales then go for it. It does not change anything for LTR locales :)

It is the right thing since compilers are in English already :)
That is also why KTextEditor was kept LTR in the first place, it is much usefull for programming like that, while having normal text aligned with correct RTL direction.

This revision was automatically updated to reflect the committed changes.